From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kFOzNuL6n18dJAAA0tVLHw (envelope-from ) for ; Mon, 02 Nov 2020 12:26:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kM54MuL6n1+KQAAAB5/wlQ (envelope-from ) for ; Mon, 02 Nov 2020 12:26:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C2879401BE for ; Mon, 2 Nov 2020 12:26:10 +0000 (UTC) Received: from localhost ([::1]:39594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZYuW-0003Cy-NI for larch@yhetil.org; Mon, 02 Nov 2020 07:26:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZYuQ-0003Cq-QY for guix-patches@gnu.org; Mon, 02 Nov 2020 07:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZYuQ-0004uj-HM for guix-patches@gnu.org; Mon, 02 Nov 2020 07:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZYuQ-0008K3-Dr for guix-patches@gnu.org; Mon, 02 Nov 2020 07:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44321] [PATCH 5/6] transformations: Raise '&formatted-message' exceptions instead of 'leave'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Nov 2020 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44321 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas , 44321@debbugs.gnu.org Received: via spool by 44321-submit@debbugs.gnu.org id=B44321.160431993931958 (code B ref 44321); Mon, 02 Nov 2020 12:26:02 +0000 Received: (at 44321) by debbugs.gnu.org; 2 Nov 2020 12:25:39 +0000 Received: from localhost ([127.0.0.1]:40025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZYu2-0008JO-Si for submit@debbugs.gnu.org; Mon, 02 Nov 2020 07:25:39 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZYu1-0008JC-8U for 44321@debbugs.gnu.org; Mon, 02 Nov 2020 07:25:37 -0500 Received: by mail-qk1-f196.google.com with SMTP id z6so11273163qkz.4 for <44321@debbugs.gnu.org>; Mon, 02 Nov 2020 04:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4FiON76gEnbuQLgVEjTuU+W7klGOnPVJEWoCv6KdZ0w=; b=dP90/KulYaz8qYzn/DFgn/1mfWX5NYstoJwmP2F3V9I9a+7f3QwvG3kAuOfb7se2S9 Qi0yiDJNQHAAQoVamT3W38Crvu6yoCqFg6A+RtXxgBLuWqwMCCZhJONuTbuXZujmTfTu wFfJjdKKiQd5oz0nu3tcDyt2FD9n/laxs+Q448u8SWl8IvEj3K8giQjTqlm5EzYk0RMP kN00/bPAzagL/b6XNNrbnEi5EbJZjwygLbYEU6HH9puLuaLjlpxD1PwMVgMSJ4YapN0X D3jkNQEgpx5dBgiPIpY4Y5DXRNUBqNz1TAthFaZEVVg7bIOO6oz8lCjGEHvudl6Islec GJxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4FiON76gEnbuQLgVEjTuU+W7klGOnPVJEWoCv6KdZ0w=; b=dHO6IKBpLoK3w9uICmS2BlPX8Qp7A4OlaOLjYE4BpNSEjDqt/HToCfqqVPIOLsXPVp y7U7G2os7eb6r8IVT9pWyf/1PUuFMDReXE8qJeQIdfhbz0YDa74lxcVjd2FCaSTRiSy+ I0Ym55RKvjbyCwgExpIY0vE7oTB4HFwtKCZVkDz/EfR8FvwsJQVcV0y7Pf3lCvU+MQ7w uhjJDceBiXDzK0bdCCqSrHCIxqQcrPbxmzhBvbAyNgRgoq1Os3KRJhrY3d+SXXydwWI0 qLu5MsNOTJS1IjGSkBWiRRthoVso2pIC86dogjqaUOMCV65fxG7cCuj0AvNPWhx1/Lrd e4JQ== X-Gm-Message-State: AOAM530exoY1fQnK7LvioPWOtJ0vTF/C458YsJV6Mf9n+9B0i7LPALGh +ORC2uQDSmUc85mopdEyhkOTV6SHTjT/WoyWgcs= X-Google-Smtp-Source: ABdhPJwym5Y1q8RemNlV43ipgNO25/rASdcMHcCmb0cgAADIAcMOdt166D7Y1vVqYG5bnzuYZGxD4XHMVc6zGM3yEak= X-Received: by 2002:a37:814:: with SMTP id 20mr8445215qki.304.1604319931766; Mon, 02 Nov 2020 04:25:31 -0800 (PST) MIME-Version: 1.0 References: <20201029231000.14568-1-ludo@gnu.org> <20201029231000.14568-5-ludo@gnu.org> <878sbo6ku6.fsf@gmail.com> <87sg9v49vc.fsf@gmail.com> <87imaqwvyx.fsf@gnu.org> In-Reply-To: <87imaqwvyx.fsf@gnu.org> From: zimoun Date: Mon, 2 Nov 2020 13:25:20 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=dP90/Kul; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: wNZeTT7KoPLJ Hi, Thanks for the explanation. On Sat, 31 Oct 2020 at 11:06, Ludovic Court=C3=A8s wrote: > >> Naive question: what is the difference? Other said why? And so why n= ot > >> replaces =E2=80=99leave=E2=80=99 here and there by =E2=80=99raise=E2= =80=99+=E2=80=99formatted-message=E2=80=99? > > > > Probably Ludo can explain better, but the main difference I see is that > > leave (guix diagnostics) calls exit, so the client code now can handle > > these errors and it isn't forced to exit. > > Exactly. In fact, =E2=80=98exit=E2=80=99 throws the 'quit exception, whi= ch one could > also catch, but it=E2=80=99s still nicer to throw &message or &formatted-= message > within a module meant to be used as a library. And so why not replace the 'leave' appearing here and there in the code by 'raise'+'formatted-message'? Cheers, simon