From mboxrd@z Thu Jan  1 00:00:00 1970
From: zimoun <zimon.toutoune@gmail.com>
Subject: Re: Guix search, colors and INSIDE_EMACS
Date: Tue, 11 Feb 2020 00:24:33 +0100
Message-ID: <CAJ3okZ11innKakxFig1Aka6maiJNS7s_3ufR3+Ebpe6BgC6rcw@mail.gmail.com>
References: <87blqeml4w.fsf@ambrevar.xyz> <87tv46qqlf.fsf@elephly.net>
 <CAJ3okZ1LerS0R5M1-kOUYZNFFnKqiPh0aa=xNpuR-e73dW2L_A@mail.gmail.com>
 <878slamdzp.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:60958)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <zimon.toutoune@gmail.com>) id 1j1IQ2-0000ib-Sq
 for guix-devel@gnu.org; Mon, 10 Feb 2020 18:24:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <zimon.toutoune@gmail.com>) id 1j1IQ1-00050H-V8
 for guix-devel@gnu.org; Mon, 10 Feb 2020 18:24:46 -0500
Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:39191)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <zimon.toutoune@gmail.com>)
 id 1j1IQ1-0004yy-Pb
 for guix-devel@gnu.org; Mon, 10 Feb 2020 18:24:45 -0500
Received: by mail-qt1-x82f.google.com with SMTP id c5so6585436qtj.6
 for <guix-devel@gnu.org>; Mon, 10 Feb 2020 15:24:45 -0800 (PST)
In-Reply-To: <878slamdzp.fsf@ambrevar.xyz>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: Guix Devel <guix-devel@gnu.org>

Hi Pierre,

On Mon, 10 Feb 2020 at 20:36, Pierre Neidhardt <mail@ambrevar.xyz> wrote:
>
> This patch looks good to me.  If no one objects I'd like to merge it.

Thank you to give a look.

The issue is that the highlight is not done and I am not happy with it. :-)
Have you a fix for that?


> > +                                   (commit (channel-commit channel))
> > +                                   (transformer hyperlink))
> >    "Return a hyperlink for COMMIT in CHANNEL, using COMMIT as the hyperlink's
> > -text.  The hyperlink links to a web view of COMMIT, when available."
> > +text.  The hyperlink links to a web view of COMMIT, when available.
> > +TRANSFORMER allows to control how the uri and text are."
>
> uri -> URI.
> "are displayed."
> We should also tell the arguments TRANSFORMER takes.

I will send you an update. And it will be up to you to merge it or not. :-)


Cheers,
simon