From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WHSaEa+ijV8TEQAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 14:29:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uOtdDa+ijV8vOQAAB5/wlQ (envelope-from ) for ; Mon, 19 Oct 2020 14:29:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE236940418 for ; Mon, 19 Oct 2020 14:29:02 +0000 (UTC) Received: from localhost ([::1]:36926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUW9l-00077o-Jg for larch@yhetil.org; Mon, 19 Oct 2020 10:29:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUW5u-00036i-Pk for guix-patches@gnu.org; Mon, 19 Oct 2020 10:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUW5u-0004Vu-BM for guix-patches@gnu.org; Mon, 19 Oct 2020 10:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUW5u-0007QX-80 for guix-patches@gnu.org; Mon, 19 Oct 2020 10:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44032] [PATCH] gnu: ocaml: Update to 4.11.1 Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Oct 2020 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44032 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 44032@debbugs.gnu.org Received: via spool by 44032-submit@debbugs.gnu.org id=B44032.160311748328517 (code B ref 44032); Mon, 19 Oct 2020 14:25:02 +0000 Received: (at 44032) by debbugs.gnu.org; 19 Oct 2020 14:24:43 +0000 Received: from localhost ([127.0.0.1]:41985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUW5a-0007Pt-KI for submit@debbugs.gnu.org; Mon, 19 Oct 2020 10:24:42 -0400 Received: from mail-qv1-f65.google.com ([209.85.219.65]:37336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUW5Z-0007Pe-4B for 44032@debbugs.gnu.org; Mon, 19 Oct 2020 10:24:41 -0400 Received: by mail-qv1-f65.google.com with SMTP id t6so4379064qvz.4 for <44032@debbugs.gnu.org>; Mon, 19 Oct 2020 07:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FJUTczWToc5w+0Cpy7tYLJFFKvCk47gIPNbm2mo9o8Q=; b=sdW0+bIv7o2Y0VbTA3LBuHJq/iUQxP0AiL5XuFZmIegLkeYlYJ1bRKvwEjDWFbIbJn 7XdhSKe34D40z6Zjk16jLdGwnP72ZY3A2mjrtAV2Ka23yw1bsNbCDw2Pqx6/V/WIJkqy moioAtZm8riIGk5pssrUEWKpNrTSkfzEdo2sylLsV15Rl/xMhLaV4Cz+7MYM7Z3KHXwq jYjf+n8oEtryqH4vCDmQ1l8ocFa8GDY9XeyV44fxlIA6Hyh8GjGYR5sonopLVUW2UPWj ThXzPmprcoW+doX7i0aYs7ImvDofQH3leW+E3FoWqNUT/qOG+yHDOXnk68RXwsY0BHxc wUIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FJUTczWToc5w+0Cpy7tYLJFFKvCk47gIPNbm2mo9o8Q=; b=e8riPxnlPwzQrFMSZ1M9qH8RAw69G6gGixISJs4g/SLu/dUiFjf0mlGqpm+DznFerX AnAz6KcybaR9OVcxQGwHlxdJZAwdddDgited1mS+jzCto3RvK11XdJUvupQA36nCeB29 CukiXoYjld1CZu3Hstg233Z9NXadOeqyFsErgjxS+6cTccqeyk4TjGYPMnKHifbmZJfL kZYkdtBwVbxHH/3biAXCOZ+zPUXtwNx8UljMAoV9Z73V9oqO6JJNAxG+3O7WKgissJsO zX9lAbBcxQ/N1FBhcOeO48hXQibmeiNX2NS5Bkt5tlnNhv7r0L0I1Q2HTZEwi51cEQXx lazA== X-Gm-Message-State: AOAM533/QAcfWHShU6xlqtYzeChLcHagtRq83t7r6W7nlqWQZonWywXQ G7W/M89q8I1wJz/nhoRbQNoI7nk+ehLJQHB9PWHJMVoHp9M= X-Google-Smtp-Source: ABdhPJwPYtBkKVrShDgTfb9iVhh6yQ1I+5e9Yfyu8jeBtf3O9BwuZk7JIyF3iMVYLp7WB62AI7f/G7au+h+vsNcwps4= X-Received: by 2002:a0c:bd2d:: with SMTP id m45mr17454945qvg.36.1603117474760; Mon, 19 Oct 2020 07:24:34 -0700 (PDT) MIME-Version: 1.0 References: <20201016171436.5f642654@tachikoma> <87y2k2fikr.fsf@gmail.com> <26294C8B-1271-4ED9-8B1C-9A6DDF7E9AEA@lepiller.eu> In-Reply-To: <26294C8B-1271-4ED9-8B1C-9A6DDF7E9AEA@lepiller.eu> From: zimoun Date: Mon, 19 Oct 2020 16:24:23 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=sdW0+bIv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: +cGvZ2TkeMID On Mon, 19 Oct 2020 at 16:11, Julien Lepiller wrote: > >> +(define-public ocaml4.09-csexp > >> + (package > >> + (inherit ocaml-csexp) > >> + (name "ocaml4.09-csexp") > >> + (arguments > >> + `(#:ocaml ,ocaml-4.09 > >> + #:findlib ,ocaml4.09-findlib > >> + ,@(substitute-keyword-arguments (package-arguments > >ocaml-csexp) > >> + ((#:dune _) (package-with-ocaml4.09 dune-bootstrap))))) > >> + (propagated-inputs > >> + `(("ocaml-result" ,(package-with-ocaml4.09 ocaml-result)))))) > > > >You do not use the one you define below. Why? Other said, do you > >really need 'ocaml4.09.result' defined below? > > Actually, the properties ensure that I actually use the one below :) I am not sure. You are recreating a package based on 'ocaml-result' and not using the package 'ocaml4.09-result'. Or I miss something about the symbols. > >> +(define-public ocaml4.09-result > >> + (package > >> + (inherit ocaml-result) > >> + (arguments > >> + `(#:test-target "." > >> + #:dune ,(package-with-ocaml4.09 dune-bootstrap) > >> + #:ocaml ,ocaml-4.09 > >> + #:findlib ,ocaml4.09-findlib)))) > > > >Since the name is not changed after inheritance, this package is > >ambiguous. And possibly do not compile. > > Ah right, thanks! Moreover, my point is: you are using once: (properties `((ocaml4.09-variant . ,(delay ocaml4.09-result)))) and once: `(("ocaml-result" ,(package-with-ocaml4.09 ocaml-result)))))) and it seems easier to only use one form. Other said, maybe you do not need the new 'ocaml4.09-result' and '(package-with-ocaml4.09 ocaml-result)' is enough. > >> - `(#:phases > >> + `(#:tests? #f; no tests > > > >Why? Because the tests are run during the build? If yes, does it make > >sense to move the comment there? > > No, the comment might have come from a previous version or just copied by mistake. There is really no test in this package (unless there's something weird going on with oasis scripts). Maybe reword the comment: "no test provided by the package"or something like that. All the best, simon