From: zimoun <zimon.toutoune@gmail.com>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 44032@debbugs.gnu.org
Subject: [bug#44032] [PATCH] gnu: ocaml: Update to 4.11.1
Date: Mon, 19 Oct 2020 16:24:23 +0200 [thread overview]
Message-ID: <CAJ3okZ0nEaJ5G636GAU2qer3ewj5Vi-UT=7myt+SEWZjV5S3EQ@mail.gmail.com> (raw)
In-Reply-To: <26294C8B-1271-4ED9-8B1C-9A6DDF7E9AEA@lepiller.eu>
On Mon, 19 Oct 2020 at 16:11, Julien Lepiller <julien@lepiller.eu> wrote:
> >> +(define-public ocaml4.09-csexp
> >> + (package
> >> + (inherit ocaml-csexp)
> >> + (name "ocaml4.09-csexp")
> >> + (arguments
> >> + `(#:ocaml ,ocaml-4.09
> >> + #:findlib ,ocaml4.09-findlib
> >> + ,@(substitute-keyword-arguments (package-arguments
> >ocaml-csexp)
> >> + ((#:dune _) (package-with-ocaml4.09 dune-bootstrap)))))
> >> + (propagated-inputs
> >> + `(("ocaml-result" ,(package-with-ocaml4.09 ocaml-result))))))
> >
> >You do not use the one you define below. Why? Other said, do you
> >really need 'ocaml4.09.result' defined below?
>
> Actually, the properties ensure that I actually use the one below :)
I am not sure. You are recreating a package based on 'ocaml-result'
and not using the package 'ocaml4.09-result'. Or I miss something
about the symbols.
> >> +(define-public ocaml4.09-result
> >> + (package
> >> + (inherit ocaml-result)
> >> + (arguments
> >> + `(#:test-target "."
> >> + #:dune ,(package-with-ocaml4.09 dune-bootstrap)
> >> + #:ocaml ,ocaml-4.09
> >> + #:findlib ,ocaml4.09-findlib))))
> >
> >Since the name is not changed after inheritance, this package is
> >ambiguous. And possibly do not compile.
>
> Ah right, thanks!
Moreover, my point is: you are using
once:
(properties `((ocaml4.09-variant . ,(delay ocaml4.09-result))))
and once:
`(("ocaml-result" ,(package-with-ocaml4.09 ocaml-result))))))
and it seems easier to only use one form. Other said, maybe you do
not need the new 'ocaml4.09-result' and '(package-with-ocaml4.09
ocaml-result)' is enough.
> >> - `(#:phases
> >> + `(#:tests? #f; no tests
> >
> >Why? Because the tests are run during the build? If yes, does it make
> >sense to move the comment there?
>
> No, the comment might have come from a previous version or just copied by mistake. There is really no test in this package (unless there's something weird going on with oasis scripts).
Maybe reword the comment: "no test provided by the package"or
something like that.
All the best,
simon
next prev parent reply other threads:[~2020-10-19 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:14 [bug#44032] [PATCH] gnu: ocaml: Update to 4.11.1 Julien Lepiller
2020-10-16 19:21 ` Brett Gilio
2020-10-19 13:31 ` zimoun
2020-10-19 14:11 ` Julien Lepiller
2020-10-19 14:24 ` zimoun [this message]
2020-10-19 15:14 ` Julien Lepiller
2020-11-10 15:07 ` bug#44032: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ0nEaJ5G636GAU2qer3ewj5Vi-UT=7myt+SEWZjV5S3EQ@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=44032@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.