From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id OFh5I+dPQWX2DAAAG6o9tA:P1 (envelope-from ) for ; Tue, 31 Oct 2023 20:05:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OFh5I+dPQWX2DAAAG6o9tA (envelope-from ) for ; Tue, 31 Oct 2023 20:05:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 431D25B1E1 for ; Tue, 31 Oct 2023 20:05:11 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OaheXIQ7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698779111; a=rsa-sha256; cv=none; b=ivtuG7IWSMt7AmnGfIdbD5u1osvpdW41fqOvIjGYkA2fRUU6+DO9MtSa36MwZ/n5BF7aYp hTFmZHXY+gDV3Mye6Cis3NOhRG7bnKmVZwU5NbMxlQBTcCVDJJcShZaDyJs3ep+r2F3shz mqxH/0xtTKILYrCThvtcMXrhJkOAmNxaWmSMgrH2pZk94tDn6Fw9a/jKkkz8dV20iHczvE MINfWLZy4dtISaZ4f6u3qdB2quPRFJm6mCtme6BBP4kTMdnlehCasg3z1Mhuhsa/0qxh7g /uj3V7JJdJDwIMZP0CYb/wmgQVLUTG3rvTspzOTuogZi5FDVcM2QxSu1Qi/x7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=OaheXIQ7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698779111; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Hn/ODctyiJTEJAUd6e32k95DxapynrNIlSGIm7oe5ho=; b=iLh+NVdg09ZnyF9bleDzvqTbfiachAPpm3DrGZeHYdx2Vx/zdT3e13MEvhD7abIGnlUrdx AN6KhkRddcSZtrT7+HfOShw56VlZDxvrsXmHDVRExFV6cCVZNWg7j14rjdHpYFcbtRB7zH wfGf18oD8Abc6MFEEgfBhrV7oHMLwB69UsRhgFOXytMtYVV8DapWp2PmnWWd4cx9Tk01WI 9iCjANoDpVpJJ6lSXJplTti2KYQpL6AqLeBxCQpPiRBALud3VyiVBFS8XCPEk31affF4fZ q3x5ZGUaUdUmbVrHGPvIvfLYWR4NPNV9xgjpc8G8SymYHu2Z5XC2cN1DAhHFOw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxu2Q-0005fS-Ll; Tue, 31 Oct 2023 15:04:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxu2P-0005ZS-8S for guix-patches@gnu.org; Tue, 31 Oct 2023 15:04:29 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxu2O-00073q-VL for guix-patches@gnu.org; Tue, 31 Oct 2023 15:04:28 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxu2w-0004tG-Bc for guix-patches@gnu.org; Tue, 31 Oct 2023 15:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169877908518770 (code B ref 66436); Tue, 31 Oct 2023 19:05:02 +0000 Received: (at 66436) by debbugs.gnu.org; 31 Oct 2023 19:04:45 +0000 Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxu2e-0004sg-Rg for submit@debbugs.gnu.org; Tue, 31 Oct 2023 15:04:45 -0400 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:41232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxu2a-0004sM-7a for 66436@debbugs.gnu.org; Tue, 31 Oct 2023 15:04:44 -0400 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6c7a4735a30so909810a34.1 for <66436@debbugs.gnu.org>; Tue, 31 Oct 2023 12:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698779038; x=1699383838; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hn/ODctyiJTEJAUd6e32k95DxapynrNIlSGIm7oe5ho=; b=OaheXIQ73c+FfG6J+GIx9jleAYNkwvnSSU589teqk91Fr0mnfsPZIiGfsFJ+Mu6bku S1jWqIJyzRsG/GQB+Fcupvl7WGHRoRIubumc0Wde6ejenPk9PI7hZ2FS/CbJOowSdRUi pGC08hjgHduO0u9lYwaZ9Msv/4IdkOh5cCMXERxsk6SJXNjIQ+sY3egjRMqt5fB8Xb92 b/6zk5WkI8InpV3oAv39vYPrWjRmcK2E2YGQPVAb+DfW0Jj/cc/+zbjKARx3txgP/j9q NJ5LbNulwULUUtga4/rHz8oEDw4tE7yi4uETrSr6M9RPdm7ncIoympe7akOKJiC5ut0J M3wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698779038; x=1699383838; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hn/ODctyiJTEJAUd6e32k95DxapynrNIlSGIm7oe5ho=; b=ValfbJp3jYLV7QB80ChqiFBt+Ktj8L137Vyg1tepQcIvnTaAKY10FJOxkqitjFOFGu +cGyRENucDP7RQ9X5CcvWLQhLkTdWryGcV180lR3vEi8BqBxp47tBHLdayX5x3ct84Ci HdEC7zRz51yW63O6jeHF5TxnoWD0fbrAna3NiS1HZKs2vsZzxfQ1bVNxBFwFgLJKk0xI h7PrdgaVfgsZdFcy8IP0KyAIlvf0VIRCFl5G3oVRqGjnpW6YEJv2lMhh+ofPvKk/eNkx ZebomKuo0CIVFswAnP3TYjwR3K3x6qkkTy3LyrK7FeS4PP8j9guWqgVzdvEpWBNnaFBl JnIg== X-Gm-Message-State: AOJu0Yxks3nuDZdaVuWa2LoOshMBdDkUR7F75ysN5X6ATLAgTxnTcE7N lP6692eoMHKSvfnqI9aihPXdz92nQOGBXc4qw20= X-Google-Smtp-Source: AGHT+IHpB3xOmDc7hEWyIqVs4v5psvQJPcPEEN5uDhpB7T/ynCOtscMGCkDQuAsv/VEmobpc13jMI217CKWFRnfObno= X-Received: by 2002:a05:6808:2024:b0:3ad:f3c0:5da3 with SMTP id q36-20020a056808202400b003adf3c05da3mr15352512oiw.3.1698779038745; Tue, 31 Oct 2023 12:03:58 -0700 (PDT) MIME-Version: 1.0 References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <86il6wv200.fsf@gmail.com> <86bkcov1j2.fsf@gmail.com> <87jzr2pqrq.fsf@gmail.com> In-Reply-To: <87jzr2pqrq.fsf@gmail.com> From: Simon Tournier Date: Tue, 31 Oct 2023 20:03:47 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 431D25B1E1 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.28 X-Spam-Score: -2.28 X-TUID: wBTNJQzloj+Q Hi Maxim, On Tue, 31 Oct 2023 at 19:53, Maxim Cournoyer wrote: > >> IMHO, it is worth to clearly state: [...] > That's already mentioned in 'Submitting Patches': [...] > I don't think we should repeat it here :-) (also, we now have CI, which > should be more apt at catching breakage here). We are listing the expectations for the Review process, therefore repeat that the dependencies need to be checked at Review time makes sense to me. It can be a sentence as: "make sure CI does not report new error" or something like that. Cheers, simon