From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sNrAEy9FU2FiRwEAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 18:39:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yE1dDy9FU2HyQwAAbx9fmQ (envelope-from ) for ; Tue, 28 Sep 2021 16:39:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82D7013E72 for ; Tue, 28 Sep 2021 18:39:10 +0200 (CEST) Received: from localhost ([::1]:54088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVG8L-0001OB-Gn for larch@yhetil.org; Tue, 28 Sep 2021 12:39:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVG8F-0001L4-0e for guix-patches@gnu.org; Tue, 28 Sep 2021 12:39:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVG8E-0000JY-48 for guix-patches@gnu.org; Tue, 28 Sep 2021 12:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVG8D-0005xs-W8 for guix-patches@gnu.org; Tue, 28 Sep 2021 12:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50620] [PATCH 1/2] guix: packages: Document 'computed-origin-method'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Sep 2021 16:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Mark H Weaver , 50620@debbugs.gnu.org Received: via spool by 50620-submit@debbugs.gnu.org id=B50620.163284708422847 (code B ref 50620); Tue, 28 Sep 2021 16:39:01 +0000 Received: (at 50620) by debbugs.gnu.org; 28 Sep 2021 16:38:04 +0000 Received: from localhost ([127.0.0.1]:46820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVG7I-0005wR-BF for submit@debbugs.gnu.org; Tue, 28 Sep 2021 12:38:04 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]:33508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVG7G-0005vr-Bn for 50620@debbugs.gnu.org; Tue, 28 Sep 2021 12:38:02 -0400 Received: by mail-qv1-f42.google.com with SMTP id a9so13862795qvf.0 for <50620@debbugs.gnu.org>; Tue, 28 Sep 2021 09:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dJzAII08l/uq4zsLNkmscjS2jHukip1wj93M17g+oBU=; b=UjLrxLr9mxjPdKBtlWtKK76eO+aUkiacvB8IN+k7dply0zBCgXm9blTVoPWprqHz0D U1zUe6gnUTFR8kWHSDSo92jdPMl/Rl1mCI84r0NkSXKrbbi6uL6koEiuWn2+F9UFIMK8 9JLIs3FuzwZywyDmvqTFefjRbstsulWBG2XGLiqsDutHPg869SeU+zPcL9Mdq6wJ3Nl5 PEMEQXMeF9zEVF+V5A51guQxUtZp0LQZnTF0+1TJoEEXpEPswWfxRaBsKRchTep79TL6 65+cQvp1Ayq8DWm4yCJ1L+dNDnP0tzGZcnKjp1D+xqQQ820aCsjujMrze2m9DSuEqXsc fZ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dJzAII08l/uq4zsLNkmscjS2jHukip1wj93M17g+oBU=; b=J6nyATPtu8kuKx5Ri9+34L3DeemXtIV9BXnpbVm0KikDVcIBJHBhxgeB7gX14UuQn7 1a/Grg7bYAnuvq2Cp6GX/Qf2/aYyJ0J++RzeMMF/JnRsCxb92GirIYI426q1VFMRWIz6 h4ehbi6xDZ/5LOmfLbqgxAyk6v4j2SMgThULU3XVAtSagdTz7xcM3VqcWAbnnBhl4Vw8 rQgJa+PZ6pDTW9UQ4zJSj9Negd7gFiBLhnZdtAfCPgPf8OauUwVTzzkwXgx5j/poxIEe Am8kitfIoTGFOYQ9rFqU5XpeMTuDkCCeeyXlQBNG/v/FkvJAWvpRT7WchAWg+IL1BjIT nFNg== X-Gm-Message-State: AOAM531weGMYpbEDSvM0efriYo49lkHlCDtRR5EISFop84X6MmDReBl2 of5IKkL6M/+GPiLJSePjqMN/fKe9gPF/WSliHDoP47EGnIM= X-Google-Smtp-Source: ABdhPJww3RLaCCrHLIxqUZZpvJCTmhldLs0XBQaWR/Q2vC0z3/9hiis10cmZtvO2ZaNwRZWWK//cIzJ8UYdAibIxhEc= X-Received: by 2002:a05:6214:2e7:: with SMTP id h7mr6408377qvu.39.1632847076817; Tue, 28 Sep 2021 09:37:56 -0700 (PDT) MIME-Version: 1.0 References: <20210916114734.2686426-1-zimon.toutoune@gmail.com> <9b6ee27ff10e1042a5d61d0f93d957cf760e9ecb.camel@gmail.com> <87v930ay5y.fsf@netris.org> <87pmstghx0.fsf@netris.org> In-Reply-To: From: zimoun Date: Tue, 28 Sep 2021 18:37:45 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632847150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dJzAII08l/uq4zsLNkmscjS2jHukip1wj93M17g+oBU=; b=rpPTQkrtsjbGVDegaz4UGUdrdubgzuwK1TuanZF9uLm9jbyfQuBSa/XiwVksDwS4jVZRVr IWf4Y3/QiNNFEvcyCHrDLSq2ts6wHjovLItGAH5hlDwb/UPfjYA0vUIgIfhhOSXvBZ71vh 3aviWTExf01QmfK8A/9SND1nPZzdZLsXKt1sM0L66pPWDExzE6agc2bxDcnudpNMUxqtVw YY4ihcczGiytAyKdUOFQSwUy2dGpt8wRnatQnANG0e/NEnRC5JyUG4Z1vOA0qt7zjtwyXQ Stuo1miApPasuMD+I9UK4AtDH8Y5AUgeknK0Do4kGn0yDrKM4SWHnpRxciLcqQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632847150; a=rsa-sha256; cv=none; b=ACc6sGCOiMyDdZWofhzSDaqoYGkoTLQAkVKHqng7McmU6I9dPtyCOZ7TCj4TBoQ45R9F1J YXHP5A2WgbxAZC8BwNpIfqM97k7662voBzXzqMa//kMpaYqYgujPIA3MXLaj9xICML9k3/ aku6c57lcaOpABfzIVs9UooxE8ZhJaESDibSmVC+1A3ad3ZS7YzVvXoX/uUVKNwXfHr/Ft wdJ65912jpmuq4oTkTtjiWp//6ZRQcKOgetYe4OE7Un2n0dvx+uwDs4++DOJWj9KMyM7Ro RtAYh5VHVBnvIKEXEDq+entZRYZ4Mqzd6L1JTkx2y9uk4ehd+skIUZQUCelVuA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=UjLrxLr9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=UjLrxLr9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 82D7013E72 X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: fWt5aMAU22RD Hi, On Tue, 28 Sept 2021 at 18:01, Liliana Marie Prikler wrote: > > zimoun writes: > > > I chose to put this in (guix packages) instead of its own module > > > because the module would contain only one function and nothing > > > exported. The aim for now, as discussed, is to not make this > > > 'method' part of the public API. > If so, one could argue that (gnu packages) is a better location to hide Ok. I do not find it better than (guix packages) where 'origin' is defined but anyway. I will send a v2 considering this and the rename you proposed. > it, but my main issue is that we still need to hide it! This will > cause other channels to refer to it using @@ or roll their own > implementations. This patch is not about discussing if this method should be public or not. It is private. Please discuss that elsewhere. Mark commented in [0]: --8<---------------cut here---------------start------------->8--- The reason 'computed-origin-method' is not exported is because it never went through the review process that such a radical new capability in Guix should go through before becoming part of it's public API. --8<---------------cut here---------------end--------------->8--- and this patch is about improving the situation (by removing the code duplication). That's all. The aim of this improvement is related to saving these IceCat and Linux Libre packages by Software Heritage [1]. 0: 1: > I've attached a patch to illustrate my point, but please don't apply it > as is. I have not put in the necessary git blame research to find out > who would need to be copyrighted here. As I said, the point of my patch is not to discuss if this 'compute-origin' should be part or not to the public API. It is simply a cleanup to ease the patch#50515 [1]. Therefore, I do not see what is the point to create its own module. All the best, simon