From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OMz7GJR91WCofAEAgWs5BA (envelope-from ) for ; Fri, 25 Jun 2021 08:54:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2JK3FJR91WAnNgAA1q6Kng (envelope-from ) for ; Fri, 25 Jun 2021 06:54:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 22164179AF for ; Fri, 25 Jun 2021 08:54:11 +0200 (CEST) Received: from localhost ([::1]:44872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwfj8-0005Oa-3H for larch@yhetil.org; Fri, 25 Jun 2021 02:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwfj1-0005NS-0x for guix-patches@gnu.org; Fri, 25 Jun 2021 02:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwfj0-0001fl-KR for guix-patches@gnu.org; Fri, 25 Jun 2021 02:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lwfj0-0004R7-Kx for guix-patches@gnu.org; Fri, 25 Jun 2021 02:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49196] [PATCH] import: utils: 'recursive-import' skips unfound packages Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Jun 2021 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49196 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49196@debbugs.gnu.org Received: via spool by 49196-submit@debbugs.gnu.org id=B49196.162460403617026 (code B ref 49196); Fri, 25 Jun 2021 06:54:02 +0000 Received: (at 49196) by debbugs.gnu.org; 25 Jun 2021 06:53:56 +0000 Received: from localhost ([127.0.0.1]:44691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwfiu-0004QY-9A for submit@debbugs.gnu.org; Fri, 25 Jun 2021 02:53:56 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:38593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwfis-0004QI-Ls for 49196@debbugs.gnu.org; Fri, 25 Jun 2021 02:53:55 -0400 Received: by mail-qk1-f173.google.com with SMTP id 65so683733qko.5 for <49196@debbugs.gnu.org>; Thu, 24 Jun 2021 23:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mk5hMWLDVhpLNTou9jwUaiMQ6V7P04aUsFC3lhRnROI=; b=sJsZ6t+mP5Q94lWwX6UbUmsdBOcM57QbITIpNhZbddbwwGFVlfbm/LdmEABqN8K1RN A7Xt2DHh1PCATzFocsni/7h4OZ+v2QReUHdKBGdH6oUct2er3+nTAjUaLX9QAual7h9B ZVmn0NwNgGyvecLUolOCJF6pUM31KhPN3qxkPfn8BC7lCSsNsbrlYN7BSjJ4LPIyDjPj Xl25JrW+SLcOtRmAhMq8vc/PqHyC4M8npN/7FKRBwEzBtHs0NdBHkKia+ikfKWfC0ud2 yCEOqsi3qBJo0nC/1ij+HF88YAjpIyQYJDu+AH9doPAnYfMYZ8hpH5L6wVMyNxgoJvXJ LrcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mk5hMWLDVhpLNTou9jwUaiMQ6V7P04aUsFC3lhRnROI=; b=KN509slY0GmlD3qr0gTFIWFcW+EmMNpYHFCktTRt0wTtnglaBwIQGWu36pdAieArvW FojqvvLebeVzokgepeREl1lkAW0WocTleNnhsiygcPajvrAInfza2gQIOnZGqJob0H4W Uca8s8/PUm/B0uI36a4efBMhh06jhqpeQ+whjXx6OkXVFhcmP1unmMGhDtKVN6zHwgZ1 IyApW65vFas/AHkMn9dn1830pm8lFBLAw2BUTk8BXO0Kh8qtgRWfaK2e+w8Q3Vsr6rH5 VPKsjMvYlvBdw5CTnTJskTClJwxv/yNXtMOg9RsqomZUGTdsPVlsD8phTV3upnSjIB70 T/pQ== X-Gm-Message-State: AOAM531zg5yC8GARwL3Kwl9CPjwyAovQVWQVH0b1ND08/F7pyKLkESP6 HS4IeGHlbWuyC/yZ35CMUN+tWGvBqiFr0ZetZy0eHJuM X-Google-Smtp-Source: ABdhPJypy5leE/p3trlsK+bzNyrDM6i4UYTqwFu3O8Fr+wyMK2R0lFXJbnuHYJU50E3hOsZEzSB0pClZ5WB9hJ6aLGE= X-Received: by 2002:a05:620a:543:: with SMTP id o3mr10094989qko.80.1624604028927; Thu, 24 Jun 2021 23:53:48 -0700 (PDT) MIME-Version: 1.0 References: <07d7149fc0f89f7f2d11fba47e1b0b2db5ceb809.1624479231.git.iskarian@mgsn.dev> <854kdna1wu.fsf@gmail.com> <86lf6y7eur.fsf_-_@mgsn.dev> In-Reply-To: <86lf6y7eur.fsf_-_@mgsn.dev> From: zimoun Date: Fri, 25 Jun 2021 08:53:37 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 22164179AF X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0rPIaKJcuKLh Hi, On Fri, 25 Jun 2021 at 06:22, Sarah Morgensen wrote: > The goal of this patch is just to allow recursive import to provide a > usable result despite some failures, when the importer supports it. I'd > rather hunt down one package than 20+ :) This may make reporting errors > more difficult, but I think the use-case is worth it. I agree. > Good catch. I did not think to handle the toplevel package not being > found! This actually leads to making this a much simpler patch... > > --8<---------------cut here---------------start------------->8--- > - (map node-package > + (filter-map node-package > (topological-sort (list (lookup-node package-name version)) > --8<---------------cut here---------------end--------------->8--- Cool! > Yes, this is very much just a stopgap. In your words (from #45984): > > > Well, this patch set are trivial changes that quickly fix the current > > broken situation without a deep revamp. I agree. Heh! I am consistent with my words. ;-) > I will follow up with an updated patch. Cool, thanks! Cheers, simon