From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iERrE6gFE2XQIQAAauVa8A:P1 (envelope-from ) for ; Tue, 26 Sep 2023 18:24:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iERrE6gFE2XQIQAAauVa8A (envelope-from ) for ; Tue, 26 Sep 2023 18:24:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 09E9A67515 for ; Tue, 26 Sep 2023 18:24:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=NpEZlV0t; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695745448; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/qQ9dtEriDduT2x6CjoX0ssZapISE/DvhJlU62QesKo=; b=XD6Tk23rwKEGwFI3jkPh4NyeDI881iOnlhNaIdHddo98Nb6We4eXXVqdPklZAWSHKAWNxa j/85lCl2ew+89SUzhSq2+IOOwZuEFWsX28jF+xYpR9JrDveXolNmLv9X2LzAU3h4otnjWo TQ2PPC2kbLI7fIyk4O5eeR0QWkYXxcWrocsJDoKTI4z3mE3Bj0mS+cSa68l13pqPe1KCy0 iEBR112O1PJo3eNKh6qpRc+Axjtt4LOiC5r++LaB7Q6gztlOgURsUnJ1bB7kZzAif5Qd6c AwszwBjCOiOCdqW6zNYNFX3rZmP1+bmmhBTkoZeoY6unGAyoKsbW6vRdYsjr1g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695745448; a=rsa-sha256; cv=none; b=tsU0lcFhQ/AOnacHJcGJudj24S70kjchiLppsRljtsKBMaYpmieLCc57euhA7H9m5vGcf0 R+pwzGQfNbRcwppG+ByllDNqCkmZ1DwxGMp4prCvy4dJSarHu4/+mtyufz3+Yi8aQyO7ds FhsXKUIXErVM3aKqLMMJQIU+obaND61zYVLpM45SmZLqgIH39OyugrosbiNuV8GwWTRQB+ Pbi4g7iKnQuZ6ngtPQDoeTyIW90XSpb9vkCCrwb1ca6SRT6cLQPITBoh9DFZR0mFcA8xBB pPlKcB9LVd+xfteBPwgrg30eA3iaXid1dazlcMnzfGud+R09RxQxMoQOuPLETA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=NpEZlV0t; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlAqn-0007VG-3M; Tue, 26 Sep 2023 12:23:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlAql-0007Uo-1b for bug-guix@gnu.org; Tue, 26 Sep 2023 12:23:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlAqk-0005uF-Pq for bug-guix@gnu.org; Tue, 26 Sep 2023 12:23:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qlAqw-0001JQ-3v for bug-guix@gnu.org; Tue, 26 Sep 2023 12:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65979: incorrect =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?hash=E2=80=9D?= for FastQC Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 Sep 2023 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65979 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 65979@debbugs.gnu.org Received: via spool by 65979-submit@debbugs.gnu.org id=B65979.16957454125003 (code B ref 65979); Tue, 26 Sep 2023 16:24:02 +0000 Received: (at 65979) by debbugs.gnu.org; 26 Sep 2023 16:23:32 +0000 Received: from localhost ([127.0.0.1]:49622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlAqR-0001Id-P9 for submit@debbugs.gnu.org; Tue, 26 Sep 2023 12:23:32 -0400 Received: from mail-qv1-xf34.google.com ([2607:f8b0:4864:20::f34]:41048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlAqQ-0001IR-4m for 65979@debbugs.gnu.org; Tue, 26 Sep 2023 12:23:31 -0400 Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-637aaaf27f1so13798736d6.0 for <65979@debbugs.gnu.org>; Tue, 26 Sep 2023 09:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695745391; x=1696350191; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/qQ9dtEriDduT2x6CjoX0ssZapISE/DvhJlU62QesKo=; b=NpEZlV0tHqbqz1+t34o9eEsTmAnVbINaBKZXGKGBc/LTPXd6wKgBH6YvUSABqL/rSp VeFPDIMmskE8XpKCvKo2lGbUNqGGvOV95AKcelUo4xNMUmUrgBdzlS4HlMLQMZsRc7Hn 0WcpSiclfpHPC9kz+gQbWxOozSbLhOlCw99W1QbyqG/zqFKuPfyj+J1+o00T3M3qEvIC zzjd/06MnQY8O+iiUqjuyDm6VJ2heooJIX+kbin4e8Y4bxyhiSK5tymnF9TlMKQ8IRm8 TDi1s7+DXA0IZp0/oiiL+S3SKCqDS+NfQ1mgsrm+6TcrrSGYI4IdgCU62PBTPe7qmllM id2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695745391; x=1696350191; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/qQ9dtEriDduT2x6CjoX0ssZapISE/DvhJlU62QesKo=; b=xAbVii6bXnUdzpLDDXnG4e5ungl0pQZhCS9UVRmzSAP8pC+HmEFkdU4QAjmyi+JFsR wwuZ2/kIN250fpJwJZSwIITeLdr+gHm5URocXhQUdav1oCRvs4zOGOFXSa/UW55I5CKQ B2TuIdjs/T+t78zHdfcW1w7HehYAKGanVZngYoLyO0M1Pv1enUZLq+KMbKcg4sPe3CLB /FD6sYPydI9CgyWJuIrXanKQPChCVSf07kZ3Lka0vGXBPqLMvt8n1tdzaxXMIpAeYA6f 9bRBiwZCmtbuepojxF/pzDCecr4Fx1g+JjlO105OPXTPgFsSctV+6WXCgM88LstbDqBh f3+w== X-Gm-Message-State: AOJu0YzlEHNo7DKYuTO8KCM0VQtpKT15qkugibCenLL/PNhgJq0vXjcG 2BE/+IqLQdyT2MJn0A+9/r/RGPhn9QiFjYoy/kU= X-Google-Smtp-Source: AGHT+IHm8iBIYTVnZF4c01rTL+AGxSyfGkQd3y28kXfocyumtokKlBy8AC0DCzZe6fTpxLQLt80S/uaglXA38Y8kKHQ= X-Received: by 2002:a05:6214:9c3:b0:65a:fc68:be20 with SMTP id dp3-20020a05621409c300b0065afc68be20mr8663250qvb.3.1695745391449; Tue, 26 Sep 2023 09:23:11 -0700 (PDT) MIME-Version: 1.0 References: <87v8ccd7oy.fsf@gmail.com> <87fs313x92.fsf@gmail.com> <87pm252h3c.fsf@gnu.org> In-Reply-To: <87pm252h3c.fsf@gnu.org> From: Simon Tournier Date: Tue, 26 Sep 2023 18:23:00 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -5.14 X-Spam-Score: -5.14 X-Migadu-Queue-Id: 09E9A67515 X-TUID: DdNlWN4M0d4T Hi, On Tue, 26 Sept 2023 at 15:34, Ludovic Court=C3=A8s wrote: > There are two things are: > > 1. =E2=80=98vcs-file?=E2=80=99, used by =E2=80=98guix hash -rx=E2=80=99= ; > > 2. =E2=80=98git-fetch=E2=80=99, which does (delete-file-recursively ".g= it"). Yes. > Clearly #2 is correct (it=E2=80=99s perfectly fine to have a =E2=80=98.sv= n=E2=80=99 directory in > a Git repo), whereas #1 is an approximation that, in corner cases like > this one, gives the wrong answer. These corner cases matter for some SWH loader implementing Nar hashes in Python. Since they load sources.json (conversion of hash checksum from package recipe), read the Nar hash and compare it with the one they internal compute, then they need to implement in Python the correct behavior. See https://gitlab.softwareheritage.org/swh/devel/swh-loader-git/-/issues/4= 751#note_149180 and all the thread for context. > My take is that it=E2=80=99s OK to keep =E2=80=98vcs-file?=E2=80=99 as is= : the best we could do > would be to add complicated heuristics in the hope corner cases like > this one would be better dealt with, but it wouldn=E2=80=99t be bullet-pr= oof > anyway. Well, the question is what other VCS as 'svn-fetch', etc. are doing? Maybe, we can just have a special case for Git repository. Somehow, since the problem needs to be solved for SWH, the same solution applies for vcs-file? and "guix hash", no? Cheers, simon