From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SlVJN1grZGGLUAEAgWs5BA (envelope-from ) for ; Mon, 11 Oct 2021 14:17:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YPmTMFgrZGGgGAAAbx9fmQ (envelope-from ) for ; Mon, 11 Oct 2021 12:17:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6156BD29D for ; Mon, 11 Oct 2021 14:17:28 +0200 (CEST) Received: from localhost ([::1]:50442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZuFD-00066t-D9 for larch@yhetil.org; Mon, 11 Oct 2021 08:17:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZuBx-0003GA-VD for bug-guix@gnu.org; Mon, 11 Oct 2021 08:14:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZuBv-00018A-Ll for bug-guix@gnu.org; Mon, 11 Oct 2021 08:14:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZuBu-0001nS-H5 for bug-guix@gnu.org; Mon, 11 Oct 2021 08:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50299: [PATCH v3 15/27] gnu: ecl: Don't pretend to enable tests when cross-compiling. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 11 Oct 2021 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50299 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Received: via spool by 50299-submit@debbugs.gnu.org id=B50299.16339544176849 (code B ref 50299); Mon, 11 Oct 2021 12:14:02 +0000 Received: (at 50299) by debbugs.gnu.org; 11 Oct 2021 12:13:37 +0000 Received: from localhost ([127.0.0.1]:56896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuBU-0001mO-W8 for submit@debbugs.gnu.org; Mon, 11 Oct 2021 08:13:37 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:46824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuBT-0001ly-J5 for 50299@debbugs.gnu.org; Mon, 11 Oct 2021 08:13:36 -0400 Received: by mail-qk1-f177.google.com with SMTP id bk7so7167317qkb.13 for <50299@debbugs.gnu.org>; Mon, 11 Oct 2021 05:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oNgpJnDdG7FE8+1U0Exnlc9sBpH8u7CgVdi2oYpP3WM=; b=AUW3igIwFPa/MAQeNSzQLoVVDqNCwC9fE5qrb3NUNG7/bMYWvBKfeQhzeF+FKZAb7F sHuw0JNomlIayrobTlgKqDoeFvNyu6yqKP0YmJ20uoyqKf1v524IMUpreWByim7RqeAW 0cWjDgdGQHs38U0FcpiFBaBbMe951EndCywue9ok1fbhiyboGHiEKhk8g4gE/REp5WIr CK6ZAb9miIjj2/QvKPQHBeBLa2Tt7arpU9vkx3Z43cbGPzgzWegDWVxnnhQ2jmbfNMiv 5tP7GCXQl2QcDzydqdf36agBgIfrEgkPLLVCKOfVC8X+hrPNdQkEw5njYyy/PFzLTSL6 IWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oNgpJnDdG7FE8+1U0Exnlc9sBpH8u7CgVdi2oYpP3WM=; b=A/RT2GqPHvUckwZElMlZ0IqcIXF8GGOwv9sndwWSJ5q0mw8twsfJw41ci00aKTDA1t Mgj7+Y965k8YMYG1ozLSWvWSWmsC7JCuDCinjziGfRbHCs6MgSCnPd+IW7RFu3P3kWY2 Be7cNiRCvHBZSqa24jc9epinvvBfo/EcxeJlGGlDXypnRxPxC5/qK8MPyzki23yG6DpH IjNVCM6dlyILcoXFDB9KBhkKKfZU6ShTfgksAsI6rX3JtUtv7QU2fwqIwQdJ4NBKSf5G iZK0IveCjxvGSOVUFLMls4lEqx/fPNXb8LdTmqbpPRlsIPw0yRLI1+0BsyIxPxWFfyNH +/uA== X-Gm-Message-State: AOAM531Dr634kNHR+JRzv8aPePWUh4KHx8G416NxCVts3KuA8FpWERxJ 4ngEtQHksJKGlFvRzQqxZlo1ho7yqBaOz7EiHe4= X-Google-Smtp-Source: ABdhPJyvjHLRRZ6jqxQjRPYse6RI1WdWSfGNlAab6aq6toJy3X89Tya5LQ8EAHrcZbxFpUDsfQU6OqIPm6B4J4fV27w= X-Received: by 2002:a37:40d1:: with SMTP id n200mr14147806qka.488.1633954410154; Mon, 11 Oct 2021 05:13:30 -0700 (PDT) MIME-Version: 1.0 References: <20210929224759.21803-1-maximedevos@telenet.be> <20210929224759.21803-15-maximedevos@telenet.be> In-Reply-To: <20210929224759.21803-15-maximedevos@telenet.be> From: zimoun Date: Mon, 11 Oct 2021 14:13:19 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50299@debbugs.gnu.org, Maxim Cournoyer Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633954648; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=oNgpJnDdG7FE8+1U0Exnlc9sBpH8u7CgVdi2oYpP3WM=; b=o3SvZzum+vJtEcQP99PQGa9A7z5f3rnwUGm57DhL699vv5v+BM72PDEmVmB73Mq2HriVTi trkCr/AnSYOzHvSnrJO/6XAUoApkp+xu7lHhb+ESsjR4HhUg2ycAus0l9x/VL5FrfyVqAs efBTRKYPoLBP5fecFkKnlBKAvlR9/Pw8pDE18yJVOp1xYcBggH+wVMTDPUA7whYUVrGIiB mvtwHT7JpvrRnJc5wBcHk6331R8W6nk69MrSR4j65rnQxkJtcfaIbRDgTBqR/isssa005c Qr2vm9R2lCyIlpGCNR/T7nZg9S+pntxNQAgE271SP1ge9lgBxOL2pQ0suNo6eg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633954648; a=rsa-sha256; cv=none; b=JfIig9qALYG8gYuV6Vuh8FPVsrIl/mx+tzKN9KFLsn2mKcjgjeuDtFK74JIdaVV14igkAx 57mwdx4erUDbt5fQR80dnkO0RRe8SthCIHeDBX4roxtsMCrdkmd3lt5Lc8DqSlOkFpmSPr 8KVOP56CxK7MA0hvLovv6KNWja1h0ybNmYrlnnMTq/+/4qI+KfjgKHDAUjjhtbo5jRDKTX bkm/gz5RaPjh5DlTNQTXXqk0iWRKkDZC3apOT85xpu5H6NaVkch7aq+RgWGV2ToKLC6BCp QIN1zZapUipBX9ZH9tRh7sjjwHAR/+CpYQI2PpXLwQrSPWeEy9SfVXg/QvxtKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=AUW3igIw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.71 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=AUW3igIw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 6156BD29D X-Spam-Score: -1.71 X-Migadu-Scanner: scn1.migadu.com X-TUID: nu3FB4KhAp8w Hi Maxime, I was roaming on this series and the message: Don't pretend to enable tests when cross-compiling. or elsewhere Don't run tests when cross-compiling. appears to me misleading. I would write: Remove unconditional tests. or something along these lines which is what these commits are doing, IIUC. On Thu, 30 Sept 2021 at 00:50, Maxime Devos wrote: > * gnu/packages/lisp.scm > (ecl)[arguments]<#:tests?>: Move comment about failing tests to ... > (ecl)[arguments]<#:phases>{check}: ... this deleted phase. > (ecl)[arguments]: Remove #:tests? instead of unconditionally setting it to > #t. Thanks for working on that. Cheers, simon