From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH 2/7] gnu: Add djvulibre.
Date: Mon, 2 Mar 2015 13:27:34 +0800
Message-ID: <CAHZE2pdBdP6V2Mq8Fj+vXY6Vj3vL=59D6ZTQigvEk6gxbvEt9Q@mail.gmail.com>
References: <1425253673-32604-1-git-send-email-paul@denknerd.org>
	<1425253673-32604-2-git-send-email-paul@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37784)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1YSItE-0003GK-4t
	for guix-devel@gnu.org; Mon, 02 Mar 2015 00:27:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1YSItC-0005zh-Ug
	for guix-devel@gnu.org; Mon, 02 Mar 2015 00:27:36 -0500
Received: from mail-qc0-x230.google.com ([2607:f8b0:400d:c01::230]:43955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1YSItC-0005zE-Qr
	for guix-devel@gnu.org; Mon, 02 Mar 2015 00:27:34 -0500
Received: by qcxr5 with SMTP id r5so22904466qcx.10
	for <guix-devel@gnu.org>; Sun, 01 Mar 2015 21:27:34 -0800 (PST)
In-Reply-To: <1425253673-32604-2-git-send-email-paul@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: Guix-devel <guix-devel@gnu.org>

2015-03-02 7:47 GMT+08:00 Paul van der Walt <paul@denknerd.org>:
> * gnu/packages/pdf.scm (djvulibre): New variable.
> ---
>  gnu/packages/pdf.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index 7b4f2ab..76c77d9 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright =C2=A9 2013, 2015 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright =C2=A9 2014 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright =C2=A9 2014, 2015 Ricardo Wurmus <rekado@elephly.net>
> +;;; Copyright =C2=A9 2015 Paul van der Walt <paul@denknerd.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -143,6 +144,27 @@
>     (license license:gpl3) ; or gpl2, but not gpl2+
>     (home-page "http://www.foolabs.com/xpdf/")))
>
> +
> +
> +(define-public djvulibre
> +  (package
> +    (name "djvulibre")
> +    (version "3.5.27")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/djvulibre/djvuli=
bre-"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0psh3zl9dj4n4r3lx25390nx34xz0bg0ql48zdskhq354ljni5p6"))=
))
> +    (build-system gnu-build-system)
> +    (home-page "http://djvu.sourceforge.net/")
> +    (synopsis "DjVuLibre is a GPL implementation of DjVu, a document for=
mat.")
Synposis is too long, and shouldn't contain package name, end with peroid, =
etc.
Perhaps just "Implementation of DjVu"?
> +    (description "DjVuLibre is an open source (GPL'ed) implementation of=
 DjVu,
> +including viewers, browser plugins, decoders, simple encoders, and
> +utilities.")
We don't use words like "open source", and no need to mention GPL here.
> +    (license license:gpl2)))
Should be 'license:gpl2'+.
> +
>  (define-public podofo
>    (package
>      (name "podofo")
> --
> 2.3.1
>
>
Otherwise, look good to me.