[PATCH] gnu/package/pv.scm (pv): New file, new variable

[PATCH] gnu/package/pv.scm (pv): New file, new variable

[Claes Wallin (韋嘉誠)]

From 7df5b2d6c71d7de70e4af59f1944c87c0b0ce807 Mon Sep 17 00:00:00 2001
From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
Date: Fri, 19 Jun 2015 20:12:09 +0200
Subject: [PATCH] gnu/package/pv.scm (pv): New file, new variable

Signed-off-by: Claes Wallin <claes.wallin@greatsinodevelopment.com>
---
 gnu/packages/pv.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 gnu/packages/pv.scm

diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm
new file mode 100644
index 0000000..bd159c9
--- /dev/null
+++ b/gnu/packages/pv.scm
@@ -0,0 +1,51 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2012, 2013, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages pv)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:export (pv))
+
+(define pv
+  (package
+    (name "pv")
+    (version "1.6.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://www.ivarch.com/programs/sources/pv-"
+                          version ".tar.bz2"))
+      (sha256
+       (base32
+        "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf"))))
+    (build-system gnu-build-system)
+    ;(native-inputs `(("perl" ,perl)))
+    ;(inputs `(("flex" ,flex)))
+    ;(propagated-inputs `(("m4" ,m4)))
+    (home-page "http://www.ivarch.com/programs/pv.shtml")
+    (synopsis "Pipeline progress indicator")
+    (description
+     "pv - Pipe Viewer - is a terminal-based tool for monitoring the progress
+of data through a pipeline. It can be inserted into any normal pipeline
+between two processes to give a visual indication of how quickly data is
+passing through, how long it has taken, how near to completion it is, and an
+estimate of how long it will be until completion.")
+    (license artistic2.0)))
--
2.2.1

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Claes Wallin (韋嘉誠)]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Argh. Why is there always some small detail you don't notice until you
posted, even in a small file like this?

Removed commented-out lines.

[-- Attachment #2: 0001-gnu-package-pv.scm-pv-New-file-new-variable.patch --]
[-- Type: application/octet-stream, Size: 2600 bytes --]

From 9213e7207f5e72bf66460d2cdf4e27a86609e322 Mon Sep 17 00:00:00 2001
From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
Date: Fri, 19 Jun 2015 20:12:09 +0200
Subject: [PATCH] gnu/package/pv.scm (pv): New file, new variable

Signed-off-by: Claes Wallin <claes.wallin@greatsinodevelopment.com>
---
 gnu/packages/pv.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 gnu/packages/pv.scm

diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm
new file mode 100644
index 0000000..f0eac85
--- /dev/null
+++ b/gnu/packages/pv.scm
@@ -0,0 +1,48 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2012, 2013, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages pv)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:export (pv))
+
+(define pv
+  (package
+    (name "pv")
+    (version "1.6.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://www.ivarch.com/programs/sources/pv-"
+                          version ".tar.bz2"))
+      (sha256
+       (base32
+        "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.ivarch.com/programs/pv.shtml")
+    (synopsis "Pipeline progress indicator")
+    (description
+     "pv - Pipe Viewer - is a terminal-based tool for monitoring the progress
+of data through a pipeline. It can be inserted into any normal pipeline
+between two processes to give a visual indication of how quickly data is
+passing through, how long it has taken, how near to completion it is, and an
+estimate of how long it will be until completion.")
+    (license artistic2.0)))
-- 
2.2.1

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Claes Wallin (韋嘉誠)]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

On Fri, Jun 19, 2015 at 8:51 PM, Claes Wallin (韋嘉誠)
<gnu@clacke.user.lysator.liu.se> wrote:
> Argh. Why is there always some small detail you don't notice until you
> posted, even in a small file like this?
>
> Removed commented-out lines.

Bump?

[-- Attachment #2: 0001-gnu-package-pv.scm-pv-New-file-new-variable.patch --]
[-- Type: application/octet-stream, Size: 2600 bytes --]

From 9213e7207f5e72bf66460d2cdf4e27a86609e322 Mon Sep 17 00:00:00 2001
From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
Date: Fri, 19 Jun 2015 20:12:09 +0200
Subject: [PATCH] gnu/package/pv.scm (pv): New file, new variable

Signed-off-by: Claes Wallin <claes.wallin@greatsinodevelopment.com>
---
 gnu/packages/pv.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 gnu/packages/pv.scm

diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm
new file mode 100644
index 0000000..f0eac85
--- /dev/null
+++ b/gnu/packages/pv.scm
@@ -0,0 +1,48 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2012, 2013, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages pv)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:export (pv))
+
+(define pv
+  (package
+    (name "pv")
+    (version "1.6.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://www.ivarch.com/programs/sources/pv-"
+                          version ".tar.bz2"))
+      (sha256
+       (base32
+        "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.ivarch.com/programs/pv.shtml")
+    (synopsis "Pipeline progress indicator")
+    (description
+     "pv - Pipe Viewer - is a terminal-based tool for monitoring the progress
+of data through a pipeline. It can be inserted into any normal pipeline
+between two processes to give a visual indication of how quickly data is
+passing through, how long it has taken, how near to completion it is, and an
+estimate of how long it will be until completion.")
+    (license artistic2.0)))
-- 
2.2.1

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Alex Kost]

Claes Wallin (韋嘉誠) (2015-06-19 21:51 +0300) wrote:

> From 9213e7207f5e72bf66460d2cdf4e27a86609e322 Mon Sep 17 00:00:00 2001
> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> Date: Fri, 19 Jun 2015 20:12:09 +0200
> Subject: [PATCH] gnu/package/pv.scm (pv): New file, new variable
>
> Signed-off-by: Claes Wallin <claes.wallin@greatsinodevelopment.com>

I think there is no need in this ↑ line.  The commit message should be:

--8<---------------cut here---------------start------------->8---
gnu: Add pv.

* gnu/package/pv.scm (pv): New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
--8<---------------cut here---------------end--------------->8---

And you also need to add "gnu/package/pv.scm" to "gnu-system.am".  See
commit 741115b for example.

> ---
>  gnu/packages/pv.scm | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 gnu/packages/pv.scm
>
> diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm
> new file mode 100644
> index 0000000..f0eac85
> --- /dev/null
> +++ b/gnu/packages/pv.scm
> @@ -0,0 +1,48 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright  2012, 2013, 2015 Ludovic Courts <ludo@gnu.org>
> +;;; Copyright  2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>

IIUC you are the only author of this file, right?  Then there is no
place for Ludovic there.

> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages pv)
> +  #:use-module (guix licenses)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:export (pv))
> +
> +(define pv

I think we prefer 'define-public' over exporting the package variables,
but it is probably not a strong convention.

> +  (package
> +    (name "pv")
> +    (version "1.6.0")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "http://www.ivarch.com/programs/sources/pv-"
> +                          version ".tar.bz2"))
> +      (sha256
> +       (base32
> +        "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.ivarch.com/programs/pv.shtml")
> +    (synopsis "Pipeline progress indicator")
> +    (description
> +     "pv - Pipe Viewer - is a terminal-based tool for monitoring the progress

I would put "Pipe Viewer" in parentheses:

        "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress

but I think you may ignore this comment.

> +of data through a pipeline. It can be inserted into any normal pipeline
   of data through a pipeline.  It can be inserted into any normal pipeline

I realize that you took this description from the home page, but our
convention is to use two spaces between sentences.

> +between two processes to give a visual indication of how quickly data is
> +passing through, how long it has taken, how near to completion it is, and an
> +estimate of how long it will be until completion.")
> +    (license artistic2.0)))

-- 
Alex

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Claes Wallin (韋嘉誠)]

On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost <alezost@gmail.com> wrote:
> Claes Wallin (韋嘉誠) (2015-06-19 21:51 +0300) wrote:

> I think there is no need in this ↑ line.  The commit message should be:
>
> --8<---------------cut here---------------start------------->8---
> gnu: Add pv.
>
> * gnu/package/pv.scm (pv): New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> --8<---------------cut here---------------end--------------->8---

Ok!


> And you also need to add "gnu/package/pv.scm" to "gnu-system.am".  See
> commit 741115b for example.

I will take a look.


>> +;;; Copyright  2012, 2013, 2015 Ludovic Courts <ludo@gnu.org>
>> +;;; Copyright  2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>
>
> IIUC you are the only author of this file, right?  Then there is no
> place for Ludovic there.

Ok, I copied it from another file and modified it, but if the
convention is that the boilerplate is too thin to be credited, I'll
remove him.

>> +  #:export (pv))
>> +
>> +(define pv
>
> I think we prefer 'define-public' over exporting the package variables,
> but it is probably not a strong convention.

define-public is less redundant. I like it.


> I would put "Pipe Viewer" in parentheses:
>
>         "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress
>
> but I think you may ignore this comment.

No, it's a fair point.


>> +of data through a pipeline. It can be inserted into any normal pipeline
>    of data through a pipeline.  It can be inserted into any normal pipeline
>
> I realize that you took this description from the home page, but our
> convention is to use two spaces between sentences.

If there's a convention I'll follow it. I'll just note here once that
I disagree with it. Double space is a type-writer convention that
"nobody" follows any more. ;-)

Regarding scraping the text I tried quickly to see what license the
web site text is under, but didn't find anything conclusive. I figured
if Debian is copying it, I should be fine. Maybe I'll get back to
checking it later.


Thanks for the feedback. I have several more packages in the pipeline
once I get this one right!

--
   /c

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Claes Wallin (韋嘉誠)]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost <alezost@gmail.com> wrote:

> --8<---------------cut here---------------start------------->8---
> gnu: Add pv.
>
> * gnu/package/pv.scm (pv): New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> --8<---------------cut here---------------end--------------->8---
>
> And you also need to add "gnu/package/pv.scm" to "gnu-system.am".  See
> commit 741115b for example.

> IIUC you are the only author of this file, right?  Then there is no
> place for Ludovic there.

> I think we prefer 'define-public' over exporting the package variables,
> but it is probably not a strong convention.

> I would put "Pipe Viewer" in parentheses:
>
>         "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress

> I realize that you took this description from the home page, but our
> convention is to use two spaces between sentences.


Updated accordingly!

-- 
   /c

[-- Attachment #2: 0001-gnu-Add-pv.patch --]
[-- Type: application/octet-stream, Size: 2908 bytes --]

From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001
From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
Date: Fri, 19 Jun 2015 20:12:09 +0200
Subject: [PATCH] gnu: Add pv.

 * gnu/package/pv.scm (pv): New file.
 * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am       |  1 +
 gnu/packages/pv.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 gnu/packages/pv.scm

diff --git a/gnu-system.am b/gnu-system.am
index a420d71..2adffd5 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -253,6 +253,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/pumpio.scm			\
   gnu/packages/pretty-print.scm			\
   gnu/packages/protobuf.scm			\
+  gnu/packages/pv.scm				\
   gnu/packages/python.scm			\
   gnu/packages/qemu.scm				\
   gnu/packages/qt.scm				\
diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm
new file mode 100644
index 0000000..9328da3
--- /dev/null
+++ b/gnu/packages/pv.scm
@@ -0,0 +1,46 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages pv)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public pv
+  (package
+    (name "pv")
+    (version "1.6.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://www.ivarch.com/programs/sources/pv-"
+                          version ".tar.bz2"))
+      (sha256
+       (base32
+        "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.ivarch.com/programs/pv.shtml")
+    (synopsis "Pipeline progress indicator")
+    (description
+     "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress
+of data through a pipeline.  It can be inserted into any normal pipeline
+between two processes to give a visual indication of how quickly data is
+passing through, how long it has taken, how near to completion it is, and an
+estimate of how long it will be until completion.")
+    (license artistic2.0)))
-- 
2.4.3

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Alex Kost]

Claes Wallin (韋嘉誠) (2015-06-25 00:35 +0300) wrote:

> On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost <alezost@gmail.com> wrote:
>
>> --8<---------------cut here---------------start------------->8---
>> gnu: Add pv.
>>
>> * gnu/package/pv.scm (pv): New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> --8<---------------cut here---------------end--------------->8---
>>
>> And you also need to add "gnu/package/pv.scm" to "gnu-system.am".  See
>> commit 741115b for example.
>
>> IIUC you are the only author of this file, right?  Then there is no
>> place for Ludovic there.
>
>> I think we prefer 'define-public' over exporting the package variables,
>> but it is probably not a strong convention.
>
>> I would put "Pipe Viewer" in parentheses:
>>
>>         "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress
>
>> I realize that you took this description from the home page, but our
>> convention is to use two spaces between sentences.
>
>
> Updated accordingly!
>
>
> From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001
> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> Date: Fri, 19 Jun 2015 20:12:09 +0200
> Subject: [PATCH] gnu: Add pv.
>
>  * gnu/package/pv.scm (pv): New file.
>  * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Thank you!  It looks good to me, so I'll push it in a couple of days if
no one will send additional comments/notes.

-- 
Alex

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Claes Wallin (韋嘉誠)]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On 26-Jun-2015 3:33 pm, "Alex Kost" <alezost@gmail.com> wrote:
> Claes Wallin (韋嘉誠) (2015-06-25 00:35 +0300) wrote:

> > From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001
> > From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> > Date: Fri, 19 Jun 2015 20:12:09 +0200
> > Subject: [PATCH] gnu: Add pv.
> >
> >  * gnu/package/pv.scm (pv): New file.
> >  * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> Thank you!  It looks good to me, so I'll push it in a couple of days if
> no one will send additional comments/notes.

Sweet!

[-- Attachment #2: Type: text/html, Size: 882 bytes --]

Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

>> From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001
>> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
>> Date: Fri, 19 Jun 2015 20:12:09 +0200
>> Subject: [PATCH] gnu: Add pv.
>>
>>  * gnu/package/pv.scm (pv): New file.
>>  * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> Thank you!  It looks good to me, so I'll push it in a couple of days if
> no one will send additional comments/notes.

If it looks good to you, go ahead.

Thanks for reviewing it.

Ludo’.