Re: [PATCH] gnu/package/pv.scm (pv): New file, new variable

["Claes Wallin (韋嘉誠)" <gnu@clacke.user.lysator.liu.se>]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Tue, Jun 23, 2015 at 1:43 PM, Alex Kost <alezost@gmail.com> wrote:

> --8<---------------cut here---------------start------------->8---
> gnu: Add pv.
>
> * gnu/package/pv.scm (pv): New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> --8<---------------cut here---------------end--------------->8---
>
> And you also need to add "gnu/package/pv.scm" to "gnu-system.am".  See
> commit 741115b for example.

> IIUC you are the only author of this file, right?  Then there is no
> place for Ludovic there.

> I think we prefer 'define-public' over exporting the package variables,
> but it is probably not a strong convention.

> I would put "Pipe Viewer" in parentheses:
>
>         "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress

> I realize that you took this description from the home page, but our
> convention is to use two spaces between sentences.


Updated accordingly!

-- 
   /c

[-- Attachment #2: 0001-gnu-Add-pv.patch --]
[-- Type: application/octet-stream, Size: 2908 bytes --]

From e93d21889bdcbed02a517f30d8401a3bb144cce4 Mon Sep 17 00:00:00 2001
From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
Date: Fri, 19 Jun 2015 20:12:09 +0200
Subject: [PATCH] gnu: Add pv.

 * gnu/package/pv.scm (pv): New file.
 * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am       |  1 +
 gnu/packages/pv.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 gnu/packages/pv.scm

diff --git a/gnu-system.am b/gnu-system.am
index a420d71..2adffd5 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -253,6 +253,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/pumpio.scm			\
   gnu/packages/pretty-print.scm			\
   gnu/packages/protobuf.scm			\
+  gnu/packages/pv.scm				\
   gnu/packages/python.scm			\
   gnu/packages/qemu.scm				\
   gnu/packages/qt.scm				\
diff --git a/gnu/packages/pv.scm b/gnu/packages/pv.scm
new file mode 100644
index 0000000..9328da3
--- /dev/null
+++ b/gnu/packages/pv.scm
@@ -0,0 +1,46 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Claes Wallin <claes.wallin@greatsinodevelopment.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages pv)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public pv
+  (package
+    (name "pv")
+    (version "1.6.0")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "http://www.ivarch.com/programs/sources/pv-"
+                          version ".tar.bz2"))
+      (sha256
+       (base32
+        "13gg6r84pkvznpd1l11qw1jw9yna40gkgpni256khyx21m785khf"))))
+    (build-system gnu-build-system)
+    (home-page "http://www.ivarch.com/programs/pv.shtml")
+    (synopsis "Pipeline progress indicator")
+    (description
+     "pv (Pipe Viewer) is a terminal-based tool for monitoring the progress
+of data through a pipeline.  It can be inserted into any normal pipeline
+between two processes to give a visual indication of how quickly data is
+passing through, how long it has taken, how near to completion it is, and an
+estimate of how long it will be until completion.")
+    (license artistic2.0)))
-- 
2.4.3