From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 4HtnBZ0pR2bgggAAqHPOHw:P1 (envelope-from ) for ; Fri, 17 May 2024 11:55:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4HtnBZ0pR2bgggAAqHPOHw (envelope-from ) for ; Fri, 17 May 2024 11:55:41 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=foundation.xyz header.s=google header.b="rqtc/8u7"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=foundation.xyz (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715939741; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GwOwtvWDee9F+5s0BUbREO9tLD7H6vTe+5qrF1mEq1w=; b=eQp9EOv3hq4iBLEIovdglIEbUu53X47UPejZOhhtC7KIb/BBe7MwyqpVD4fui7oAf3sKGh fvPNSakDhSz29yJP6Vk8a5g2jUptKFJnxTiWRmsq+FAqXVccGo1xiCy6iHfxp3agyHLMfw EHvCgaqLz5WqkcpAt40ZC+e+5F4UZt2ZWNIbs/sHOgFyvXaqcMtduACSDSekg2sakx4QGQ GOZO+5y+6Rbgmg34fLnr3igxiCT6WfkUPTLThNLPdZLmRWYq/VZxlNeWtgm+9Uv8Xv7LDY jtYj3PQpLOiau7yoJU+YQiBNHgzR7vL0G/R8c38mE6pRze/Yw1YyBrWRVft4kg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=foundation.xyz header.s=google header.b="rqtc/8u7"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=foundation.xyz (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715939741; a=rsa-sha256; cv=none; b=ah0KIShn2gMkY3lF2GBVbN0k0s34SxdgUbRPj3uao3cdX/YWElKD7KiMVqNYJMkpVNH+39 s5O3vT4rf6bkpnQ2zmqGZ7hEh0Y08UiQvyuMfu3Bb+zOUDt4gWvE4M3aeCgLokRP9GW3J6 KWEm8NEi/8VvlLsPsbUSMaxQ1nHECodoVjv/lU+XHVhMZYcLcbF0FSu5jPk5OxOtYvgQ7X xKcYfRr4xQVT/Rcj9QCIA8cxnCKNO02axONdKLV1+AC0arzkiB7bEja8XGUXfUpQ3Kp8wu rCVXgMNET78KmPTNJb6IFrjoGoaCGE0DYb4AgewKYjVb3ttEx/+mJd87ihe15g== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A97195474C for ; Fri, 17 May 2024 11:55:40 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7uJ6-0007f6-II; Fri, 17 May 2024 05:55:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7uIm-0007SD-FM for guix-patches@gnu.org; Fri, 17 May 2024 05:55:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7uIl-0006bG-9y for guix-patches@gnu.org; Fri, 17 May 2024 05:54:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7uIn-0004I3-Oe for guix-patches@gnu.org; Fri, 17 May 2024 05:55:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70985] [PATCH 3/4] gnu: cross-libc*: Raise conditions rather than returning #f. References: <878r09ol8z.fsf@cbaines.net> In-Reply-To: <878r09ol8z.fsf@cbaines.net> Resent-From: Jean-Pierre De Jesus Diaz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 May 2024 09:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70985@debbugs.gnu.org Cc: ludo@gnu.org, mail@cbaines.net Received: via spool by 70985-submit@debbugs.gnu.org id=B70985.171593968116474 (code B ref 70985); Fri, 17 May 2024 09:55:01 +0000 Received: (at 70985) by debbugs.gnu.org; 17 May 2024 09:54:41 +0000 Received: from localhost ([127.0.0.1]:54263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7uIT-0004He-D0 for submit@debbugs.gnu.org; Fri, 17 May 2024 05:54:41 -0400 Received: from mail-ua1-f46.google.com ([209.85.222.46]:60505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7uIN-0004HY-Gd for 70985@debbugs.gnu.org; Fri, 17 May 2024 05:54:39 -0400 Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7fe97255d03so229176241.0 for <70985@debbugs.gnu.org>; Fri, 17 May 2024 02:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundation.xyz; s=google; t=1715939607; x=1716544407; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GwOwtvWDee9F+5s0BUbREO9tLD7H6vTe+5qrF1mEq1w=; b=rqtc/8u7t0f4c5preOxxSnwCR3AsAuaqKP3i83LyVj1WMXgqAi6ImdEYZuzxU5sf9B 4hQpsppJWxU0Djv21n5p7St+eS8AE3WchwisWIEArLoFdyvqeraX/hSELKGfQgEj/kBl gBn0ROarCxAgOpXjKRgOE5c5R9GbgCOtnkR6+X3ss7yXpn8x04BNmGimz0hnV4X6+wjf zzpritekH4Hbut6CACQm6CpR20QmTyY5h3eT+5Mmeru5SA+6LWIeyWDqTtIAkXK4F0R+ As+FnlxUQXkUGdrCLPVfMa4achMIDQMO81FZB5o7QPCpnOLbC9qCt45n7WBg+gwiz2zT jw5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715939607; x=1716544407; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GwOwtvWDee9F+5s0BUbREO9tLD7H6vTe+5qrF1mEq1w=; b=Cx/o2dPTo6kiCSAb//T2hWGC45fqX9K1uCCkFa+ddPzK3gHchNE0Mw+ADObr40gI2R OmLmIurjVXsxon72JlA7y5rs7SYdQl86wo3b9u6qLOtUUZw0wX8nVxEZ8JaQvkAeE+zX kEx2QMi2GZGWBCf4FVb3ycaoLbMKDNrSiHgA7ChCg9OXmtUsWjuY0l4eYKDFWNe4xYLm bxPxr2PHOGShLGv2BfC8HkxEPOJBTabRauN8iQ2vMBh8VGnPS55RfzQ8Azb3tGZilG+/ VNVYJ3kFNvO0YfXLDXD919qllpLekAe6jopFCR4LECwHLx/dj6I164paBRdyFewXruYK ng/w== X-Gm-Message-State: AOJu0YyX9yWuytxWNrTGlRsQKUZVbclqaVbPnNUDHW3TIHePehwL3nLm GHw7haVQBbAb7Zk328umHjb+H718ynrn8FXzyelDORGn9w3c5absYP5YZIfaowB6mV88eUqrgWg 2UnCPkzy7qFK3gn5pzLC++8fmBQiwRBI27Ob6O+bbVJ8CWamA6r8= X-Google-Smtp-Source: AGHT+IGJZcIkTs49WsenQ88XwPZFJeerCC3cbiKK70PfuSH9fBHNDY/EFGeCzVISiUkgRIfSczadRq/+1RjzsIJi/mE= X-Received: by 2002:a05:6102:390c:b0:47e:b219:8f11 with SMTP id ada2fe7eead31-48077eb49camr24404890137.29.1715939607045; Fri, 17 May 2024 02:53:27 -0700 (PDT) MIME-Version: 1.0 From: Jean-Pierre De Jesus Diaz Date: Fri, 17 May 2024 09:53:16 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.63 X-Spam-Score: 2.63 X-Migadu-Queue-Id: A97195474C X-Migadu-Scanner: mx13.migadu.com X-TUID: PsSFyU+8kwhc Hello, >> Christopher Baines writes: >> >>> As this means that the error will be clearer for targets which are >>> unsupported. >>> >>> * gnu/packages/cross-base.scm (cross-libc*): Raise conditions rather th= an >>> returning #f. >>> >>> Change-Id: I820780ad738d85a98950de5608f3019e961ff7c8 >> >> [...] >> >>> - (else #f))) >>> + (else >>> + (raise (condition >>> + (&package-unsupported-target-error >>> + (package libc) >>> + (target target))))))) >> >> What I'm unsure is whether this works with libc-less triplets such as >> =E2=80=98avr=E2=80=99 or =E2=80=98or1k-elf=E2=80=99. > >Hmm, it seems like this is erroring in some cases where it didn't >before, I'm not sure why though. > >I ended up here through rust-sysroot-for-... since it calls >cross-libc. Handling cross-libc returning #f in the packages which use >it seems error prone, hence adding the exception inside of cross-libc*. > >It looks liek cross-gcc-toolchain/implementation is expecting cross-libc >to return #f in some cases though, so maybe I need to add a guard there >somehow to handle the exception and ignore it, as happens when it >returns #f. This is because some targets as Ludovic mentioned don't have a proper libc, like most *-elf targets. Also, gnu-build-system also depends on cross-libc returning #f to check for those targets that don't have a libc in `cross-standard-packages'. Thanks, Jean-Pierre