From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 0BZeJHzWH2aOxwAAqHPOHw:P1 (envelope-from ) for ; Wed, 17 Apr 2024 16:02:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0BZeJHzWH2aOxwAAqHPOHw (envelope-from ) for ; Wed, 17 Apr 2024 16:02:36 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=foundation.xyz header.s=google header.b=Vv8In8ch; dmarc=fail reason="SPF not aligned (relaxed)" header.from=foundation.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713362556; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=n09olMq3aBQMAdVLoDwYCpQ/+rwZRU/ElCP9Yq5sLHE=; b=ZHOCIlu3R1ngnzaPaDOC2JDProM8CmbtKbJLtYgnkwR+ow2Ei12+7q5IimRuQvT2U9EjaJ UFKsiAxdINZP/sUmx4TQH0HAzfnRRZGCQwmgILeeXmJQLFNYbi81ixuA/TBB/gsX13SxuL 8vgPYTjzS+abE9o2d2fFUyBro3XgsKmdh2JilExnXj+T66ZtZMCkaoMZMc5nkRSUDo10+/ tLmhfr6jEibF2fKvN1+tAunndxE058bFGwclal3JEY7VALY68uPK+0jZUU6NEH3U5pMZTy 9AcI6fCcmVBLISh33k378DqGAK0wc79FDuIRMtO3hl+tgVeedSfI1K9g08pozg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=foundation.xyz header.s=google header.b=Vv8In8ch; dmarc=fail reason="SPF not aligned (relaxed)" header.from=foundation.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713362556; a=rsa-sha256; cv=none; b=PHPPsG+vzvAI5hUQQnM2EZqrFAHF7lY0m2UsyAERQ9nfeN4wOtVsJs3t/1DDBejeU2bY35 oVqvmmGjSIQ955RRvOaF8TU8GVkerVse/lHtfyZ0dQVdjDMEAaHgF3qjRxtGKrG4W8g/vs bkwJ+LrqxiNLMV47fsHqLuhHYJ80mBYbZvRe4XIT9FwIEOqLEm1M0IjxX56MCNoVGfBTvr RDQ3Sn8PnHAQKgvizOUXxTtmiheFMGQ84DbTXI3crZ40yvyrptJ/d2vWLj3KvVq5c3JdGF G24lVNnp5Pde3gxOcSer3FlQUylyNU0Q4QpdIiRzP9q1gzBnmwzdd5VnG2DayQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E5C589EF2 for ; Wed, 17 Apr 2024 16:02:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx5rD-0005bp-FM; Wed, 17 Apr 2024 10:01:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx5rB-0005bB-Ai for guix-patches@gnu.org; Wed, 17 Apr 2024 10:01:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx5rB-00032V-1Y for guix-patches@gnu.org; Wed, 17 Apr 2024 10:01:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rx5rN-0000Iv-Uf for guix-patches@gnu.org; Wed, 17 Apr 2024 10:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69476] [PATCH 7/8] guix: cmake-build-system: Handle unknown systems. Resent-From: Jean-Pierre De Jesus Diaz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Apr 2024 14:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69476 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 69476@debbugs.gnu.org, Jean-Pierre De Jesus DIAZ Received: via spool by 69476-submit@debbugs.gnu.org id=B69476.1713362497969 (code B ref 69476); Wed, 17 Apr 2024 14:02:01 +0000 Received: (at 69476) by debbugs.gnu.org; 17 Apr 2024 14:01:37 +0000 Received: from localhost ([127.0.0.1]:46132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx5qv-0000Ey-FV for submit@debbugs.gnu.org; Wed, 17 Apr 2024 10:01:37 -0400 Received: from mail-oo1-xc34.google.com ([2607:f8b0:4864:20::c34]:53593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx5qo-0000Cx-Oa for 69476@debbugs.gnu.org; Wed, 17 Apr 2024 10:01:31 -0400 Received: by mail-oo1-xc34.google.com with SMTP id 006d021491bc7-5ac90ad396dso2211497eaf.3 for <69476@debbugs.gnu.org>; Wed, 17 Apr 2024 07:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundation.xyz; s=google; t=1713362468; x=1713967268; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n09olMq3aBQMAdVLoDwYCpQ/+rwZRU/ElCP9Yq5sLHE=; b=Vv8In8chVtI0SNokPOUjGntx1gfoyJ3QV1Z7iHuvsdNzUyA2kjcMoBrk+9Ma761dlv a+7G6YQogO44y+L8gjuobpwqI7FGiwz/woWFS1ZWtrCFhLd/AtaRSkhxBwKiyLosPmt+ Djw1FPlbbD/Asqxq3HRDoVWxuj03ZvihnRHW4il4P5k/Dnl1q4/25HRKuFwqy7ov02vv MV/zvFU2ysl96DZ16lEGYUvcEgdIndDnU0EG4ANX7w27Ikmrv9omvZ2TowHMMtFPU3Xq 5bESoTU0MjKusq1qEBkWUdY1Ic9OhgTLi55s1CmcroHhkEzUdTSirSlwIp6QCwJM9yZI Gytw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713362468; x=1713967268; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n09olMq3aBQMAdVLoDwYCpQ/+rwZRU/ElCP9Yq5sLHE=; b=FRtUlPBwWIIQDBCBTGA5EHzag6teIHwybj9S+ibN/4D2l4mxsMAZp/72hWWbuPtbUb 3ON49kzKJH4kLfd6qTordsvgOGJv81VYhB+EEbccblkFss/v4IkHf+5M/QnsnGaWlIRo iWVsKeMMXgoLq0nlS2veo5SJdmn3f1uwQrnqi/54CIvhQm6Jvudu6P5wu97BeA0BbJQD blinGe5kxK+kR41yaLcHxFseTLthIN5tp7fSVDXS6MTjv8Hn/0nMwzoY/U/d1S9O3GPH K1LqIx1a4Uto7zrfb0MibXqm0B7VTvX08GcUkwGeu8rjSxFH+nN0OM0mrrxUf3SDvXkB /Vvw== X-Forwarded-Encrypted: i=1; AJvYcCUkX07aPdTlkM8s331h+0BWHQA1gkyAYi7YUgCzA4UgZ9JgiPWpfoBUqcyLTbOOZ9ZdAyWfycZ4cey7H9UiEPsyIWD/5Zc= X-Gm-Message-State: AOJu0YyGpUdQ/eyTRz+zti4dSo5DmSmwK00vmc6BfnPSb0lxOcj7eeAx 2QBI3J1qiNsvdpckUA7BGa1lxAAKmPMCiAsA/cnFVggTpdvh19X28pIC/rezsuB55NDt4rnQkl/ 2XC6+c5of77NAR5tfR++LUo+Tqr6ioCOfL5md0PM0kRwy0Ql0 X-Google-Smtp-Source: AGHT+IGIQZfsMrNOVWbjaGSVtUZcGDFgtsarsrZzJYdaEsfjrbeG+rS38eJhDwJN8gUggLq63j6ePf2dWVREypAHUcI= X-Received: by 2002:a05:6358:3597:b0:186:29ce:397d with SMTP id o23-20020a056358359700b0018629ce397dmr23964133rwd.20.1713362467766; Wed, 17 Apr 2024 07:01:07 -0700 (PDT) MIME-Version: 1.0 References: <4d426a20ba51e666b481324ff6300ad2af98a5f3.1709219325.git.jean@foundationdevices.com> <87jzkwiabo.fsf@gnu.org> In-Reply-To: <87jzkwiabo.fsf@gnu.org> From: Jean-Pierre De Jesus Diaz Date: Wed, 17 Apr 2024 14:00:55 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.28 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -5.28 X-Migadu-Queue-Id: E5C589EF2 X-TUID: Iu1ZkdVOBBo7 >That said, we should arrange to land the =E2=80=98cmake-build-system.scm= =E2=80=99 patch >either on the next =E2=80=98core-updates=E2=80=99 branch or on a topic bra= nch. > >Thoughts? I think it'd appropiate for it to be on core-updates or a topic branch, the= most convenient for you and then the rest of the patches can be applied IMO. Th= anks for applying some of the patches. P.S.: The patch for CMake was also sent to before working on this issue as I discovered it while working on other targ= ets. On Wed, Apr 17, 2024 at 9:54=E2=80=AFAM Ludovic Court=C3=A8s = wrote: > > Jean-Pierre De Jesus DIAZ skribis: > > > * guix/build/cmake-build-system.scm (configure): Use Generic as the > > system name if the system is unknown. > > > > Change-Id: Ifd4a618ef67eb420b02d48f05291571aea44e46e > > --- > > guix/build/cmake-build-system.scm | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/guix/build/cmake-build-system.scm b/guix/build/cmake-build= -system.scm > > index d1ff5071be..0774124c95 100644 > > --- a/guix/build/cmake-build-system.scm > > +++ b/guix/build/cmake-build-system.scm > > @@ -69,9 +69,13 @@ (define* (configure #:key outputs (configure-flags '= ()) (out-of-source? #t) > > target "-gcc") > > (string-append "-DCMAKE_CXX_COMPILER=3D" > > target "-g++") > > - (if (string-contains target "mingw") > > - "-DCMAKE_SYSTEM_NAME=3DWindows" > > - "-DCMAKE_SYSTEM_NAME=3DLinux")) > > + (cond > > + ((string-contains target "mingw") > > + "-DCMAKE_SYSTEM_NAME=3DWindows") > > + ((string-contains target "linux") > > + "-DCMAKE_SYSTEM_NAME=3DLinux") > > + (else > > + "-DCMAKE_SYSTEM_NAME=3DGeneric"))) > > I spoke too fast. > > This patch is good but it triggers a rebuild of everything that depends > on CMake. > > So for now, I instead amended the last patch of the series like this: > > > I confirmed that this builds and that I get the same hashes. > > That said, we should arrange to land the =E2=80=98cmake-build-system.scm= =E2=80=99 patch > either on the next =E2=80=98core-updates=E2=80=99 branch or on a topic br= anch. > > Thoughts? > > Thanks, > Ludo=E2=80=99.