From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2IA9FLiT8WQjIAEAG6o9tA:P1 (envelope-from ) for ; Fri, 01 Sep 2023 09:33:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2IA9FLiT8WQjIAEAG6o9tA (envelope-from ) for ; Fri, 01 Sep 2023 09:33:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C371455200 for ; Fri, 1 Sep 2023 09:33:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=HnjA+Mlc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693553592; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=YC6gMQcFxmQr6eyPQC3KVtWAguTC15SLNc+NYEVQBoc=; b=ASLHGgkD49mgtKTpHRjzgIxtv0QYUsipf4VJzSDujnqjRs/gg9gaetYMq07CRK9b5WJpsy bgQsaUBQRhSe9D7Qosm9vZrXPJHJgEAsvQ4CxZFCm+h6TzWlKwwQmb6FIB6Zkc9NyVdHX7 iJoADyYfRXDr5y7yezMqBfpJxK/WssjAhWDmp6RGEPP9eJyS/4cA6Kj8fuLVj/o/bMDszY nl4rZjyJoPHsU+q29pspa0I8RtSW/cgFVeNABbACNflLbNnDk+xJcFN3ZUuHXcG54an+/0 vV8xNnod5OJzlojnrWNMvEzs2pbkvNVA3jfRm4tISRH/gCfoCEazHwGQbz+Lkw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693553592; a=rsa-sha256; cv=none; b=eu5TeXUHihl024BQPLoVbCKNj9JU5l3oG2fHuywMBXc2h/Rgq0Nd1zggf2lawX0DflHM/c 4sEnC9OYkRhZwOnO+SZqXYZGVRk+JGmmMxEQubAyuHx9kHSuYfceC7GqQhEhrEYYqVKNZw veIkmNa/chVZOOinCceWMOohQbtJHNqOJz3+3dJq33JQx+paMklgzThYu5PUdTyWywayuq HiDAmhKacQn4ayNB0/ApAVbHGS8XmFjJBuWnP69TfsrC0mYotbsvP3u+GM/BNLpsFhf6G+ kBx4WGlmrR+NlD+HSJe7gXZOIK0n/Dx2mMqP4kJfvd8UgMkB/RvvB8ULGxkqpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=HnjA+Mlc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbyeL-0006Bp-Tg; Fri, 01 Sep 2023 03:33:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbyeD-0006B4-Lr for guix-patches@gnu.org; Fri, 01 Sep 2023 03:32:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbyeD-00085b-CH for guix-patches@gnu.org; Fri, 01 Sep 2023 03:32:53 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbyeM-0005MA-32 for guix-patches@gnu.org; Fri, 01 Sep 2023 03:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65489] [PATCH] gnu: tor: Update to 0.4.8.4. Resent-From: Michael Ford Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Sep 2023 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65489 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Andr=C3=A9?= Batista Cc: 65489@debbugs.gnu.org Received: via spool by 65489-submit@debbugs.gnu.org id=B65489.169355353320533 (code B ref 65489); Fri, 01 Sep 2023 07:33:02 +0000 Received: (at 65489) by debbugs.gnu.org; 1 Sep 2023 07:32:13 +0000 Received: from localhost ([127.0.0.1]:59782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbydY-0005L7-Em for submit@debbugs.gnu.org; Fri, 01 Sep 2023 03:32:13 -0400 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]:52226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbydV-0005Kr-Jx for 65489@debbugs.gnu.org; Fri, 01 Sep 2023 03:32:10 -0400 Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-d7ba4c5f581so1324135276.0 for <65489@debbugs.gnu.org>; Fri, 01 Sep 2023 00:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693553515; x=1694158315; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YC6gMQcFxmQr6eyPQC3KVtWAguTC15SLNc+NYEVQBoc=; b=HnjA+MlcUMpfu9WIEB/XDdGLFLwvkYSFRyql/7i2nu8kU55v8aoAwCU9XvN+joH+4r WCcn7+rdxjOu2cgHJqOTMD9U42tq43Z/NCxEP8xWaqbu5qJAJD/qwxSS9QrFd5Riw5PJ y0twdKnQ4JiH+AWtyA5uQlsrZvCT0xHBTF9T4ig7G30282Z5Ox9eFQw0pohxdrozDkrp mghDD3fB2VtiZTSf19xWEbGzlCQ9siL5ac1eG1KpabOZQ1/rgIVAZn98h02xLDGO7zLP a9c98MIVNvG/6lwUElK5qZ4NdZBnhO9hJrgKdMU+01yyaqPPii0TVPAdwZop6qeWw1vy LAlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693553515; x=1694158315; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YC6gMQcFxmQr6eyPQC3KVtWAguTC15SLNc+NYEVQBoc=; b=DcdjVLSQnxoE63RyvwEWCK7myqWuklN1+a1B+eY22PMADqguXZXFnrvoCmOD2Zv/eL c179m6j+yVrrXhm2dYL6HcFwuHzvErX3yyX3lPwLE0qYaWj/SadR/7sL2Lood99tU/O7 DjJd0hYmI2g/B0+e722sS2L2PAkDN4HA1N5o8VK3AoinajZCSLruBwVBwyY9YR5r0baY hP/rkWcl76qsPC03Lc8dXY81clX+qZRhoLoqqRhTP1z6B2BqfKFvDG/DJQwgi40Q0TKF MJjtNLjS/mWjaj5sxDo8IeHBV/0u8ZdbUP8ZrTFyoopPCevAIFftD6u+P6rR6GiYRx6U nigw== X-Gm-Message-State: AOJu0YzjNMI2FOxzqIzvA9GSSFlsllVfxKTZorPaTZmBlanmUm2bYxHF WLewB/GHqRTNRog0jOkdMBnO671VKsYLxwOKrnE= X-Google-Smtp-Source: AGHT+IF44cIQYY10tz3sUUXghqIpU1lz6/f8+kj1vyOpp7vqjmy6qr7eb61qvj8mfilL7AJN1Q3fhuXDqxwOU9pjXWs= X-Received: by 2002:a25:3751:0:b0:d7e:8175:4fa9 with SMTP id e78-20020a253751000000b00d7e81754fa9mr736550yba.4.1693553514668; Fri, 01 Sep 2023 00:31:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Michael Ford Date: Fri, 1 Sep 2023 10:31:43 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000a666bd0604472780" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.78 X-Spam-Score: 2.78 X-Migadu-Queue-Id: C371455200 X-Migadu-Scanner: mx2.migadu.com X-TUID: 1WUK9jCZ306J --000000000000a666bd0604472780 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andre, I've taken your suggestions. Here is the updated patch. Thanks >From a7c754da51888f23755ba46904191bf16523fc17 Mon Sep 17 00:00:00 2001 From: fanquake Date: Thu, 24 Aug 2023 09:47:33 +0100 Subject: [PATCH] gnu: tor: Update to 0.4.8.5. * gnu/packages/tor.scm (tor): Update to 0.4.8.5. * gnu/packages/tor.scm (tor)[arguments]<#:configure-flags>: Add "--enable-gpl". * gnu/packages/patches/tor-remove-defensive-assert.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/tor.scm (tor)[source]: Add patch to remove defensive assert. --- gnu/local.mk | 1 + .../patches/tor-remove-defensive-assert.patch | 28 +++++++++++++++++++ gnu/packages/tor.scm | 8 ++++-- 3 files changed, 34 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/patches/tor-remove-defensive-assert.patch diff --git a/gnu/local.mk b/gnu/local.mk index 9b493df8d5..6a4f9dabb2 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2012,6 +2012,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/tofi-32bit-compat.patch \ %D%/packages/patches/tootle-glib-object-naming.patch \ %D%/packages/patches/tootle-reason-phrase.patch \ + %D%/packages/patches/tor-remove-defensive-assert.patch \ %D%/packages/patches/transcode-ffmpeg.patch \ %D%/packages/patches/transfig-gcc10-fno-common.patch \ %D%/packages/patches/trytond-add-egg-modules-to-path.patch \ diff --git a/gnu/packages/patches/tor-remove-defensive-assert.patch b/gnu/packages/patches/tor-remove-defensive-assert.patch new file mode 100644 index 0000000000..7207ec867a --- /dev/null +++ b/gnu/packages/patches/tor-remove-defensive-assert.patch @@ -0,0 +1,28 @@ +This patch removes a call to `tor_assert_nonfatal_unreached()` in +`relay_key_is_unavailable_()` that is only called when Tor is compiled +without relay support. + +Unfortunately, the non-fatal assertion causes a BUG log +message to appear for clients when they start up without relay support +for each CPU worker we spawn. This makes it spotting issues during +bootstrap harder particularly for our iOS developers. + +Since the call sites to `get_master_identity_key()` handles `NULL` +values already, we do not think this will be an issue later on. + +Reported by Benjamin Erhart (@tla) from Guardian Project. + +Fixes tpo/core/tor#40848. + +diff --git a/src/feature/relay/routerkeys.h b/src/feature/relay/routerkeys.h +index 7b6d80773c..b97615a9c9 100644 +--- a/src/feature/relay/routerkeys.h ++++ b/src/feature/relay/routerkeys.h +@@ -53,7 +53,6 @@ void routerkeys_free_all(void); + static inline void * + relay_key_is_unavailable_(void) + { +- tor_assert_nonfatal_unreached(); + return NULL; + } + #define relay_key_is_unavailable(type) \ diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm index 7fec88656f..44e62b63cc 100644 --- a/gnu/packages/tor.scm +++ b/gnu/packages/tor.scm @@ -63,18 +63,20 @@ (define-module (gnu packages tor) (define-public tor (package (name "tor") - (version "0.4.7.14") + (version "0.4.8.5") (source (origin (method url-fetch) (uri (string-append "https://dist.torproject.org/tor-" version ".tar.gz")) (sha256 (base32 - "1y2xwrji1rvk6h0k15705yra5s74h72h2g84x02zr0338vv6gb55")))) + "06g1awb4piqvgxa97pyswxgjzkpj8rx3iy2jbiaygvi99b8wymv9")) + (patches (search-patches "tor-remove-defensive-assert.patch")))) (build-system gnu-build-system) (arguments (list #:configure-flags - #~(list "--enable-lzma" + #~(list "--enable-gpl" + "--enable-lzma" "--enable-zstd") #:phases #~(modify-phases %standard-phases --=20 2.42.0 On Thu, 31 Aug 2023 at 03:10, Andr=C3=A9 Batista wrote: > Hi Michael! > > The Tor Project has released v0.4.8.5, so I guess we can skip > v0.4.8.4. Would you care to send a new version of your patch? > > Also, Tor v0.4.8.x has introduced a new PoW feature which is useful > for Onion Service operators and users during those all too common > DDoS attempts on the network. However, the feature is disabled by > default because the code was GPL'd. So, in order to enable it for > Guix users - whom I think won't have an issue with GPL code ;) -, you > need to change the current package definition configure flags and add > "--enable-gpl", otherwise we will be missing on this. > > Moreover, I'm running the tor-client package and have hit on core/tor > issue #40848[1], since upgrading to v0.4.8.5. Apparently it's a > pretty harmless bug assertion which Alexander F=C3=A6r=C3=B8y solved [2] = by > just removing the bug assertion. Nonetheless, I think it's best if we > also include that patch on Guix, otherwise there may be future > repeated questions from guix users once they start seeing it show up > on system logs. > > WDYT? > > Cheers! > > 1 - https://gitlab.torproject.org/tpo/core/tor/-/issues/40848 > 2 - https://gitlab.torproject.org/tpo/core/tor/-/merge_requests/752 > --000000000000a666bd0604472780 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Andre,

I've taken you= r suggestions.
Here is the updated patch.
Thanks
<= div>
From a7c754da51888f23755ba46904191bf16523fc17 Mon Sep 17= 00:00:00 2001
From: fanquake <= fanquake@gmail.com>
Date: Thu, 24 Aug 2023 09:47:33 +0100
Subj= ect: [PATCH] gnu: tor: Update to 0.4.8.5.

* gnu/packages/tor.scm (to= r): Update to 0.4.8.5.
* gnu/packages/tor.scm (tor)[arguments]<#:conf= igure-flags>:
Add "--enable-gpl".
* gnu/packages/patches= /tor-remove-defensive-assert.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it.
* gnu/packages/tor.= scm (tor)[source]: Add patch to remove defensive
=C2=A0 assert.
---=C2=A0gnu/local.mk =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| =C2=A01 +
=C2=A0.../patches/tor-remove-defensi= ve-assert.patch | 28 +++++++++++++++++++
=C2=A0gnu/packages/tor.scm =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| =C2=A08 ++++--
=C2=A03 files changed, 34 insertions(+), 3= deletions(-)
=C2=A0create mode 100644 gnu/packages/patches/tor-remove-d= efensive-assert.patch

diff --git a/gnu/l= ocal.mk b/gnu/local.mk
index 9b493df= 8d5..6a4f9dabb2 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -2012,6 +2012= ,7 @@ dist_patch_DATA =3D \
=C2=A0 =C2=A0%D%/packages/patches/tofi-= 32bit-compat.patch \
=C2=A0 =C2=A0%D%/packages/patches/tootle-glib-obj= ect-naming.patch \
=C2=A0 =C2=A0%D%/packages/patches/tootle-reason-phra= se.patch \
+ =C2=A0%D%/packages/patches/tor-remove-defensive-assert.pat= ch =C2=A0 \
=C2=A0 =C2=A0%D%/packages/patches/transcode-ffmpeg.patch \=C2=A0 =C2=A0%D%/packages/patches/transfig-gcc10-fno-common.patch \
= =C2=A0 =C2=A0%D%/packages/patches/trytond-add-egg-modules-to-path.patch \diff --git a/gnu/packages/patches/tor-remove-defensive-assert.patch b/gnu= /packages/patches/tor-remove-defensive-assert.patch
new file mode 100644=
index 0000000000..7207ec867a
--- /dev/null
+++ b/gnu/packages/pat= ches/tor-remove-defensive-assert.patch
@@ -0,0 +1,28 @@
+This patch r= emoves a call to `tor_assert_nonfatal_unreached()` in
+`relay_key_is_una= vailable_()` that is only called when Tor is compiled
+without relay sup= port.
+
+Unfortunately, the non-fatal assertion causes a BUG log
+= message to appear for clients when they start up without relay support
+= for each CPU worker we spawn. This makes it spotting issues during
+boot= strap harder particularly for our iOS developers.
+
+Since the call s= ites to `get_master_identity_key()` handles `NULL`
+values already, we d= o not think this will be an issue later on.
+
+Reported by Benjamin E= rhart (@tla) from Guardian Project.
+
+Fixes tpo/core/tor#40848.
+=
+diff --git a/src/feature/relay/routerkeys.h b/src/feature/relay/router= keys.h
+index 7b6d80773c..b97615a9c9 100644
+--- a/src/feature/relay/= routerkeys.h
++++ b/src/feature/relay/routerkeys.h
+@@ -53,7 +53,6 @@= void routerkeys_free_all(void);
+ static inline void *
+ relay_key_i= s_unavailable_(void)
+ {
+- =C2=A0tor_assert_nonfatal_unreached();+ =C2=A0 return NULL;
+ }
+ #define relay_key_is_unavailable(type) \=
diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
index 7fec8= 8656f..44e62b63cc 100644
--- a/gnu/packages/tor.scm
+++ b/gnu/package= s/tor.scm
@@ -63,18 +63,20 @@ (define-module (gnu packages tor)
=C2= =A0(define-public tor
=C2=A0 =C2=A0(package
=C2=A0 =C2=A0 =C2=A0(name= "tor")
- =C2=A0 =C2=A0(version "0.4.7.14")
+ =C2= =A0 =C2=A0(version "0.4.8.5")
=C2=A0 =C2=A0 =C2=A0(source (ori= gin
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method url-fetch)<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (string-append &qu= ot;https://dist.torproject.org= /tor-"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 version &quo= t;.tar.gz"))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha2= 56
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
- = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "1y2xwrji1rvk6h0k1570= 5yra5s74h72h2g84x02zr0338vv6gb55"))))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 "06g1awb4piqvgxa97pyswxgjzkpj8rx3iy2jbiaygvi99b8= wymv9"))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (patches (sear= ch-patches "tor-remove-defensive-assert.patch"))))
=C2=A0 =C2= =A0 =C2=A0(build-system gnu-build-system)
=C2=A0 =C2=A0 =C2=A0(arguments=
=C2=A0 =C2=A0 =C2=A0 (list #:configure-flags
- =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 #~(list "--enable-lzma"
+ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 #~(list "--enable-gpl"
+ =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "--enable-lzma"
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "--= enable-zstd")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #:phases=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #~(modify-phases %standard-phase= s
--
2.42.0

On Thu, 31 Aug 2023 at 03:10, Andr=C3=A9 Batista &l= t;nandre@riseup.net> wrote:
=
Hi Michael!

The Tor Project has released v0.4.8.5, so I guess we can skip
v0.4.8.4. Would you care to send a new version of your patch?

Also, Tor v0.4.8.x has introduced a new PoW feature which is useful
for Onion Service operators and users during those all too common
DDoS attempts on the network. However, the feature is disabled by
default because the code was GPL'd. So, in order to enable it for
Guix users - whom I think won't have an issue with GPL code ;) -, you need to change the current package definition configure flags and add
"--enable-gpl", otherwise we will be missing on this.

Moreover, I'm running the tor-client package and have hit on core/tor issue #40848[1], since upgrading to v0.4.8.5. Apparently it's a
pretty harmless bug assertion which Alexander F=C3=A6r=C3=B8y solved [2] by=
just removing the bug assertion. Nonetheless, I think it's best if we also include that patch on Guix, otherwise there may be future
repeated questions from guix users once they start seeing it show up
on system logs.

WDYT?

Cheers!

1 - https://gitlab.torproject.org/tpo/core/= tor/-/issues/40848
2 - https://gitlab.torproject.org/tpo= /core/tor/-/merge_requests/752
--000000000000a666bd0604472780--