From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kP33H6vcbl9YQQAA0tVLHw (envelope-from ) for ; Sat, 26 Sep 2020 06:16:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aNX7G6vcbl+XFgAA1q6Kng (envelope-from ) for ; Sat, 26 Sep 2020 06:16:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F23509402B3 for ; Sat, 26 Sep 2020 06:16:10 +0000 (UTC) Received: from localhost ([::1]:35972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kM3VB-0007Pq-K7 for larch@yhetil.org; Sat, 26 Sep 2020 02:16:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kM3V4-0007Pj-RZ for guix-patches@gnu.org; Sat, 26 Sep 2020 02:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kM3V4-0006Bv-It for guix-patches@gnu.org; Sat, 26 Sep 2020 02:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kM3V4-0005mE-E8 for guix-patches@gnu.org; Sat, 26 Sep 2020 02:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43628] Request for patch evaluation/review Resent-From: Prafulla Giri Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Sep 2020 06:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43628 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 43628@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160110095922193 (code B ref -1); Sat, 26 Sep 2020 06:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Sep 2020 06:15:59 +0000 Received: from localhost ([127.0.0.1]:45662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM3V1-0005lt-Bu for submit@debbugs.gnu.org; Sat, 26 Sep 2020 02:15:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:58868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM3Uy-0005lk-Q5 for submit@debbugs.gnu.org; Sat, 26 Sep 2020 02:15:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kM3Uy-0007PX-Jc for guix-patches@gnu.org; Sat, 26 Sep 2020 02:15:56 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:46410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kM3Uw-00065y-GB for guix-patches@gnu.org; Sat, 26 Sep 2020 02:15:56 -0400 Received: by mail-pl1-x635.google.com with SMTP id f1so407859plo.13 for ; Fri, 25 Sep 2020 23:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3pvOTPmUec0m1v3XpXB0EGphDNi0LV0CvjpckLo5g6o=; b=nvEdFLuUh6CqkKmXo2TJv7YO54uD2Za1toMIRKKVXZQAYU9DG9IfikbLJut0/RnLqe Mykr9NbPr2bxydcoR1nHD8O1mRbR/L6FckKMFtkJqV1hi1jGFIhSMM8AT5m3pEI/n32e usuJ6pEMCmzF0RFbs2ksUHk7M4b6KkLKrAR+ZZfuEyWhnWqrZsNPMYVOFdzN4S39FP5M z2n/YDMzk0NkBSfdYdOR30RP1mRKVlMkTuKHv4F7SvbvDQixJwL5nM5vQZlQ+33RHF5s yskdWK2elKyGL/JhuuVNux1b8Qps/obmSxsMJRL2alJ5Jcg8WUH0Mnp6dy+h/7G24SMH vNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3pvOTPmUec0m1v3XpXB0EGphDNi0LV0CvjpckLo5g6o=; b=mEQgv04H1mVwb3CLBUn1rqWv/UwVCgOUxdrgKEI17kvpQBMrc84gb3EEB+sGZQGc/R SmmJXm+P4E5B0GlrYmIqxJVH4nXbGJC3FUUYpQU4kbskng6q+8zGvrLLPL24OfAaCRex qvym7z4RbADoTf2o41Yup3LRM3ohlJE+wFwH5lZZTY0gc47CUYAAAlZCoy7D/rp+f1CJ j3dM12emEFLvCQyX9WXC46kLDhXKXd3e5sfcWpztJA2z8YAtQpVAQHnO0bU+eKDGuY+H PtqfSV59kj0440HW4lRrEiQvhnNXIOQFCCd+ywV4CTBm9fcrwXAKvXfyM0gw9amsvM8+ yi5Q== X-Gm-Message-State: AOAM532dK9TJmpAFes1olkp4vg4aXTchVQq8OTvhjoWf5seSOG0OQuwB hkhas3I+yie9I25CDeRO2bUSg8/X/TqIq3xTn/awpt/08NM= X-Google-Smtp-Source: ABdhPJwnDh6h/HQC7r8ECN2kMl1A5naXWXmteATCWcZRI+ld3ICYDNnUX3sodUvtiMJLICUSdUkrxnhG4N/NM+JxvfA= X-Received: by 2002:a17:90a:d3cd:: with SMTP id d13mr1018700pjw.70.1601100952079; Fri, 25 Sep 2020 23:15:52 -0700 (PDT) MIME-Version: 1.0 From: Prafulla Giri Date: Sat, 26 Sep 2020 12:00:40 +0545 Message-ID: Content-Type: multipart/mixed; boundary="0000000000007fb6d605b0315d82" Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=pratheblackdiamond@gmail.com; helo=mail-pl1-x635.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=nvEdFLuU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.19 X-TUID: 2Bg4X+iuGPkS --0000000000007fb6d605b0315d82 Content-Type: multipart/alternative; boundary="0000000000007fb6c405b0315d80" --0000000000007fb6c405b0315d80 Content-Type: text/plain; charset="UTF-8" Esteemed maintainers (and contributors), Attached is a patch which, as far as I can see, should work. But it does not. I would like to submit it here for review. Please tell me what I am doing wrong or what I am failing to do, so that I might clean up this patch and submit a proper one. 1. The problem this patch is trying to solve: Aegisub (guix install aegisub), as it currently is, does not give any sound (at least on foreign distros). The terminal output reads as follows, when a video file (with audio) is added into the program and an attempt is made at playing it: (Video is added to aegisub by using 'Video > Open Video...') ``` ALSA lib conf.c:3683:(snd_config_hooks_call) Cannot open shared library libasound_module_conf_pulse.so (/gnu/store/zcjdb23gbhl0pcnvvm8rnlprkfl43cv5-alsa-lib-1.2.2/lib/alsa-lib/libasound_module_conf_pulse.so: libasound_module_conf_pulse.so: cannot open shared object file: No such file or directory) ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default ``` The complaint being that it can't find libasound_module_conf_pulse.so. This .so comes from the guix package `alsa-plugins:pulseaudio`. The /gnu/store directory for it is something like /gnu/store/...-alsa-plugins-1.2.2-pulseaudio/lib/alsa-lib/libasound_module_conf_pulse.so. However, the .so file is being looked for inside of the /gnu/store path to alsa-lib (/gnu/store/...-alsa-lib-1.2.2/lib/alsa-lib/libasound_module_conf_pulse.so. 2. The Natural Solution: Since libasound_module_conf_pulse.so is supplied by `alsa-plugins:pulseaudio`, and the program is looking for it inside the path to alsa-lib (supplied by `alsa-lib`), union-build is a logical solution. This is what the patch implements. 3. Problem: Despite this patch being applied, it continues to look for the .so file inside the path to alsa-lib and not the union-alsa. What is more, alsa-lib is not even in the inputs. Only union-alsa is. And yet, it seems to be trying to use alsa-lib's /gnu/store path, which, the way I see it, violates guix's functional package management. 4. It's not guix, it's me: I'm sure this is some mistake on my part. Hence, I submit the diff here for review. P. S: The diff has changed a bit because I got this idea of moving out/lib/alsa-lib/* into out/lib/ just to see if that makes any difference. Only to realize a little too late that it doesn't. But I send the diff with those changes included because I didn't stash the previous (cleaner) one. --0000000000007fb6c405b0315d80 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Esteemed maintainers (and contributors),
Attached is a patch which, as far as I can see, should work. B= ut it does not. I would like to submit it here for review. Please tell me w= hat I am doing wrong or what I am failing to do, so that I might clean up t= his patch and submit a proper one.

1. The problem = this patch is trying to solve:
Aegisub (guix install aegisub)= , as it currently is, does not give any sound (at least on foreign distros)= . The terminal output reads as follows, when a video file (with audio) is a= dded into the program and an attempt is made at playing it: (Video is added= to aegisub by using 'Video > Open Video...')
```<= /div>
ALSA lib conf.c:3683:(snd_config_hooks_call) Cannot open shared l= ibrary libasound_module_conf_pulse.so (/gnu/store/zcjdb23gbhl0pcnvvm8rnlprk= fl43cv5-alsa-lib-1.2.2/lib/alsa-lib/libasound_module_conf_pulse.so: libasou= nd_module_conf_pulse.so: cannot open shared object file: No such file or di= rectory)
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM default=
```
The complaint being that it can't find libasou= nd_module_conf_pulse.so. This .so comes from the guix package `alsa-plugins= :pulseaudio`. The /gnu/store directory for it is something like /gnu/store/= ...-alsa-plugins-1.2.2-pulseaudio/lib/alsa-lib/libasound_module_conf_pulse.= so. However, the .so file is being looked for inside of the /gnu/store path= to alsa-lib (/gnu/store/...-alsa-lib-1.2.2/lib/alsa-lib/libasound_module_c= onf_pulse.so.

2. The Natural Solution:
S= ince libasound_module_conf_pulse.so is supplied by `alsa-plugins:pulseaudio= `, and the program is looking for it inside the path to alsa-lib (supplied = by `alsa-lib`), union-build is a logical solution. This is what the patch i= mplements.

3. Problem:
Despite this patc= h being applied, it continues to look for the .so file inside the path to a= lsa-lib and not the union-alsa. What is more, alsa-lib is not even in the i= nputs. Only union-alsa is. And yet, it seems to be trying to use alsa-lib&#= 39;s /gnu/store path, which, the way I see it, violates guix's function= al package management.

4. It's not guix, it= 9;s me:
I'm sure this is some mistake on my part. Hence, I su= bmit the diff here for review.

P. S: The diff has = changed a bit because I got this idea of moving out/lib/alsa-lib/* into out= /lib/ just to see if that makes any difference. Only to realize a little to= o late that it doesn't. But I send the diff with those changes included= because I didn't stash the previous (cleaner) one.
--0000000000007fb6c405b0315d80-- --0000000000007fb6d605b0315d82 Content-Type: text/x-patch; charset="US-ASCII"; name="aegisub_alsa_pulseaudio.diff" Content-Disposition: attachment; filename="aegisub_alsa_pulseaudio.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfja5kfu0 ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy92aWRlby5zY20gYi9nbnUvcGFja2FnZXMvdmlkZW8u c2NtCmluZGV4IDBmNzI3YTZlOWUuLjBlMDM3ZmIyNGIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdl cy92aWRlby5zY20KKysrIGIvZ251L3BhY2thZ2VzL3ZpZGVvLnNjbQpAQCAtMzgzNiw3ICszODM2 LDQxIEBAIHByb2dyYW1tZXJzIHRvIGFjY2VzcyBhIHN0YW5kYXJkIEFQSSB0byBvcGVuIGFuZCBk ZWNvbXByZXNzIG1lZGlhIGZpbGVzLiIpCiAgICAgICAgKCJodW5zcGVsbCIgLGh1bnNwZWxsKQog ICAgICAgICgibWVzYSIgLG1lc2EpCiAgICAgICAgKCJsaWJhc3MiICxsaWJhc3MpCi0gICAgICAg KCJhbHNhLWxpYiIgLGFsc2EtbGliKQorICAgICAgICgiYWxzYS1saWItd2l0aC1wdWxzZWF1ZGlv LXBsdWdpbiIKKyAgICAgICAgLChwYWNrYWdlCisgICAgICAgICAgIChpbmhlcml0IGFsc2EtbGli KQorICAgICAgICAgICAobmFtZSAiYWxzYS1saWItd2l0aC1wdWxzZWF1ZGlvLXBsdWdpbiIpCisg ICAgICAgICAgIChzb3VyY2UgI2YpCisgICAgICAgICAgIChidWlsZC1zeXN0ZW0gdHJpdmlhbC1i dWlsZC1zeXN0ZW0pCisgICAgICAgICAgIChhcmd1bWVudHMKKyAgICAgICAgICAgIGAoIzptb2R1 bGVzICgoZ3VpeCBidWlsZCB1bmlvbikKKwkJICAgICAgICAgKGd1aXggYnVpbGQgdXRpbHMpKQor ICAgICAgICAgICAgICAjOmJ1aWxkZXIKKyAgICAgICAgICAgICAgKGJlZ2luCisJICAgICAgICAo dXNlLW1vZHVsZXMgKGljZS05IG1hdGNoKQorCQkgICAgICAgICAgICAgKGd1aXggYnVpbGQgdW5p b24pCisJCSAgICAgICAgICAgICAoZ3VpeCBidWlsZCB1dGlscykpCisJICAgICAgICAobGV0ICgo b3V0IChhc3NvYy1yZWYgJW91dHB1dHMgIm91dCIpKSkKKwkgICAgICAgICAgKG1hdGNoICVidWls ZC1pbnB1dHMKKwkgICAgICAgICAgICAoKChuYW1lcyAuIGRpcmVjdG9yaWVzKSAuLi4pCisJICAg ICAgICAgICAgICh1bmlvbi1idWlsZCBvdXQKKwkJCSAgICAgICAgICBkaXJlY3RvcmllcworCQkJ ICAgICAgICAgICM6Y3JlYXRlLWFsbC1kaXJlY3Rvcmllcz8gI2YpCisJICAgICAgICAgICAgICN0 KSkKKwkgICAgICAgICAgOzsgZG8gc3R1ZmYgaGVyZQorCSAgICAgICAgICAoZmluZC1maWxlcyAo c3RyaW5nLWFwcGVuZCBvdXQgIi9saWIvYWxzYS1saWIvIikKKwkJICAgICAgICAgICAgICAobGFt YmRhIChmb3VuZCBzdGF0KQorCQkJICAgICAgICAoc3ltbGluay1yZWxhdGl2ZQorCQkJICAgICAg ICAgZm91bmQKKwkJCSAgICAgICAgIChzdHJpbmctYXBwZW5kCisJCQkgICAgICAgICAgb3V0CisJ CQkgICAgICAgICAgIi9saWIvIgorCQkJICAgICAgICAgIChiYXNlbmFtZSBmb3VuZCkpKQorCQkJ ICAgICAgICAjdCkpKQorCSAgICAgICAgI3QpKSkKKyAgICAgICAgICAgKGlucHV0cworICAgICAg ICAgICAgYCgoImFsc2EtbGliIiAsYWxzYS1saWIpCisgICAgICAgICAgICAgICgiYWxzYS1wbHVn aW5zOnB1bHNlYXVkaW8iICxhbHNhLXBsdWdpbnMgInB1bHNlYXVkaW8iKSkpKSkKICAgICAgICAo InB1bHNlYXVkaW8iICxwdWxzZWF1ZGlvKQogICAgICAgICgibGlieDExIiAsbGlieDExKQogICAg ICAgICgiZnJlZXR5cGUiICxmcmVldHlwZSkK --0000000000007fb6d605b0315d82--