From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oNxLFNqrVV8NBQAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 03:41:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uBYwENqrVV+aBAAAB5/wlQ (envelope-from ) for ; Mon, 07 Sep 2020 03:41:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D07D69401D0 for ; Mon, 7 Sep 2020 03:41:13 +0000 (UTC) Received: from localhost ([::1]:45698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF81n-0007EB-4u for larch@yhetil.org; Sun, 06 Sep 2020 23:41:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF81e-0007Dk-8d for guix-patches@gnu.org; Sun, 06 Sep 2020 23:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36044) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF81d-0002rV-LR for guix-patches@gnu.org; Sun, 06 Sep 2020 23:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kF81d-0005o5-Id for guix-patches@gnu.org; Sun, 06 Sep 2020 23:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42885] Regarding Patch 4 Resent-From: Prafulla Giri Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 03:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42885 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42885@debbugs.gnu.org Received: via spool by 42885-submit@debbugs.gnu.org id=B42885.159945003522280 (code B ref 42885); Mon, 07 Sep 2020 03:41:01 +0000 Received: (at 42885) by debbugs.gnu.org; 7 Sep 2020 03:40:35 +0000 Received: from localhost ([127.0.0.1]:47590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF81D-0005nH-ER for submit@debbugs.gnu.org; Sun, 06 Sep 2020 23:40:35 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:33794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kF81B-0005n4-Fp for 42885@debbugs.gnu.org; Sun, 06 Sep 2020 23:40:34 -0400 Received: by mail-pf1-f180.google.com with SMTP id v196so7922899pfc.1 for <42885@debbugs.gnu.org>; Sun, 06 Sep 2020 20:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=uWLGQ4tkAjl2mzMWvtYkzTjyJ0Vkor1EUdOjmYorfw4=; b=WZZ8T3BnRmwpN7iBt1iARP1tqswug/0ppM7/KSK8e++Q+5t35wSW4oV3uf9qqpveKB 3QBWwKoKtciJhjIgEDs5wXXrcLfmyHeo4mezS7oYvy+HUHpSgMfzHvk2b2VAuCfkBDTt cXnXMQie0XGCPDmTWurVUeEYotB5kjISJLqaBoYHYg08vJ4+psudGhcK5D6mI7RClr5I szhDa+mmPnDlN85a8SoNiuQQcg0qCM4dA9T0wK2p+Wum/sz/L7EemP6uAdn5mIpsmDQD Rt4fwA0D5QsnQaBUMxskxqeB2ucyFHNODOda+Eog0RlYV3Qwcrm2u2SVGL3h5Xs+fO5P uXRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=uWLGQ4tkAjl2mzMWvtYkzTjyJ0Vkor1EUdOjmYorfw4=; b=Mjsk4tJ9EP9V2rAjtRNfx/EwNJbrGn7EvMMCTNoXXLB2cmhWN0Dnx+DKdxkNFMfhby TR/95ZCGgiA04CbhrlzSmMWHrR2qkosx6/v0fAvoT2L5uxqeU0ZeOVL4l+MAc5vRe8Bt b+Ka97aDpl+RcdiNuwFmUQzfsJMuzoX+1auOj9qsbpX6KB0VWehXkuRkhCxLbc+WdpKn gzh3jmXlFaCRdiN/V3y+25mClWKpWuEFa4uwAH2E0mQ3aXwHBbKNgVBabt7B2d616gc5 sPCnu77GPb9Oxu3M6Ai5DvMe89Os07/HA3qSe+kI0WwAhn0JPBpbFSVuDcalbk0c0mI2 /N5Q== X-Gm-Message-State: AOAM532U1ZqXv5oj+WcC35ZCQc/mdA+TKm6aKpbmk8K0HDr9OABDK+W4 i6ujfploKVbvvLd42Husjpti5MboPIBIZUPfp7Y1wy1vdpw= X-Google-Smtp-Source: ABdhPJwhJuTf4bhTiKN0u9u+KXJZWp4yL64UjM0R3kBXxV9pzOP14bAY6TFqCnBWObMluefMXI1LQNdM969b3cZbrcU= X-Received: by 2002:a65:5c0d:: with SMTP id u13mr15976473pgr.333.1599450027308; Sun, 06 Sep 2020 20:40:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prafulla Giri Date: Mon, 7 Sep 2020 09:25:15 +0545 Message-ID: Content-Type: multipart/alternative; boundary="000000000000b6bb5d05aeb0fa6c" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=WZZ8T3Bn; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.09 X-TUID: AO0IOiF8st4m --000000000000b6bb5d05aeb0fa6c Content-Type: text/plain; charset="UTF-8" I just realized that the PYTHONPATH set by the default %standard-phase 'wrap of python-build-environment is (most likely) a superset of the manual PYTHONPATH set by the custom phase 'wrap phase added after 'install in patch no. 4. As such, perhaps it is redundant, too? On Mon, Sep 7, 2020 at 8:56 AM Prafulla Giri wrote: > Hey there Mr. Tildesley, > > Without knowing that this was going on, I worked on, and sent a patch to > fix the QtWebEngineProcess issue yesterday: > https://issues.guix.gnu.org/43249 > > My patch also fixes this issue, but without appending things to > PYTHONPATH. And it works just the same. > > Since you say, sir, that you copied the wrap-phase from Anki to fix the > issue, and I manually poked around with things, grepping the output of > `env` and stuff to deal with it - I wonder if I have stumbled upon the bare > minimum changes necessary to resolve this issue. > > I would like to request that you, and other esteemed contributors, test my > patch. And, if it seems good to you, I would like to request that you > incorporate my patch in this change set. > > Attached are the wrappers for `ebook-viewer`: with your patch applied, and > with my patch applied, for anyone to compare. > > Please do let me know if there are any insufficiencies in my solution, or > if it does not work for anybody else (I did use --pure option with `guix > environment`). > > Thank you > --000000000000b6bb5d05aeb0fa6c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I just realized that the PYTHONPATH set by the defaul= t %standard-phase 'wrap of python-build-environment is (most likely) a = superset of the manual PYTHONPATH set by the custom phase 'wrap phase a= dded after 'install in patch no. 4. As such, perhaps it is redundant, t= oo?

On Mon, Sep 7, 2020 at 8:56 AM Prafulla Giri <pratheblackdiamond@gmail.com> wrote:<= br>
Hey there Mr. Tildesley,

Withou= t knowing that this was going on, I worked on, and sent a patch to fix the = QtWebEngineProcess issue yesterday: https://issues.guix.gnu.org/43249
My patch also fixes this issue, but without appending things t= o PYTHONPATH. And it works just the same.

Since yo= u say, sir, that you copied the wrap-phase from Anki to fix the issue, and = I manually poked around with things, grepping the output of `env` and stuff= to deal with it - I wonder if I have stumbled upon the bare minimum change= s necessary to resolve this issue.

I would like to= request that you, and other esteemed contributors, test my patch. And, if = it seems good to you, I would like to request that you incorporate my patch= in this change set.

Attached are the wrappers for= `ebook-viewer`: with your patch applied, and with my patch applied, for an= yone to compare.

Please do let me know if there ar= e any insufficiencies in my solution, or if it does not work for anybody el= se (I did use --pure option with `guix environment`).

<= div>Thank you
--000000000000b6bb5d05aeb0fa6c--