From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IfHPOOiqYF8hLwAA0tVLHw (envelope-from ) for ; Tue, 15 Sep 2020 11:52:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KFqqMuiqYF/gXQAA1q6Kng (envelope-from ) for ; Tue, 15 Sep 2020 11:52:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CA399402C8 for ; Tue, 15 Sep 2020 11:52:08 +0000 (UTC) Received: from localhost ([::1]:58274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kI9VG-0008CK-Ks for larch@yhetil.org; Tue, 15 Sep 2020 07:52:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kI9VC-0008AZ-DI for guix-patches@gnu.org; Tue, 15 Sep 2020 07:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kI9VC-0004yH-4P for guix-patches@gnu.org; Tue, 15 Sep 2020 07:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kI9VC-000103-0W for guix-patches@gnu.org; Tue, 15 Sep 2020 07:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43249] Resent-From: Prafulla Giri Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Sep 2020 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Brendan Tildesley Cc: 43249@debbugs.gnu.org Received: via spool by 43249-submit@debbugs.gnu.org id=B43249.16001706743784 (code B ref 43249); Tue, 15 Sep 2020 11:52:01 +0000 Received: (at 43249) by debbugs.gnu.org; 15 Sep 2020 11:51:14 +0000 Received: from localhost ([127.0.0.1]:57452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI9UI-0000ym-Cq for submit@debbugs.gnu.org; Tue, 15 Sep 2020 07:51:14 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:54186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kI9UG-0000yI-9x for 43249@debbugs.gnu.org; Tue, 15 Sep 2020 07:51:05 -0400 Received: by mail-pj1-f47.google.com with SMTP id t7so1644779pjd.3 for <43249@debbugs.gnu.org>; Tue, 15 Sep 2020 04:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8dp96gIfpaoFnBPFgMaNe8CHtwy7TIZov++DAZ7k/Hk=; b=d8xlc4iwX5SxJJ3hZp3XzkEOkrUIpWrkb/WMtf/lGE/FAwXHG8Ah6nZHLIWTf6+MJc Pt1iE97GKRbUpsUBc3glXac9R2luStzulTnCponGAFXKdu3kbyaiXh8FArVuIFVrfZZX R+DFIctq8Rs6XM9cHZI6Icsr9Z25UwZMeRYGu1yPFUmdf/Rl/ZxP+mlqBIxK4MVAiECF 7I10Gnw6JKONf+dNSgHGkuqG9s2s7cip7NG1F9GBmVR9zD4XgXqxJg/yOjlM1gSf+CPt 0rqLX/9Tf6idBSfw5hNRaTMIOU5v2uMcNxYB8X9aLD56IDteU2PaNfmQKwSMT2mTxVO7 UY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8dp96gIfpaoFnBPFgMaNe8CHtwy7TIZov++DAZ7k/Hk=; b=P3T32ctVN9DrpOsrAE+LJ0qBdaka0bn1H/g3k8uvxfkM4cmO874714yohVEZExKWCB yv1hPrMNOE4wsbZEZZzVB1Mnob6dfdA1oOCWcOt5gXOqgDw5wMkWwI9wPHeO3+1ZEzqW tHWMM3+Fo1bioPJJf1hDsvN77A9AAettHdbVr1oCG9LIjhKcHEXn+lGRhTsFZJMvpBde X+sQN4hOf4dOHE2gScnBZsdSI96Su2r7grmpHeknVYM2JNW8+hX9/Z7bvs1vKzLW4vIV AyZZtEvE4mzhGfBj7XCiaf+i9+rTrob0viviM7SYF7ENLkk1cXuAsnjaBqcti8PxrvIR BE8w== X-Gm-Message-State: AOAM532eq2EWal8uksa3Yd8dSamWuu8viEfMjaExIKjZ2YiIUl2u/EzP eMPs8QJvGlYHIOfvym3g9CiH+aPaV/nDTqE0gVeIOJMvdy94uw== X-Google-Smtp-Source: ABdhPJxRNL2QhHyY17IEaFT5KOHfS3ZsYG34XWTuBFBcWEAQCWw3ipf077a+tUM5kWmHosTMVM/a9ADAo0syulv7fQ4= X-Received: by 2002:a17:90b:ecc:: with SMTP id gz12mr3580858pjb.219.1600170658391; Tue, 15 Sep 2020 04:50:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prafulla Giri Date: Tue, 15 Sep 2020 17:35:47 +0545 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ac6a7305af58c3c2" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=d8xlc4iw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: jwYqGui2f/3k --000000000000ac6a7305af58c3c2 Content-Type: text/plain; charset="UTF-8" Dear Mr. Tildesley, I have sent in a patch to do as you've suggested. https://issues.guix.gnu.org/43419 Thank you very much. I will remember this trick of not wrapping wrappers from now on. Thank you very much. On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley wrote: > On 8/9/20 10:22 pm, Prafulla Giri wrote: > > I see. > > Yes, it does make sense now why you chose to replace the 'wrap phase. > > I wonder.... perhaps it'd be better altogether if the (wrap-program) > procedure could be re-written to not make ..*.real.real programs...? That > would save us a lot of code-duplication... > > I have come to understand wrap-program a little better and I realised your > patch could have actually been fixed in a better way than I did. The issue > is with the part of your code that runs > > > (find-files "." ".*") > > > This is what matches all the .calibre-real files > If instead of that, it was: > > (find-files "." (lambda (file stat) (not (wrapper? file)))) > > or > > (find-files "." (lambda (file stat) (not (string-prefix "." (basename > file)))) > It should avoid double wrapping. An even simpler way would have been to > use (add-before 'wrap ..., instead of (add-after 'wrap ... > > If you are still interested, feel free to make a patch overwriting mine to > use this more correct method, instead of where i duplicated the wrap > PYTHONPATH bit. > > The fact that this happened is a bug though. I created some patches I > think fix this for core-updates. It would have made your original patch > error and force you to fix it: https://issues.guix.gnu.org/43367 > > --000000000000ac6a7305af58c3c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Dear Mr. Tildesley,

I have s= ent in a patch to do as you've suggested. https://issues.guix.gnu.org/43419

=
Thank you very much.

I will remember this tri= ck of not wrapping wrappers from now on. Thank you very much.

On S= un, Sep 13, 2020 at 6:28 PM Brendan Tildesley <mail@brendan.scot> wro= te:
=20 =20 =20
On 8/9/20 10:22 pm, Prafulla Giri wrote:
=20
I see.

Yes, it does make sense now why you chose to replace the 'wrap phase.

I wonder.... perhaps it'd be better altogether if the (wrap-program) procedure could be re-written to not make ..*.real.real programs...? That would save us a lot of code-duplication...

I have come to understand wrap-program a little better and I realised your patch could have actually been fixed in a better way than I did. The issue is with the part of your code that runs


(find-files "." ".*")


This is what matches all the .calibre-real files

If instead of that, it was:

(find-files "." (lambda (file stat) (not (wrapper? file)))= )

or

(find-files "." (lambda (file stat) (not (string-prefix &qu= ot;." (basename file))))

It should avoid double wrapping. An even simpler way would have been to use (add-before 'wrap ..., instead of (add-after 'wrap ...
If you are still interested, feel free to make a patch overwriting mine to use this more correct method, instead of where i duplicated the wrap PYTHONPATH bit.

The fact that this happened is a bug though. I created some patches I think fix this for core-updates. It would have made your original patch error and force you to fix it: https= ://issues.guix.gnu.org/43367


  





--000000000000ac6a7305af58c3c2--