From: Prafulla Giri <pratheblackdiamond@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#43198] Add breeze icon assets
Date: Tue, 8 Sep 2020 16:56:00 +0545 [thread overview]
Message-ID: <CAFw+=j0Nyv58hcC_6mtzeYt=wgETcPYyRKBj4acba4rgZaw5zg@mail.gmail.com> (raw)
In-Reply-To: <87a6y2rowu.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 3001 bytes --]
Mr. Courtes,
I have attached updated patches as per your review, sir.
Regarding the union-package `breeze`, it seems that `apt search breeze`
shows that there are packages like `breeze-icon-theme`,
`breeze-cursor-theme`, etc. and then there is one meta-package `breeze`.
Personally, as I am going to send in a patch for kdenlive that fixes the
breeze-icon-theme startup complaint issue, it'd make it easier if I could
just add the `breeze` union package. But I could probably define a union
input package in the (inputs ...) field.
On Mon, Sep 7, 2020 at 1:52 PM Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> Prafulla Giri <pratheblackdiamond@gmail.com> skribis:
>
> > Yes, sir. It seems that breeze-assets is licensed under GPL2 only (I
> > couldn't find "or any later version" in their license file:
> > https://github.com/KDE/breeze/blob/master/COPYING
>
> Section 9, reads:
>
> If the Program does not specify a version number of this License, you
> may choose any version ever published by the Free Software Foundation.
>
> In this case, we use ‘gpl2+’ as the license.
>
> > I am also concerned regarding the naming of the `breeze` package. I
> wonder
> > if that is a good name. But I can't quite think of any other name.
> > `kde-breeze`? `breeze-style`? I don't know... I worry that this name (if
> it
> > is not the most convenient) might get stuck once it is merged and other
> > packages start to build on top of it. I don't know.
>
> The general convention is to stick to the upstream name:
>
> https://guix.gnu.org/manual/en/html_node/Package-Naming.html
>
> Regarding the union package, perhaps we can actually leave it up to
> users to install both breeze-assets and breeze-icons if they want?
> After all, since these are separate packages upstream, we don’t have to
> provide a union of both. WDYT?
>
> > From 464358cc945eeb4ffcb46b3ddfc36ee8894e9378 Mon Sep 17 00:00:00 2001
> > From: Prafulla Giri <pratheblackdiamond@gmail.com>
> > Date: Fri, 4 Sep 2020 12:56:26 +0545
> > Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets
> >
> > * gnu/packages/kde-frameworks.scm (breeze-assets): New variable.
>
> [...]
>
> > +(define-public breeze-assets
> > + (package
> > + (inherit breeze-icons)
> > + (name "breeze-assets")
> > + (version "5.19.5")
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append
> > + "https://codeload.github.com/KDE/breeze/tar.gz/v"
> > + version))
> > + (sha256
> > + (base32
> > +
> "12ffrm0nrhi2avq2z7jx3pdp0zgsxsary7gpfp60vvxs1jrvnk1b"))))
>
> Could you change the URL to a mirror://kde URL?
> <
> https://github.com/archlinux/svntogit-packages/blob/packages/breeze/trunk/PKGBUILD
> >
> shows that the official tarballs can be obtained from kde.org.
>
> With these last changes, we should be all set!
>
> Thanks,
> Ludo’.
>
[-- Attachment #1.2: Type: text/html, Size: 4317 bytes --]
[-- Attachment #2: 0001-gnu-kde-frameworks-Add-breeze-assets.patch --]
[-- Type: text/x-patch, Size: 2169 bytes --]
From 8096401f6f977cf48b66914e161da0efd124931e Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Fri, 4 Sep 2020 12:56:26 +0545
Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets
* gnu/packages/kde-frameworks.scm (breeze-assets): New variable.
---
gnu/packages/kde-frameworks.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a1abd7d46c..e0b5e8d06e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -57,6 +57,7 @@
#:use-module (gnu packages gstreamer)
#:use-module (gnu packages image)
#:use-module (gnu packages kerberos)
+ #:use-module (gnu packages kde-plasma)
#:use-module (gnu packages libreoffice)
#:use-module (gnu packages linux)
#:use-module (gnu packages mp3)
@@ -325,6 +326,36 @@ It is the default icon theme for the KDE Plasma 5 desktop.")
;; text.
(license license:lgpl3+)))
+(define-public breeze-assets
+ (package
+ (inherit breeze-icons)
+ (name "breeze-assets")
+ (version "5.19.5")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "mirror://kde/stable/plasma/" version
+ "/breeze-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0dpk1w7zcafrzf46j060i1qb0fwqpsflkfzr6gcar81llmjnc4b1"))))
+ (inputs
+ `(,@(package-inputs breeze-icons)
+ ("ki18n" ,ki18n)
+ ("kpackage" ,kpackage)
+ ("kguiaddons" ,kguiaddons)
+ ("kdecoration" ,kdecoration)
+ ("kcoreaddons" ,kcoreaddons)
+ ("kiconthemes" ,kiconthemes)
+ ("kwindowsystem" ,kwindowsystem)
+ ("kconfigwidgets" ,kconfigwidgets)
+ ("qtx11extras" ,qtx11extras)))
+ (home-page "https://github.com/KDE/breeze")
+ (synopsis "Artwork, styles and assets for the Breeze visual style")
+ (description "This package contains artwork, styles and assets associated
+with the Breeze visual style.")
+ (license license:gpl2+)))
+
(define-public kapidox
(package
(name "kapidox")
--
2.28.0
[-- Attachment #3: 0002-gnu-kde-frameworks-Add-breeze.patch --]
[-- Type: text/x-patch, Size: 1964 bytes --]
From b7d4e572923a98cc4ff266e95a3bd247556fb834 Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Fri, 4 Sep 2020 12:59:28 +0545
Subject: [PATCH 2/2] gnu: kde-frameworks: Add breeze
* gnu/packages/kde-frameworks.scm (breeze): New variable.
---
gnu/packages/kde-frameworks.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index e0b5e8d06e..fc1bfeba30 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -27,6 +27,7 @@
(define-module (gnu packages kde-frameworks)
#:use-module (guix build-system cmake)
#:use-module (guix build-system qt)
+ #:use-module (guix build-system trivial)
#:use-module (guix download)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (guix packages)
@@ -356,6 +357,32 @@ It is the default icon theme for the KDE Plasma 5 desktop.")
with the Breeze visual style.")
(license license:gpl2+)))
+(define-public breeze
+ (package
+ (name "breeze")
+ (version (package-version breeze-assets))
+ (source #f)
+ (build-system trivial-build-system)
+ (arguments
+ `(#:modules ((guix build union))
+ #:builder
+ (begin
+ (use-modules (ice-9 match)
+ (guix build union))
+ (match %build-inputs
+ (((names . directories) ...)
+ (union-build (assoc-ref %outputs "out")
+ directories)
+ #t)))))
+ (inputs
+ `(("breeze-icons" ,breeze-icons)
+ ("breeze-assets" ,breeze-assets)))
+ (home-page "https://github.com/KDE/breeze-icons")
+ (synopsis "Full Breeze Theme")
+ (description "The full Breeze visual style: a union-build of
+breeze-assets and breeze-icons.")
+ (license (list license:gpl2 license:gpl3+))))
+
(define-public kapidox
(package
(name "kapidox")
--
2.28.0
next prev parent reply other threads:[~2020-09-09 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 8:22 [bug#43198] Add breeze icon assets Prafulla Giri
2020-09-04 9:29 ` Ludovic Courtès
[not found] ` <CAFw+=j2GyvfVWw-qsR1ju4+CEVAzhfP7p6hociAfF1YcBDOuSg@mail.gmail.com>
2020-09-04 11:00 ` [bug#43198] Fwd: " Prafulla Giri
2020-09-07 8:06 ` Ludovic Courtès
2020-09-08 11:11 ` Prafulla Giri [this message]
2020-09-08 11:25 ` [bug#43198] Fwd: " Prafulla Giri
2020-09-09 7:26 ` bug#43198: " Ludovic Courtès
2020-09-09 8:27 ` [bug#43198] " Prafulla Giri
2020-10-26 19:07 ` [bug#43198] Questions about "Add breeze icon assets" Hartmut Goebel
2020-10-27 4:35 ` Prafulla Giri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFw+=j0Nyv58hcC_6mtzeYt=wgETcPYyRKBj4acba4rgZaw5zg@mail.gmail.com' \
--to=pratheblackdiamond@gmail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.