From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manolis Ragkousis Subject: Fwd: [PATCH] gnu: hurd: Add Hurd Minimal. Date: Mon, 26 May 2014 08:24:54 +0000 Message-ID: References: <87y4xq4vr2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoqDJ-0006eB-Rn for Guix-devel@gnu.org; Mon, 26 May 2014 04:24:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoqDI-000268-Nz for Guix-devel@gnu.org; Mon, 26 May 2014 04:24:57 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel@gnu.org >> + (outputs '("out")) > > Can be omitted (it=E2=80=99s the same as the default value.) > Removed it. >> + (arguments >> + `(#:out-of-source? #t >> + #:phases (alist-replace >> + 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out"))) >> + ;; We need to copy libihash.a to the output folder= manually, >> + ;; since there is no target for that in the makefi= le >> + (copy-recursively "libihash" >> + (string-append out "/libihash")) > > This creates > /gnu/store/.../libihash/{libihash.a,Makefile,ihash.c,ihash.o,...}. Is > it really what=E2=80=99d intended? > > I would expect that the intent is to create > /gnu/store/.../{lib/libihash.a,include/ihash.h}, no? > I will create two folders, lib with libihash.a and include with ihash.h. What do you think? >> + (lambda* (#:key inputs source #:allow-other-keys) >> + (let ((glibc (assoc-ref inputs "glibc-hurd-headers= "))) >> + (zero? (system* "autoreconf" "-vif")) >> + #t)) > > Can be simplified to: > > (lambda _ > (zero? (system* "autoreconf" "-vfi"))) > Simplified. > Please add a line or two in the patch saying what it does, and linking > to the original discussion. > ok, I will place a link with the discussion from bug hurd and explain what it does. >> ++if test "x$cross_compiling" =3D "xyes"; then >> ++ # It may be that we don't have a working libc yet, for instance >> ++ # because we're bootstrapping the cross-compilation tool chain. >> ++ # Thus, use this undocumented Autoconf macro designed for this. >> ++ AC_NO_EXECUTABLES >> ++ echo done >> ++fi > > I gather that this works as advertised, but could you confirm by > replying to > ? > That would allow us to push the patch upstream. > I had to put one more line after AC_NO_EXECUTABLES, otherwise it would fail= with > syntax error near unexpected token `fi'. Other than that it works. I will confirm there. >> +-# Check for Sun RPC headers and library. >> ++# Check only for Sun RPC headers. We do not need the library yet. >> + AC_CHECK_HEADER([rpc/types.h], [HAVE_SUN_RPC=3Dyes], [HAVE_SUN_RPC=3Dn= o]) >> +-AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=3Dno]) >> ++# AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=3Dno]) >> + AC_SUBST([HAVE_SUN_RPC]) > > What=E2=80=99s the problem that=E2=80=99s addressed here? It tries to link with a library in glibc (which at that point doesn't yet exist ), but it cant because of the AC_NO_EXECUTABLES flag saying that linking is not allowed after this flag is passed. So I am just disabling the test, = to get the job done. Thanks, Manolis