From: Manolis Ragkousis <manolis837@gmail.com>
To: Guix-devel <Guix-devel@gnu.org>
Subject: [PATCH] gnu: base: Disable bogus code in Hurd's glibc.
Date: Fri, 31 Jul 2015 19:17:33 +0300 [thread overview]
Message-ID: <CAFtzXzNsmH-SbyEzr--DUuP-TZGgNa+53beSRqkmWV8EB=r-qg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
This patch solves the issue I had with building perl natively on Hurd. It seems
PAGE_COPY_THRESHOLD was causing a not properly tested PAGE_COPY_FWD_MAYBE
to be used, which caused the error "miniperl: memmove.c:72: memmove:
Assertion `len == 0' failed."
OK to apply to wip-hurd?
Manolis
[-- Attachment #2: 0001-gnu-base-Disable-bogus-code-in-Hurd-s-glibc.patch --]
[-- Type: text/x-patch, Size: 1783 bytes --]
From b4ea96e2b8b5c6e8dcfff9d46ccb9f963d338c7d Mon Sep 17 00:00:00 2001
From: Manolis Ragkousis <manolis837@gmail.com>
Date: Fri, 31 Jul 2015 19:08:39 +0300
Subject: [PATCH] gnu: base: Disable bogus code in Hurd's glibc.
* gnu/packages/patches/glibc-hurd-libs.patch: New patch.
---
gnu/packages/patches/glibc-hurd-libs.patch | 31 ++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/patches/glibc-hurd-libs.patch b/gnu/packages/patches/glibc-hurd-libs.patch
index 2102f77..73e1e99 100644
--- a/gnu/packages/patches/glibc-hurd-libs.patch
+++ b/gnu/packages/patches/glibc-hurd-libs.patch
@@ -41,3 +41,34 @@ Index: eglibc-2.18/sysdeps/generic/symbol-hacks.h
asm ("memset = __GI_memset");
+# endif
#endif
+
+We need to disable this, or else memmove will not work properly in Hurd's glibc.
+
+From 69f807d6a4afa43e7a596e04f22923567b235ce9 Mon Sep 17 00:00:00 2001
+From: Samuel Thibault <samuel.thibault@ens-lyon.org>
+Date: Wed, 29 Jul 2015 10:34:01 +0200
+Subject: [PATCH] Disable the fix for now, the resulting code seems bogus
+
+---
+ .topmsg | 11 +++++++++++
+ sysdeps/mach/pagecopy.h | 3 +++
+ 2 files changed, 14 insertions(+)
+
+diff --git a/sysdeps/mach/pagecopy.h b/sysdeps/mach/pagecopy.h
+index 29b73ce..9d1f4de 100644
+--- a/sysdeps/mach/pagecopy.h
++++ b/sysdeps/mach/pagecopy.h
+@@ -20,7 +20,10 @@
+
+ /* Threshold at which vm_copy is more efficient than well-optimized copying
+ by words. This parameter should be tuned as necessary. */
++#define PAGE_THRESHOLD (16384) /* XXX Tune this. */
++#if 0
+ #define PAGE_COPY_THRESHOLD (16384) /* XXX Tune this. */
++#endif
+
+ #define PAGE_SIZE __vm_page_size
+ #define PAGE_COPY_FWD(dstp, srcp, nbytes_left, nbytes) \
+--
+2.4.6
+
--
2.4.6
next reply other threads:[~2015-07-31 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 16:17 Manolis Ragkousis [this message]
2015-07-31 18:38 ` [PATCH] gnu: base: Disable bogus code in Hurd's glibc Mark H Weaver
2015-07-31 19:21 ` Manolis Ragkousis
2015-07-31 19:51 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFtzXzNsmH-SbyEzr--DUuP-TZGgNa+53beSRqkmWV8EB=r-qg@mail.gmail.com' \
--to=manolis837@gmail.com \
--cc=Guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.