From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EA6DGAXN+GS9xgAAauVa8A:P1 (envelope-from ) for ; Wed, 06 Sep 2023 21:03:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EA6DGAXN+GS9xgAAauVa8A (envelope-from ) for ; Wed, 06 Sep 2023 21:03:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15B4762DF2 for ; Wed, 6 Sep 2023 21:03:33 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=k6OgQfbj; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694027013; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=11Yjqu8nvaLozKAR7Tjq8vtY0gg4L/7jGWLNEWMSxpA=; b=EuAMXp1++cz7lJzNpgWZRu+aDMGBcUSkyb1gYA8XFCLbPUSjEJB/f4TuKGqoM+8pdGH+vo ga291FaVbXt4IhFFNalgvEFZUjRACepWgZAuDv28u+xxuvMUHyIH7pIu7ptM9nHLLLO2IP I67Fh6qlAdT5UYz8aFnWoHzmdnp3onCBFalxPDTupppEwUZYfLZM46r3iu9zSNd8HByF0N ZMXI5ZvSeX+Q+OqJb4M8VRTj4NIg+ru2V7yoIei49HivTIzvzQfQT+6f/V8wdILp+rn4bP Xyib22I+CfZLEHRl9UdO1DgiZLfSNN1pH5IeYVHAqXBMyLxf73B0yp5Se8MZFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=k6OgQfbj; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694027013; a=rsa-sha256; cv=none; b=deMyIbVoXFV66NRR35og8h8SeIbWkbte4MHo/UPe9tMd8v/kparVt1x5SKB2D5++AdYbBI o8sxJfEyNro3hcBdl99gD9CM2aOdTwtUwaEosHoVbkl7v+1aMqv9qw3WQrdiM4zrdpNq9p IurHu/Xwq0KCyWO0Xoz5jgTU5db0O7KtLNwqvxsZaqYucQCaK/s8cqr7s/YPItePlFqc2I vo8MKY/UyuQ4GTXj3+T8dSoxj0aGbyetyXyDs0p3lIHvQ7tQVoNI3GrE5WRdW/MPfaRBbZ Hm8vFMChY+D4jIOaLmESd+EiKE62TkjlIgwBNT0qJeapGLuq/tL0Z05eDddRRQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdxna-0006bF-Bc; Wed, 06 Sep 2023 15:02:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdxnR-0006Qr-FJ for guix-devel@gnu.org; Wed, 06 Sep 2023 15:02:41 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qdxnN-0008ID-Rc for guix-devel@gnu.org; Wed, 06 Sep 2023 15:02:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=11Yjqu8nvaLozKA R7Tjq8vtY0gg4L/7jGWLNEWMSxpA=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=k6OgQfbj4D9+mD+LZIUVW2muYm2yR3EY3uSsH39B WI36i20pRI9eqXU+g/lKACDnVlw2yuHdAKHkzYit63hXxM1hCPKwC+RSegE5OdgJlEO5FB L16693ndSMbmq739xDNgVX15ntqhVP7DkyFOlxJpOtdxuI8bhNRc4CH7/cx9E= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 55ec44af (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Wed, 6 Sep 2023 19:02:29 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-500b0f06136so193078e87.0 for ; Wed, 06 Sep 2023 12:02:28 -0700 (PDT) X-Gm-Message-State: AOJu0YxgvRXZeLTQ+RFxzLsoH0ud0fc0pS8Wx1iv6zRa9EqNxbtZoyHy 4j4k4/l+tg18lUPdol2YR/ZArfM1CpN+lfo4zrw= X-Google-Smtp-Source: AGHT+IGT5whVRmjnxEh6MKRraX6ZrRLuXSXpe6WlBuyML2vNGyZyuZlkTU5/kHv+YCfwR9aqf7cALqLsJvjerRkhoy4= X-Received: by 2002:a05:6512:3702:b0:4fe:25bc:71f5 with SMTP id z2-20020a056512370200b004fe25bc71f5mr2913007lfr.11.1694026946952; Wed, 06 Sep 2023 12:02:26 -0700 (PDT) MIME-Version: 1.0 References: <87o7ifb66o.fsf@cbaines.net> <87jzt3b0yn.fsf@cbaines.net> In-Reply-To: <87jzt3b0yn.fsf@cbaines.net> Date: Wed, 6 Sep 2023 12:01:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Process for reviewing patches as someone without commit access To: Christopher Baines Cc: guix-devel@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@lease-up.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner From: Felix Lechner via "Development of GNU Guix and the GNU System distribution." Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 15B4762DF2 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -4.57 X-Spam-Score: -4.57 X-TUID: IsnZi1j1dzVp Hi Chris, On Wed, Sep 6, 2023 at 11:39=E2=80=AFAM Christopher Baines wrote: > > I don't want to make reviewing changes more difficult, and I think > setting up more people with commit access and continuing the trend that > it's mostly people with commit access that review changes would increase > the difficulty, compared to what I'm proposing here, which is trying to > empower people who just do review whilst avoiding any of the complexity > of merging and pushing the changes without breaking things. Usually, helpful reviews come from people with more experience. In your system they come from folks with less. That seems upside down to me. More significantly, work gets done faster when people are motivated. A junior committer who is about to push a change will be much more eager to find an experienced reviewer. It's a way to demonstrate knowledge. The reviewer's testimony will eventually help the contributor attain a higher level. In other words, there is no empowerment in "just do[ing] a review". Kind regards Felix