From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UGsODuTic2RYeQAASxT56A (envelope-from ) for ; Mon, 29 May 2023 01:25:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6HqtDeTic2TrqAAAauVa8A (envelope-from ) for ; Mon, 29 May 2023 01:25:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DDD623BEF2 for ; Mon, 29 May 2023 01:25:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3Pl3-00038g-7m; Sun, 28 May 2023 19:25:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3Pl1-00038Y-0m for guix-patches@gnu.org; Sun, 28 May 2023 19:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3Pl0-0007JL-OG for guix-patches@gnu.org; Sun, 28 May 2023 19:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3Pl0-0006J8-8c for guix-patches@gnu.org; Sun, 28 May 2023 19:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63508] [PATCH v2 4/4] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 May 2023 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 63508@debbugs.gnu.org Received: via spool by 63508-submit@debbugs.gnu.org id=B63508.168531626024185 (code B ref 63508); Sun, 28 May 2023 23:25:02 +0000 Received: (at 63508) by debbugs.gnu.org; 28 May 2023 23:24:20 +0000 Received: from localhost ([127.0.0.1]:56108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3PkJ-0006I0-SR for submit@debbugs.gnu.org; Sun, 28 May 2023 19:24:20 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:39646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3PkI-0006Hr-9b for 63508@debbugs.gnu.org; Sun, 28 May 2023 19:24:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=1yCXP2JveUQegx+ y47v//+dHkKfbiQbCKhvEWixnkLw=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=JAiLrz5ogP3MH5uYgaA+UQVbBahNdYlFw9Tlahym RqfysM71uEI7CXI3Qp0sdiKDT/5FCIgjLQ4po+WAwP2mhjIktRb/5X41OsmFzQLBdSmsK0 wpcNkC/D0IZn9B0v3U86x/4SBG6mW76o8DnfwBwC3ucdtx91QRTQ8xpZd21BM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 031624b5 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <63508@debbugs.gnu.org>; Sun, 28 May 2023 23:24:16 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f3ba703b67so2858206e87.1 for <63508@debbugs.gnu.org>; Sun, 28 May 2023 16:24:15 -0700 (PDT) X-Gm-Message-State: AC+VfDxkvfxGx0FPrVmbn/Fjmp6heGIDJZuW+UrTQ8uh8n9ncnrM05h6 3Pt+vtOT7IGKGQt3uPZ64hx5qfGGDA9Fs8eycRo= X-Google-Smtp-Source: ACHHUZ7dj6ln4yhaKSUaWqkxQViWAg/vzE4pbJQsqC/ACi5vcfaI8fxv6pm4JNJZevRAT2D5j2AOqXnUb0JM+Bt8OHM= X-Received: by 2002:a19:c50b:0:b0:4ed:bfcf:3109 with SMTP id w11-20020a19c50b000000b004edbfcf3109mr2921523lfe.56.1685316254071; Sun, 28 May 2023 16:24:14 -0700 (PDT) MIME-Version: 1.0 References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@lease-up.com> In-Reply-To: Date: Sun, 28 May 2023 16:23:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches From: Felix Lechner via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685316324; a=rsa-sha256; cv=none; b=krR4g23MQ2A0a9ur5fpLC5dB9Eb/veLvhlJm+434+2i8w0Co7vA/ixpyvjZ9fL8jzehW9m +ie9b3heNHrl4QTXrKr66r+FsVaFAg6Cp2GPrGtM75zAsj8dZtjddA/6v8ur5dCwe4JAuC ZsqAKFq3ejWnrZ07pAEbUSxqgZabJ8LUx4WKyTM+gaTH7l2ZErbzvA6OtWIFIC6ForFqvi MnKdNojVGRCdkLA4gTjV7f2UITGUhu5UAfHJ8DhZky4vTUK7Uuylzm+Qidy+EaebzNTh7M uuz5nid0J38ARaIG4109lhGflId8lAqX0/8PIA2iUbf5LHBOm2wzCR5NfZxaHg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=JAiLrz5o; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685316324; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=1yCXP2JveUQegx+y47v//+dHkKfbiQbCKhvEWixnkLw=; b=uE25pktyIoiUbCgmf/gl8WGlPhx7IEAg6UYKzZkBXAHSTlh2uzL3Cn3kuPmC5hP7qmczcQ Syo/dNdQTBoSGd3rTdqdoD/eBCPtO5v+HcQHEVXxFr6g4futdflekKYPV3Kb2OZzoQMy27 dLcZaJnzPnt9/oZR1QfHIJS4fAsZaZjzCfLaxdG6r/3KmRPO4UuLoRyUyQVxwcfDeNQWyv JrOGyrUPjywr2cDPNxKLR1miIe8FENaE+JvvJ4zzFuknbOfmsAlCCTjnYJJeZ1shHJExyD VpZS+bi6Z0uaN2MMEobfTavAsOPi94JCGIddqIEbBYPMTQAAXHHBzq4U45Rd/g== X-Migadu-Spam-Score: -2.95 X-Spam-Score: -2.95 X-Migadu-Queue-Id: DDD623BEF2 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=JAiLrz5o; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: B22OLoGr2GzH Hi Liliana, Thank you for your kind review! I will push a new version with squashed commits you requested shortly. While I am new to Guix, I am not sure that Gexp conversions fall under "style changes" in my book. I believe they are considerably more complex, and fraught with greater error. On Wed, May 17, 2023 at 9:19=E2=80=AFPM Liliana Marie Prikler wrote: > > you may object that > this doesn't mention /etc/udev/rules.d and thus could be problematic on > foreign distributions, but I argue that you probably shouldn't mess > with foreign udev anyway, and if you do that setting > EUDEV_RULES_DIRECTORY is appropriate. The intent of my patch was not to mention /etc/udev/rules.d explicitly, but rather to replace the store folder that holds the upstream rules, which we are currently using, with the one Guix constructs in order to use rules from other places. That just happens to be /etc/udev/rules.d as well. On that note, my patch is not suitable for upstream because it hardcodes the location to the runtime path in Guix. Other distributions may keep them in a different place. The current Autoconf setup probably works well for them. Either way, udevadm in Guix is currently broken. This patch fixes it and should please be accepted. Thanks! As noted elsewhere [1] I am separately working on an update to eudev 3.2.12 but that will require more testing locally before I can send it in. Kind regards Felix [1] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00217.html