From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eEMcLYbC+GT7egEA9RJhRA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 20:18:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eEMcLYbC+GT7egEA9RJhRA (envelope-from ) for ; Wed, 06 Sep 2023 20:18:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D30CA4391A for ; Wed, 6 Sep 2023 20:18:45 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=q9RPOc4J; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694024326; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=tZ8cFTKLXgvVu9FnlIfQfWmOx041ZjPZdYsojd4xGQQ=; b=E1z/wil5jAQHOQkEDjMX7I/lJcGIVcHspBeBjhHSPag0pwmIvJI1TZunC1W6dhFL9hLsdf ZbzR1X3yV2Ky1/Z3HQzX9QjJsTuHgB4wMShgk3GyjCuHR/8/4s6ok7AoOqhts5pYU6AWCR sVsAuSpX5tCKkRa5rFrAKgVo00NAXrawNWkt3TfYC4XJcDYV5PQFJEcco90RFIRT3ToNoy o1IpC60J8oMHM88bSiSxx9HraK+OiIY7l08huztVCwwbRMGAwD1DLHW66K/GldoJxHfFqm 3EaKLIs6L62sEfcchSOKRFacPLJOTOCYnMbdJrjxp5peb4JYxXvib+OkfIGVkg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694024326; a=rsa-sha256; cv=none; b=BtEASDzbrNToF03+DdsveWCxILgCZM30y5rgdkxL8mtDEq32E67gEoM9TC6/iVvC+aE1Gr umzzKT1fWbzEQPx0/0y51+qJa+dtI2rCPs1NYEeXdBX1SnpauGQ90m83IwGk1mTipPclTP WIBMFgNm+RwsS8udK8ByHBHmnW3s61q/EuG0Ushs1mPWHsaSHVZ4okfuX5XBWO5U7cCUz5 0Qr+42i6S7p9104Md1oFOzye0atVlzDkRG/hiy63gxrTwS0rvDT2Q+a515xRpwd9cjgnvh WVrEnljNnQKPgIBET+5ux/vV0g11dmmqddkGUtL+5dOEYfQve5ux+/kdl0SJCQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=q9RPOc4J; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdx6P-0006tu-Rh; Wed, 06 Sep 2023 14:18:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdx6J-0006gE-Vw for guix-devel@gnu.org; Wed, 06 Sep 2023 14:18:04 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qdx6C-0006cF-53 for guix-devel@gnu.org; Wed, 06 Sep 2023 14:18:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=tZ8cFTKLXgvVu9F nlIfQfWmOx041ZjPZdYsojd4xGQQ=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=q9RPOc4Jdi/N9gdUYS89R3vSJ6BcRRTvjBPBb2Yi qRw+97AbLCF1hMKLpu7/363wW9fykbfKETeAqvaOh0OAN+WB7MgJzHBVaCRcnuUgZWmxZx 6PxPksrLpwyrkFh0BPezTYLpwWtPKVBgjkTExlL/d3hHKFqUJlFZVjiOFZxcE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 6dd26031 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Wed, 6 Sep 2023 18:17:52 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-500a398cda5so129804e87.0 for ; Wed, 06 Sep 2023 11:17:52 -0700 (PDT) X-Gm-Message-State: AOJu0YzE5uxiM02cUXPZXOX++DIV8zOkkG3Xy3lY7oBabeuvO3IZfFlh zO5FZM3HVCB/iEgqhNArQbbbpzgLQEKh7GNTais= X-Google-Smtp-Source: AGHT+IEWQSnzQobGMp5kfSv9JQ5dcPC+uua2V1xcmX0NEn7Vwhd7ERt/qxdeVBOpPZWLshFFClUVsH+mD37biYqOewY= X-Received: by 2002:a05:6512:34d0:b0:500:7c2a:30da with SMTP id w16-20020a05651234d000b005007c2a30damr2691002lfr.60.1694024270344; Wed, 06 Sep 2023 11:17:50 -0700 (PDT) MIME-Version: 1.0 References: <87o7ifb66o.fsf@cbaines.net> In-Reply-To: <87o7ifb66o.fsf@cbaines.net> Date: Wed, 6 Sep 2023 11:17:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Process for reviewing patches as someone without commit access To: Christopher Baines Cc: guix-devel@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@lease-up.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner From: Felix Lechner via "Development of GNU Guix and the GNU System distribution." Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -6.72 X-Migadu-Queue-Id: D30CA4391A X-Migadu-Spam-Score: -6.72 X-TUID: 1UZxQCuLHlgu Hi Chris, On Wed, Sep 6, 2023 at 9:47=E2=80=AFAM Christopher Baines wrote: > > Maybe we can use debbugs tags for this? Instead of pushing people into reviews and then again making the same committers a bottleneck, I would offer some entry-level contributors commit rights but require that they obtain approval for some steps. It can be done on a trust basis. That way, you can train a new generation of committers while getting the work done. Advancing to a higher level requires a majority approval of the maintainer collective. Same for revocations. *** Contributor levels *** 1. Add new packages or fix documentation. This simple activity focuses on fitness of software for Guix, including licensing. Finding a good place in the file tree is also part of this job. Sign off required. Novice levels, all require review by someone with a higher level 2. Update existing packages. Here, a contributor must be aware of how updates affect consuming packages. Ideally, this activity would include knowledge of CI, including the pre-compilation of all consumers in order to avoid build failures before the change is committed. No new inputs or phases. Hash updates only. 3. Modify inputs and build phases. Requires the mastery of G-Expressions and a detailed knowledge of the particular build system involved. 4. Rename package variables or change inheritance. This is for experts in tool chains like Golang, or a technology like Emacs. Intermediate levels: 5. Add new services 6. Edit existing services (after review) 7. Change Guix records outside of services, for example for operating-system (after review). https://lepiller.eu/en/a-deep-dive-into-guix-records.html Advanced levels 8. Modify command-line behavior of the Guix executable (after review) 9. Change the Guix daemon (after review) Black belt 10. No restrictions, and no reviews or approvals needed. Kind regards Felix