From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +CIGG0oUdWS4HwAASxT56A (envelope-from ) for ; Mon, 29 May 2023 23:08:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wBc6G0oUdWS6IAEAauVa8A (envelope-from ) for ; Mon, 29 May 2023 23:08:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 059F418466 for ; Mon, 29 May 2023 23:08:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3k62-0003Yh-Lg; Mon, 29 May 2023 17:08:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3k5y-0003YQ-T9 for guix-patches@gnu.org; Mon, 29 May 2023 17:08:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3k5y-00018j-LH for guix-patches@gnu.org; Mon, 29 May 2023 17:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3k5x-0000FL-MF for guix-patches@gnu.org; Mon, 29 May 2023 17:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63508] [PATCH v4 2/2] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 May 2023 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 63508@debbugs.gnu.org, Liliana Marie Prikler Received: via spool by 63508-submit@debbugs.gnu.org id=B63508.1685394430869 (code B ref 63508); Mon, 29 May 2023 21:08:01 +0000 Received: (at 63508) by debbugs.gnu.org; 29 May 2023 21:07:10 +0000 Received: from localhost ([127.0.0.1]:59345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3k58-0000Dx-1t for submit@debbugs.gnu.org; Mon, 29 May 2023 17:07:10 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:59698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3k55-0000Do-TF for 63508@debbugs.gnu.org; Mon, 29 May 2023 17:07:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=+DAFuEbTLSh7oyz XwTejC52wMQyJGCXsw8pq/t9K5so=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=dtqwb+vRQm1q5nLObl7XAyVbPzVIJnREcg+ljBqZ q7KyLDmpX8XC/1Ow4By+VQh6Rkz4wfBQ4HXeUPkzuXK2746R26BRD2+HP8rmMgTDQYj7fH 4Gp5Z6GvFESGX0rLrPxDYtJmZ04x819ACIOFrB8kXk8cqXF9lLfZPlE8/J6UE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 6f5f53e3 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <63508@debbugs.gnu.org>; Mon, 29 May 2023 21:07:06 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f004cc54f4so4141989e87.3 for <63508@debbugs.gnu.org>; Mon, 29 May 2023 14:07:05 -0700 (PDT) X-Gm-Message-State: AC+VfDzfwrkTUaNROQNsY4WXhDax0taXtMWCwE0SxVpUpFgty7XSY0XY TGUOeVLy+D737Sh321uE9LPUDOyXoFKDuMjNxPM= X-Google-Smtp-Source: ACHHUZ6l4XLGgTSd7LAY+ahN+S2NBuLLu8TbDhEQ2jQGWQxOJz8tgfANQrZWJ1VbP/4ZAozlJccvpXybvneI2utU1/A= X-Received: by 2002:ac2:5298:0:b0:4f1:5010:4b34 with SMTP id q24-20020ac25298000000b004f150104b34mr4624944lfm.18.1685394422407; Mon, 29 May 2023 14:07:02 -0700 (PDT) MIME-Version: 1.0 References: <2d51ddd4e6865a40a15b8f7948d2479952571a4e.1685379443.git.felix.lechner@lease-up.com> <5543a014-6ace-f212-0dc2-046ef9e99086@makinata.eu> In-Reply-To: <5543a014-6ace-f212-0dc2-046ef9e99086@makinata.eu> Date: Mon, 29 May 2023 14:06:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches From: Felix Lechner via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685394506; a=rsa-sha256; cv=none; b=iBKF4p8PULvv9CPPo2TGGVc7NPG2phvFjHl2b3F0B0Bzgz4oqlFokCTm90HPy+QYt3hfSu zGvArCkMsy8dMIc0yLNpwHjMymywkPjDUlxjULQW9OKsnBMyWMskWSwp8NL+7yEE10vGqM vJSaskpCMf/Fxj3LsdjiW5qoaBCcCnij5mZUD4UlJP6s2mVsLKtlNqqMabxNUugMonJ77l 4BanafTbNvxt0BPjkPKCWorE8I0+TsEoIqGW0N2D5MBvonrWk02i6KfNtQBzgRlYS/6b0q WY8JHMXc+uP4dcEZMTE7Ybj8LXvEkn6mxeWmmDsGTHhrpqTQUF6cEDyLMq5lwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=dtqwb+vR; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685394506; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+DAFuEbTLSh7oyzXwTejC52wMQyJGCXsw8pq/t9K5so=; b=ADKT8ZywcIiUrRiaRyDzE9F5PSNNC7kLHS+lGfKtQT+8LRVEi6/WeTnGUW4XY62W0YNg2M rmuu3TlraI2libMzYXjG9VW+snl/DIQYRXClbWLng30Ml882IRqkptxw40GzOlbQ1ksNJe ZDIzWOxv8prK1scVXonE2bKFGKiA0YLCEYfYyHWnUbnUREPWlB283A12qKjWP8S0gBcPR1 9A1oIcIJllNnJWTNj2GxcrJCg26dFqzOIXP58nR/9FXlzvVy1F6jhvfoWW//Uj5Xk3l0+s 7DzB4lpHCYcmZid5umHyQey3oA+JoXTnkGYG6Dgk78l7NJ7TlNr9/wENTbOdqg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=dtqwb+vR; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.64 X-Spam-Score: -3.64 X-Migadu-Queue-Id: 059F418466 X-TUID: KVtUGWxpU2be Hi Bruno, On Mon, May 29, 2023 at 1:28=E2=80=AFPM Bruno Victal wr= ote: > > Perhaps instead of substituting, can you check if > #:configure-flags or #:make-flags could be used instead? Thank you for that suggestion! I did, and I do not believe it is possible to specify a separate runtime path for udevadm via ./configure at this time. It would be possible to add a second variable in configure.ac [1] and use that in the relevant Makefile.am. [2] The change would get picked up for the runtime search path throughout [3] and for the inotify watch in udevd. [4] In that scenario, it would be crucial not to modify the installation directory that was specified via the variable prefix "udevrules_" in several Makefiles.am, [5][6][7] which use Automake's "uniform" naming scheme that leaves off 'dir'. [8] Unfortunately, for most distros the distinctions are meaningless, and perhaps even incomprehensible. I estimated the chance of upstream acceptance as low. After some reflection, it was easier to patch the runtime path directly in the lone place that matters to Guix. [2, again] I also do not see how the second variable needed can be introduced by invoking 'make' in a different way. Please let me know if you find a way. Thanks! Kind regards Felix [1] https://github.com/eudev-project/eudev/blob/0a4dae19c1a191c8054fc2b9c2d= 592e797715a69/configure.ac#L180 [2] https://github.com/eudev-project/eudev/blob/0a4dae19c1a191c8054fc2b9c2d= 592e797715a69/src/udev/Makefile.am#L10 [3] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/src/udev/udev-rules.c#L53 [4] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/src/udev/udevd.c#L1306 [5] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/rules/Makefile.am#L9 [6] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/rules/Makefile.am#L35 [7] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/rule_generator/Makefile.am#L12 [8] https://www.gnu.org/software/automake/manual/html_node/Uniform.html