From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id OOH1DvWl4GWIogAAe85BDQ:P1 (envelope-from ) for ; Thu, 29 Feb 2024 16:42:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id OOH1DvWl4GWIogAAe85BDQ (envelope-from ) for ; Thu, 29 Feb 2024 16:42:45 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Gju6s/sl"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709221365; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dNYk3bWPAqOGKX4B6tdNXRcFA9U/fEQ6lRgiWUT3iRg=; b=YyxHvLWNwLgOMxClGRaBrX3BO5Ywhoc46vmz4lZa7jH88b+gUgs8zgt33JOgdiF2mUCTwp YOv3IaWfsaIQH8idmxJX6BDpssg+rgJLNaXiGDPOPRBaeZtpdI7RkNTJ8mc2ebME1MV9G2 8kn8siYXa/ZaZrBiOf2ZF3QIvidrpYCFf/1XFznQ+Ve5BbNuqTBiAgdgejuRYlNSF6WSuM YvNQH+ONlX7fxFQomTyv2mCsk42Jyzs5lpypVE1cpwC5vPlQFilWsqj+n6NfQVKrGGecaq YdSsCTYn3eeazJHMFLgwTVloEZ8W6KU9GmVUspbazNc6FUuh9ib7R3rkgVaXrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Gju6s/sl"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709221365; a=rsa-sha256; cv=none; b=dmmFrtvUzDkGyBjfJAXIWPgroPaZl78/V+9JxdlBhCYpP9rtAG+ieKnnJ5iKH4b4v8+CnX RPRbrKAvD10N3p+JT++ErWcDB3XluMT8LCFEFip/2AYyYW++B1jHUBJjiqtfySFWGLZhIJ 08eMjJaSbtaibPLNRJbrZVHJEfCVAr6uHuykmhfzkw5qJSgVccBSutz9xEmEZ6eUzUVroO Jx+9L+mr5MNsqCusxmGetOEVDdWmknkyH488LV6/b8n+laGdrus7okD6kzta5yZnVNPsiy ih/Olz890cJbJVPf/AUY0qfBPUL/W8XgN+PHR6OJiOsMFsbhscABJrSN7ylIGw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 07C271212F for ; Thu, 29 Feb 2024 16:42:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfiXo-0005fm-OG; Thu, 29 Feb 2024 10:42:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfiXm-0005fJ-AJ; Thu, 29 Feb 2024 10:41:58 -0500 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfiXk-00013G-CT; Thu, 29 Feb 2024 10:41:58 -0500 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2d21a68dd3bso12535241fa.1; Thu, 29 Feb 2024 07:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709221313; x=1709826113; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dNYk3bWPAqOGKX4B6tdNXRcFA9U/fEQ6lRgiWUT3iRg=; b=Gju6s/slil7JMU8PduOyZ8GEs1nPfaztFF5KFbHRKPLOUP89q3hXZEUwJr8P6QTl7/ z93Gggkt3yzz+ZTCSitjUMIVHhMQB2kKAXo7JwjVzow22BdUYTedy+6LcoSc9xcPgVZ1 IR8Cqv3fknMfsT6hGTS5/Jp/TPmQMFnC7Rxu7uHQO5HEq8mrVkOe1VZK1mibHhJe/0CD 5CYl2lHNbvGdnNn412sSzshrNoQUUZjzZspwJEuAicN93ihv+NamESfRbozcjuvhFLRN POdVkWhwoB/mlKGKrOw9Cy1T7NdgKdJeWC9Efh1urf6hX/bsQOzxKfL1GHvKyZ90p3iF 3LdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709221313; x=1709826113; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dNYk3bWPAqOGKX4B6tdNXRcFA9U/fEQ6lRgiWUT3iRg=; b=WtLEPbB+Oy8p/6U+fnxB4Bi41HdOyWji16D8uMqAjo7vCuthTSnAf0IYmqWn0UHfQt johqxBNYY1lyDi3SGSp0dR8XMWQN7QQBMac7tokTOV5L0phlCMOXawvhrv1NMWawcZmk zJPBjt9cFJErhCyApy13YEZvJHrKvfgSB6N1WEUL7sYOK/omzBUd2QK7hAnoGC6V0lBU o1OKbIE9dvNPLh84X26gjj5vprYRBhcnVQWmsbKbTFeJDJ3e0W77NmXuug+qnGUZcXCF 2mlcXYOrW0CPwQjLADzUOh+vyvfX6Cfl9AtjHZJAwG4l1wkTI5rA1w2Ip9emYLW2FUmp F2RA== X-Forwarded-Encrypted: i=1; AJvYcCUYo15fHpXCZk/nVRb3SKdyil/KV9HrQvdTNk5Cytvms4nUxDqutKBeDHo2zSuASoKWHA5bE2/J+ukrhpJdDEJS0g== X-Gm-Message-State: AOJu0YwHdcZ5eB0dt/HHWE0Aw3aYT3JxBP+FlvttrBe3+2+nUP2Rddzs 5JqUlDzrEvHu4+AKo3p4fHjc7DDLIl3mIOQ6iq8o+X2cgWDR3SbA6QfGLJRT558XZniPPWMc0hk ALYR990cTtX6tutyNm3NTYrucV64= X-Google-Smtp-Source: AGHT+IE5qUnjmi7du7rtNr+6fWF0bS1BP4DdMU59cCqrlYbkrDZi/CIgKHNhAu6Xl2VBovfSs1ftm/bCtbRGUIvMWwg= X-Received: by 2002:a2e:98c6:0:b0:2d2:3b9e:dcff with SMTP id s6-20020a2e98c6000000b002d23b9edcffmr1684002ljj.46.1709221312769; Thu, 29 Feb 2024 07:41:52 -0800 (PST) MIME-Version: 1.0 References: <10c82db7-6fc6-4fa0-8213-e207fa54db58@futurile.net> <87ttmaiv1j.fsf@gmail.com> <878r344gvf.fsf@xelera.eu> <18df12a3f1e.bb5785df1534691.5879757396979638482@excalamus.com> In-Reply-To: <18df12a3f1e.bb5785df1534691.5879757396979638482@excalamus.com> From: Daniel Littlewood Date: Thu, 29 Feb 2024 15:41:41 +0000 Message-ID: Subject: Re: Guix Days: Patch flow discussion To: matt@excalamus.com Cc: guix-devel , help-guix Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::22e; envelope-from=danielittlewood@gmail.com; helo=mail-lj1-x22e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: help-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.56 X-Spam-Score: -9.56 X-Migadu-Queue-Id: 07C271212F X-Migadu-Scanner: mx13.migadu.com X-TUID: A43aiz+8KLwt Hi! I'm a complete newbie to Guix, which has the dual effects that I'm much more excited about it than I otherwise might be, but the disadvantage that I know nothing and am more likely to cause problems than not at the moment. Nevertheless I thought I might be able to contribute something to the discussion. Something that is not obvious to me when people refer to reviewing patches, is whether this is purely a matter of adding new packages to the main guix channel, or of reviewing changes to the system in general, or both. As a novice, I can imagine becoming comfortable as a package reviewer much more quickly than as a reviewer of core patches to the system. It's also not obvious to me whether you mean exactly "reviewing a backlog of existing patches" or additionally "increasing the amount of patches submitted and applied". I feel like both are probably good things but I can't tell what you're focussing on exactly. If lots of gems were imported from other repos like RubyGems and PyPi, which as I understand it is currently a partly-automatic partly-manual process, would that be considered a win? What about increasing version coverage among those packages that are covered? One point brought up here is about tooling. I wonder whether there is any scope for fully automatic review. In other words, for some classes of package we might be able to say that if it builds in CI, and maybe the built package has a command that's considered enough to say "it's working", then that's all the review that's needed. I guess I'm mostly thinking here of cases where the package is imported, partially or entirely automatically, from another repo (as with `guix import`). So one could argue that as long as it looks like "the rubygems import is working" then the guix package thus imported can be assumed to be working too. I guess when I say this I am still mostly thinking of importing entire histories of a package (lots of versions simultaneously) without multiplying out the work involved to a huge degree. One of the points brought up earlier is whether it would be better to have interactive "review parties" or comprehensive documentation about what constitutes a good review. Obviously these are not mutually exclusive. But for my part, I think documentation gives you more "bang for your buck", for a few reasons: 1. Documentation is online all the time, whereas interactive sessions are subject to people's work schedules, time zones, personal commitments, etc. 2. Documentation is more likely to be complete, and to become more likely to be complete over time, whereas in meetings (or when doing your first solo review following the meeting) it is easy to forget some steps or criteria to check. 3. Reading docs can be done by anyone, with no commitment to follow up. I think some people are just scared off socially by the idea of having to join a meeting in order to learn how to do reviews well. Obviously this is a personal thing and varies - some people find a welcoming atmosphere in a virtual meeting much better than a faceless documentation screen. For my part I think I would prefer to read until I know the basics, and then might prefer to do it alongside other people. A "patch party" would not convert me from non-contributor to contributor, but it might convert me from a seldom-contributor to an active one. Again, there is obviously variation here among people. In case it is not obvious, I have only recently joined guix-devel, but would be keen to help out if I can. If there are things I can read to get "up to speed" that would be really helpful! All the best, Dan