all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Stefan Stefanović" <stefanx2ovic@gmail.com>
To: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH][WIP] Elogind update
Date: Tue, 13 Nov 2018 12:37:32 +0100	[thread overview]
Message-ID: <CAFBTj=g4QYBK29LBW_TgbHDp25iPfBUJu8Q316B_0Em-6i8pqg@mail.gmail.com> (raw)
In-Reply-To: <CAFBTj=gYSz3NZqC_nSMKdH0QNCVD_8eS-fYe=kfwn4Ec+5Y4Hg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Status update:
The solution Andy provided works.
The PID file has a new path:
 "/run/systemd/elogind.pid".
Additional patch that is needed,
will be provided with this message.

All that remains is to figure out how
to integrate this update to Guix,
following the next release of elogind (v239.2).

Any advice and suggestion is appreciated,
since I am relatively new to Scheme and Guix.

Issue:
Replacing elogind package definition in place
did not work for me the last time I tried it.
Problem is the guix commands were stuck/busy
(not stuck building or anything like that,
just stuck like "in an infinite loop")
every time I tried to build elogind,
with the newer package definition
as replacement for the older one.

Maybe I should have tried
and waited for a few hours.

The only thing that avoided this issue was
the replacement of "elogind" with "elogind-next"
while leaving the older elogind package intact.
It might be the case that my guix environment
setup is wrong. Am I missing something obvious?

Any comment around described
issue is appreciated.
Thank you.

Stefan.

[-- Attachment #2: 0001-gnu-elogind-next-Change-PID-file-path.patch --]
[-- Type: text/x-patch, Size: 1293 bytes --]

From ca741455a39417991405ef2f254f5773496d8fd1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <stefanx2ovic@gmail.com>
Date: Mon, 12 Nov 2018 22:23:28 +0100
Subject: [PATCH] gnu: elogind-next: Change PID file path.

* gnu/packages/freedesktop.scm (elogind-next)
  [origin][snippet]: Change PID file path to tmpfs mount point.
---
 gnu/packages/freedesktop.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index da2cadffac..940185f418 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -387,9 +387,10 @@ of a the system to know what users are logged in, and where.")
                        (string-append "xsltproc_flags = ["
                                       "        '--novalid',")))
                     (substitute* "src/login/elogind.c"
-                      ;; Change PID file path.
+                      ;; Change PID file path
+                      ;; to fmpfs mount point.
                       (("\"/run/elogind.pid\"")
-                       "\"/var/run/elogind.pid\""))
+                       "\"/run/systemd/elogind.pid\""))
                     #t))))
       (build-system meson-build-system)
       (outputs '("out"))
-- 
2.19.1


  reply	other threads:[~2018-11-13 11:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 16:00 [PATCH][WIP] Elogind update Stefan Stefanović
2018-11-12 14:21 ` Andy Wingo
2018-11-12 21:06   ` Stefan Stefanović
2018-11-13 11:37     ` Stefan Stefanović [this message]
2018-11-14 10:33       ` Ludovic Courtès
2018-11-14 13:39         ` Stefan Stefanović
2018-11-14 17:04           ` Marius Bakke
     [not found]             ` <CAFBTj=gsoSHJbZmHTNdQb29ddic-X5hZekOQE+t2ooAgudWpCQ@mail.gmail.com>
2018-11-16  6:11               ` Stefan Stefanović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBTj=g4QYBK29LBW_TgbHDp25iPfBUJu8Q316B_0Em-6i8pqg@mail.gmail.com' \
    --to=stefanx2ovic@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.