From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Zancanaro Subject: Re: [PATCH] gnu: Add awesome. Date: Mon, 13 Jun 2016 21:54:37 +1000 Message-ID: References: <1465776755-16444-1-git-send-email-carlo@zancanaro.id.au> <1465778333-19689-1-git-send-email-carlo@zancanaro.id.au> <20160613095331.76d99012@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11425e3ea84e550535278ef9 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQSM-0005Uu-U4 for guix-devel@gnu.org; Mon, 13 Jun 2016 07:55:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCQSH-0007ge-Gu for guix-devel@gnu.org; Mon, 13 Jun 2016 07:54:58 -0400 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:33423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCQSH-0007gY-CX for guix-devel@gnu.org; Mon, 13 Jun 2016 07:54:57 -0400 Received: by mail-qt0-x22c.google.com with SMTP id c34so33562004qte.0 for ; Mon, 13 Jun 2016 04:54:57 -0700 (PDT) In-Reply-To: <20160613095331.76d99012@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org --001a11425e3ea84e550535278ef9 Content-Type: text/plain; charset=UTF-8 Hi! On 13 June 2016 at 17:53, Danny Milosavljevic wrote: > I think it would be better if it went into wm.scm . > Ah, okay! I looked at ratpoison.scm, because it was the first window manager that I thought of to look up. It was in its own file, so I followed that example. I agree awesome fits better into wm.scm. > + (arguments `(#:phases (modify-phases %standard-phases > > + (replace 'check > > + (lambda* _ > > + (zero? (system* "../build/awesome" > "-v"))))))) > > What's up with the tests? Why disable them like this? > There actually aren't any tests, so if I leave the "check" phase to do the default "make test", it fails. This way it at least checks that the awesome binary was compiled and can be run. I'll put a comment in explaining that. --001a11425e3ea84e550535278ef9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi!

On 13 June 2016 at 17:53, Danny Milosavljevic <dannym@scr= atchpost.org> wrote:
I think it would be better if it went into wm.scm .
Ah, okay! I looked at ratpoison.scm, because it was the first = window manager that I thought of to look up. It was in its own file, so I f= ollowed that example. I agree awesome fits better into wm.scm.

> +=C2=A0 =C2=A0 (arguments `(#:phases (modify-phases %standard-phases > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace 'check
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda* _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (zero? (system* "../build/a= wesome" "-v")))))))

What's up with the tests? Why disable them like this?

There actually aren= 't any tests, so if I leave the "check" phase to do the defau= lt "make test", it fails. This way it at least checks that the aw= esome binary was compiled and can be run. I'll put a comment in explain= ing that.
--001a11425e3ea84e550535278ef9--