From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant. Date: Mon, 26 Sep 2016 18:57:45 +0200 Message-ID: References: <20160926103447.31830-1-david@craven.ch> <20160926103447.31830-4-david@craven.ch> <20160926132344.GA23258@jocasta.intra> <20160926164934.GA25011@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boZDw-0003oU-E2 for guix-devel@gnu.org; Mon, 26 Sep 2016 12:57:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boZDu-0008Mv-HN for guix-devel@gnu.org; Mon, 26 Sep 2016 12:57:47 -0400 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:36312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boZDu-0008Mm-Db for guix-devel@gnu.org; Mon, 26 Sep 2016 12:57:46 -0400 Received: by mail-qk0-x241.google.com with SMTP id m184so4073308qkb.3 for ; Mon, 26 Sep 2016 09:57:46 -0700 (PDT) In-Reply-To: <20160926164934.GA25011@jocasta.intra> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel > I entirely agree. I'm not alone :-) > Our current convention for commit messages is aesthetically pleasing, > but useless. It is redundant to put in the message WHAT has changed. > That can be easily determined by running "git show". What is much > more usefull is the reason WHY we changed it. +1 > Recently, on another project, I came across a line of code which I > was pretty sure was pointless. I was about to delete it - but I > decided to check first. So I ran "git blame" to find out which > commit had added it. Then I ran git show to get the full details > of that commit. Fortunately, the person who had committed it 5 years > ago had mentioned exactly why it was needed. - and it was there > for a very valid reason too. Had we been using the Guix convention, > this would probably have been deleted and consequences would have > followed. Been there, done that... > I vote that we make the reason for a commit to be compulsory. All > other details optional. +1, more details is better than less, LKML-style... -- Vincent Legoll