From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Hpu0OrEE3V8iVwAA0tVLHw (envelope-from ) for ; Fri, 18 Dec 2020 19:36:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id INTzNbEE3V+zdgAA1q6Kng (envelope-from ) for ; Fri, 18 Dec 2020 19:36:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD65B9404FF for ; Fri, 18 Dec 2020 19:36:13 +0000 (UTC) Received: from localhost ([::1]:32788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqLXw-00027o-G6 for larch@yhetil.org; Fri, 18 Dec 2020 14:36:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqLXn-00024x-7a for guix-patches@gnu.org; Fri, 18 Dec 2020 14:36:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqLXm-0000ih-0s for guix-patches@gnu.org; Fri, 18 Dec 2020 14:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqLXl-0002Dj-TV for guix-patches@gnu.org; Fri, 18 Dec 2020 14:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#40601] New reduced patchset, the easy bits first Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Dec 2020 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Received: via spool by 40601-submit@debbugs.gnu.org id=B40601.16083201318496 (code B ref 40601); Fri, 18 Dec 2020 19:36:01 +0000 Received: (at 40601) by debbugs.gnu.org; 18 Dec 2020 19:35:31 +0000 Received: from localhost ([127.0.0.1]:39954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqLXG-0002Cy-Pz for submit@debbugs.gnu.org; Fri, 18 Dec 2020 14:35:31 -0500 Received: from mail-lf1-f49.google.com ([209.85.167.49]:46720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqLXF-0002Ca-EK for 40601@debbugs.gnu.org; Fri, 18 Dec 2020 14:35:29 -0500 Received: by mail-lf1-f49.google.com with SMTP id y19so8168649lfa.13 for <40601@debbugs.gnu.org>; Fri, 18 Dec 2020 11:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tsqsKyo94UFRnnAKIhR+qKXky7mj/VglJnHXab4trmI=; b=EluTjntAOXahRBLfmphj8P+nNj8ElC9gN8My6DKAW3eOxI8ELeSMOA8vyJB1ywb2BV /Rs1t6/YthUZ5j1pso5Ybuj2KLfDq5XY0dcFESrZeqUqz5mcOPYSDe6/UXEVQqU2/+XY uDZAWkPWjFZ7LzQAkrhIx8EaM1VKVDocfrKgtmwoUsem6kWEuQHje4YNAa/+0lupVs8Y InSxQRIvJzcNaq4+8/fuCRTUdoC0rejdJ3lu+Hp4NV9VibBBTmxxpLwKsaX14ZuLR/x9 QFm3alvDgic/94ry8V9psX8gzSQfJyLNwBxbMi1XzqWbsz7zBWm7OL2iX0Vh1YpuynNA CCTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tsqsKyo94UFRnnAKIhR+qKXky7mj/VglJnHXab4trmI=; b=sttJMxqNd3qpAu6RblZWTlj307/oOCM81m4Nm+Wi/6eqY7aSsCsrbH9mAQAUdGh5T+ 9+coN+NRemIIJN39WuLV2dV18dHNPEcVdya6mrYPxC3UBWjb2w6h9ff0hW7ZBDHZgBMX ydOd5RnqKC+gCmF9WvCWkKPgYH0GELsZZyVmCseftumGTgOidMefHy7Wl0jIX0QKNDJG 6Zb/zX+gd9FvWcyZTw/UCoaXDnj+0BrDygATRoboELIdzYz1b01PE5ipHjWUnopaNfrC DZrIqg+H1RpCXjgw08Ed5uILgUdR7CvaymU0rhNeTTB9/u4diD01pnY0tcU/Q6Vg/fSv OmuA== X-Gm-Message-State: AOAM531HPFWbd5DHQpcie7d3TMYLV45K+ffdnoWAWHQw5UrqrJPgIN9B tmj0Cm4xK2NkFMvCf+UqbVb3s5XeOEiYojPooTA= X-Google-Smtp-Source: ABdhPJzAKqarSCI3NBAwX1emaMzFDm/agaquk5aJ085C//bM5iQG+6JwipXwQ6Pd3QmrxKrTtLXjviTYTaUVLY08H/s= X-Received: by 2002:a2e:9916:: with SMTP id v22mr2402683lji.221.1608320122881; Fri, 18 Dec 2020 11:35:22 -0800 (PST) MIME-Version: 1.0 References: <58b21d29-f0b0-af8a-8c9e-11f4dd7a317a@gmail.com> <00b505a4-0c1a-2f6c-7242-57d7b5eb7d4f@gmail.com> <87v9cz1eo5.fsf@cbaines.net> In-Reply-To: <87v9cz1eo5.fsf@cbaines.net> From: Vincent Legoll Date: Fri, 18 Dec 2020 20:35:11 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 40601@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=EluTjntA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DD65B9404FF X-Spam-Score: -1.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: X4n4N+rxxH+o Hello, > Thanks for sending a smaller set of patches, that makes reviewing > easier. I made some tweaks, and pushed 4 commits to master as > d2532317d136ac063a24baeec6688ea0e0ebe37b. Thanks for taking care of this, I'll have a look. > I'm not sure about the bashisms stuff, given the script seems to depend > on bash (see the exec bash bit at the start), I think using bash > functionality is reasonable. What was your motivation behind these > changes? (sorry if I've missed this earlier in the thread). Some distributions that I intended to add support for don't default to bash (nor have it installed by default). I think this script should aim for the broadest possible support, but that is only my opinion. And the patch set was not finished, I wanted to tackle the low hanging fruits first (also to test the interest from the guix team before doing too much). > Maybe once we've talked about the bashisms stuff, would you be able to > send another set of patches for review? I'll try to revive the patch set, and submit other portions I should have lying somewhere. Tchuss -- Vincent Legoll