guix package modif testing

guix package modif testing

[Vincent Legoll]

I'll probably get RTFM'ed once again, but at least I tried to search first...

It looks like this :
https://www.gnu.org/software/guix/manual/guix.html#Building-from-Git
is intended for people willing to hack on guix itself, but I want to hack
at the package's definitions...

I want to test the pythondialog patch I posted in te other thread...

How do you try modifications to packages that are already in the repo ?

Is GUIX_PACKAGE_PATH completely overriding the repo, so I can
just copy the file I want to test in there, modify it, then build ?

-- 
Vincent Legoll

Re: guix package modif testing

[Andreas Enge]

On Wed, Jul 27, 2016 at 03:19:43PM +0200, Vincent Legoll wrote:
> It looks like this :
> https://www.gnu.org/software/guix/manual/guix.html#Building-from-Git
> is intended for people willing to hack on guix itself, but I want to hack
> at the package's definitions...

This is all the same, everything is tightly integrated.

> I want to test the pythondialog patch I posted in te other thread...
> How do you try modifications to packages that are already in the repo ?

Personally I just create another local git branch and make my
modifications there, in gnu/packages/....scm. In case things work out,
it is then trivial to create a patch (git commit + git format-patch)
and to send it to the list (you may even use git send-email, which
is in a separate output of the git package).

Andreas

Re: guix package modif testing

[Alex Vong]

Hi,

Andreas Enge <andreas@enge.fr> writes:

> On Wed, Jul 27, 2016 at 03:19:43PM +0200, Vincent Legoll wrote:
>> It looks like this :
>> https://www.gnu.org/software/guix/manual/guix.html#Building-from-Git
>> is intended for people willing to hack on guix itself, but I want to hack
>> at the package's definitions...
>
> This is all the same, everything is tightly integrated.
>
>> I want to test the pythondialog patch I posted in te other thread...
>> How do you try modifications to packages that are already in the repo ?
>
> Personally I just create another local git branch and make my
> modifications there, in gnu/packages/....scm. In case things work out,
> it is then trivial to create a patch (git commit + git format-patch)
> and to send it to the list (you may even use git send-email, which
> is in a separate output of the git package).
>
Same for me. Usually, I run "git pull" first to update the repo. Then, I
build using "./boostrap && make -j`nproc`". After that, I changes the
files in guix/gnu/packages/. Next, I test the changes by
"./pre-inst-env guix lint foo" and "./pre-inst-env guix build foo". If
the changes pass the lint and the build, run "git commit" and
"git format-patch HEAD^". Finally, attach the patch and send the email.

Notice all the commands is run with guix/ being the current working
directory. Also, I am learning to use magit, so this is really the old
approach I use.

Hope this help.

> Andreas

Cheers,
Alex

Re: guix package modif testing

[Vincent Legoll]

I'm still missing something

vince@guixsd ~/repo$ ls -l ~/repo
lrwxrwxrwx 1 vince users 19 Jul 27 15:38 /home/vince/repo -> .config/guix/latest

vince@guixsd ~/repo$ patch -p1 <
~/guix-packages/0001-Add-python-pythondialog.patch
File gnu/packages/python.scm is read-only; trying to patch anyway
patch: **** Can't create temporary file
gnu/packages/python.scm.oiz9bQi : Read-only file system

Or do I need to do that as root ?

-- 
Vincent Legoll

Re: guix package modif testing

[Andreas Enge]

On Wed, Jul 27, 2016 at 04:56:27PM +0200, Vincent Legoll wrote:
> I'm still missing something
> vince@guixsd ~/repo$ ls -l ~/repo
> lrwxrwxrwx 1 vince users 19 Jul 27 15:38 /home/vince/repo -> .config/guix/latest
> 
> vince@guixsd ~/repo$ patch -p1 <
> ~/guix-packages/0001-Add-python-pythondialog.patch
> File gnu/packages/python.scm is read-only; trying to patch anyway
> patch: **** Can't create temporary file
> gnu/packages/python.scm.oiz9bQi : Read-only file system

.config/guix/latest is itself a link into /gnu/store/..., so cannot be
changed. You should work with a git checkout - so do a "git pull", not
a "guix pull"!

Andreas

Re: guix package modif testing

[Vincent Legoll]

> .config/guix/latest is itself a link into /gnu/store/..., so cannot be
> changed. You should work with a git checkout - so do a "git pull", not
> a "guix pull"!

The thing I still miss is that: how do I make guix use a different git
checkout ?

Is there a GUIX_CHECKOUT_PATH env var, a CLI parameter, or
./boostrap & ./pre-inst-env done in the checkout does all the magic ?

-- 
Vincent Legoll

Re: guix package modif testing

[Andreas Enge]

On Wed, Jul 27, 2016 at 06:37:26PM +0200, Vincent Legoll wrote:
> The thing I still miss is that: how do I make guix use a different git
> checkout ?

Go into the git checkout of guix and run
   ./pre-inst-env guix ...
The little script sets all environment variables to run the local copy
instead of the "normal" guix.

Andreas

Re: guix package modif testing

[Andreas Enge]

PS: https://www.gnu.org/software/guix/manual/guix.html#Running-Guix-Before-It-Is-Installed

Re: guix package modif testing

[Vincent Legoll]

On Wed, Jul 27, 2016 at 7:02 PM, Andreas Enge <andreas@enge.fr> wrote:
> PS: https://www.gnu.org/software/guix/manual/guix.html#Running-Guix-Before-It-Is-Installed

The title of this chapter made me first completely skip it because I
*have* guix installed,
as I'm running guixSD... I read that page (probably multiple times in
the last few days) but
I still don't get it...

-- 
Vincent Legoll

Re: guix package modif testing

[Alex Vong]

Hi Vincent,

Vincent Legoll <vincent.legoll@gmail.com> writes:

>> .config/guix/latest is itself a link into /gnu/store/..., so cannot be
>> changed. You should work with a git checkout - so do a "git pull", not
>> a "guix pull"!
>
> The thing I still miss is that: how do I make guix use a different git
> checkout ?
>
> Is there a GUIX_CHECKOUT_PATH env var, a CLI parameter, or
> ./boostrap & ./pre-inst-env done in the checkout does all the magic ?

I think you are confusing the system you are running (Guix SD) and the
system you are developing (the Guix git repo). `.config/guix/latest' is
part of the your running system, so it is not the place you want to
experiment with changes. To develop Guix, you need to clone its git repo
by running:

  $ git clone git://git.savannah.gnu.org/guix.git

Then, you can `cd' into the cloned repo and start running the
`./boostrap' stuffs and so on...
In case you are new to git, you can read the git book
(https://git-scm.com/book/en/v2) or simply search for it on the
Internet, Stackoverflow is the place where I learn most of git.

Cheers,
Alex

Re: guix package modif testing

[Vincent Legoll]

> I think you are confusing the system you are running (Guix SD) and the
> system you are developing (the Guix git repo).

I'm just a few weeks of part time into guix, so yes, I clearly am.

I've got no problem using git though

I'll see what I can get out of all the comments I got

-- 
Vincent Legoll

Re: guix package modif testing

[Vincent Legoll]

I did, as a user of my guixsd system:

git clone [...] guix
cd guix
./bootstrap
[ERROR PKG_CONFIG / m4 / etc...]

guix environment guix
[env]> ./bootstrap
[env]> ./configure
[env]> make -j3

I get the BT @ http://paste.lisp.org/+6W42

What's wrong ?

-- 
Vincent Legoll

Re: guix package modif testing

[Ludovic Courtès]

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> I did, as a user of my guixsd system:
>
> git clone [...] guix
> cd guix
> ./bootstrap
> [ERROR PKG_CONFIG / m4 / etc...]
>
> guix environment guix
> [env]> ./bootstrap
> [env]> ./configure
> [env]> make -j3
>
> I get the BT @ http://paste.lisp.org/+6W42

Namely:

--8<---------------cut here---------------start------------->8---
   ?: 6 [primitive-load-path "gnu/packages/python" ...]
In ice-9/eval.scm:
 432: 5 [eval # ()]
 453: 4 [eval # ()]
 387: 3 [eval # ()]
 411: 2 [eval # #]
 411: 1 [eval # #]
In unknown file:
   ?: 0 [string-append "https://pypi.io/packages/source/" "p" ...]

ERROR: In procedure string-append:
ERROR: In procedure string-append: Wrong type (expecting string): #<procedure version ()>
Makefile:4851: recipe for target 'make-go' failed
--8<---------------cut here---------------end--------------->8---

> What's wrong ?

Do you have changes in your work directory?

The problem here is that the ‘version’ parameter of ‘pypi-uri’ (in
guix/build-system/python.scm) points to Guile’s ‘version’ procedure,
whereas it should be a version string.

Ludo’.