From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Legoll Subject: Re: [PATCH v4] daemon: Set ownership of kept build directories to the calling user. Date: Fri, 23 Dec 2016 12:18:11 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKNrY-0007AX-V7 for guix-devel@gnu.org; Fri, 23 Dec 2016 06:18:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKNrY-0003fs-4o for guix-devel@gnu.org; Fri, 23 Dec 2016 06:18:12 -0500 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKNrY-0003fh-1c for guix-devel@gnu.org; Fri, 23 Dec 2016 06:18:12 -0500 Received: by mail-qk0-x243.google.com with SMTP id u25so16314882qki.2 for ; Fri, 23 Dec 2016 03:18:11 -0800 (PST) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel Hello, + // Change the ownership if clientUid is set. Never change the + // ownership or the group to "root" for security reasons. + if (settings.clientUid != (uid_t) -1 && settings.clientUid != 0) { Is "0" a magical value that don't need casting or am I missing something ? -- Vincent Legoll