From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4Ni+KAkh/l/4EgAA0tVLHw (envelope-from ) for ; Tue, 12 Jan 2021 22:22:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MGSNJAkh/l8fVgAAB5/wlQ (envelope-from ) for ; Tue, 12 Jan 2021 22:22:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 560C89402AF for ; Tue, 12 Jan 2021 22:22:01 +0000 (UTC) Received: from localhost ([::1]:50480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzS36-0007hv-4o for larch@yhetil.org; Tue, 12 Jan 2021 17:22:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzS0E-0006e3-QE for guix-patches@gnu.org; Tue, 12 Jan 2021 17:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzS0E-0001N8-Ha for guix-patches@gnu.org; Tue, 12 Jan 2021 17:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzS0E-0007NA-Cz for guix-patches@gnu.org; Tue, 12 Jan 2021 17:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45825] [PATCH] gnu: Add efi_analyzer. Resent-From: Vincent Legoll Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Jan 2021 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45825 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice X-Debbugs-Original-Cc: 45825-done@debbugs.gnu.org, Guix Patches Received: via spool by submit@debbugs.gnu.org id=B.161048989628276 (code B ref -1); Tue, 12 Jan 2021 22:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jan 2021 22:18:16 +0000 Received: from localhost ([127.0.0.1]:33558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRzU-0007M0-0V for submit@debbugs.gnu.org; Tue, 12 Jan 2021 17:18:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:41896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRzS-0007Lr-2W for submit@debbugs.gnu.org; Tue, 12 Jan 2021 17:18:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzRzR-0006OR-S4 for guix-patches@gnu.org; Tue, 12 Jan 2021 17:18:13 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:42567) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzRzP-0001A8-Kj for guix-patches@gnu.org; Tue, 12 Jan 2021 17:18:13 -0500 Received: by mail-lf1-x134.google.com with SMTP id b26so5714388lff.9 for ; Tue, 12 Jan 2021 14:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yFcb004aBbroD1yRr2mVs6ZJISrsSEUqp9LGP/AdABQ=; b=agvzZHUSvnEc1Zgo2UzK13u1QHtNA1EYkbdF+QxbMfFvJ5wJA99f0KIY25yNpiDz6X xvpMYmGb/unwdF2LHLifZ/RQVZJjYVNcCh1ub4/OndwAdQo2qP+tXzfaogUQaRE9Mad2 9fVLNw5VR5/qW829EbXWpmKuYVm3Pa4xrQEpx3AroT+B4s3qCbyPHizeyrnINcv3N5zw EX4YzqWW4mZujp94qaVdV5oKjDfNWUlWOCdJdxIx0n5Emh5cIVyftC6N+Wkg1cbSmbdT G4ZkBTefPGRYCFTRpS7/qv8s0Sysp3FRXsivtEnoUpgfzvUGHcTL70zvuVzZaRWNqMi/ s6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yFcb004aBbroD1yRr2mVs6ZJISrsSEUqp9LGP/AdABQ=; b=qvNlw1RH7gmCRUz23uqkEdCTpqxPKEkCLVIhMryA7NM/s8UIPhQlYuaOnGckmHjP9U A75PzkYz5VJfn76c+1IgRm8qR4rhV2M0ipxFSSkxClRPpum+qJGpqxv6Ub/c6JBu/UYu lxJUc48MrRld2SmNFL55IExdpF1tlViXYdTYjR/jcsnqpkOe5uJchNHrqJQ/KpTtRUqF w1UNTmg/u6qPS1fFo0PJR6z0UFtEv+8KvTzQqu3ZdvdKfn5Ow6Uw5upmLvHG4vl756lt F9oA0ReZrIkxPuPM1/qSSH+pKWH+Z5qEPLn5Rouv3MxUNSUMSAtyFnQ8CoISEZOP7bb3 rdEQ== X-Gm-Message-State: AOAM530cBFwnUgyWtdmj8v+aTIVxfXWMsIWdaqxyiHMj6EuUB3GWcngj ZsjGuEBMhGDq/yj6jO8KpR4UBMd5EAzcNQcQdLM= X-Google-Smtp-Source: ABdhPJwBkDPWSaQjvd5DfN4h3Bvy+8HT8CHVIHjJ3H5sWlar+kzBKd4WwyukcT/K2+1cAT2XvbLK3o4mP1qIjeaCJps= X-Received: by 2002:a19:5216:: with SMTP id m22mr413842lfb.459.1610489889683; Tue, 12 Jan 2021 14:18:09 -0800 (PST) MIME-Version: 1.0 References: <20210112193747.19460-1-vincent.legoll@gmail.com> <87im81olu7.fsf@nckx> In-Reply-To: <87im81olu7.fsf@nckx> From: Vincent Legoll Date: Tue, 12 Jan 2021 23:17:58 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=vincent.legoll@gmail.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45825@debbugs.gnu.org, 45825-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=agvzZHUS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 560C89402AF X-Spam-Score: -1.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: rAaX/s6HfSh7 Hello, On Tue, Jan 12, 2021 at 11:02 PM Tobias Geerinckx-Rice wrote= : > > gnu/packages/engineering.scm | 27 +++++++++++++++++++++++++++ > > I failed to see any connection to engineering and moved this to > efi.scm. I searched a bit (debug.scm, etc.) but failed to find the *really* obvious one :facepalm: I chose engineering because another rev-eng tool (radare2) was here. > Don't forget to add or update your copyright line. I almost always forgot to do that. > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url > > "https://github.com/xypron/efi_analyzer") > > + (commit commit))) > > + (sha256 > > + (base32 > > "1izdkzybqyvzpzqz6kx4j7y47j6aa2dsdrychzgs65466x1a4br1")) > > I added a newline after =E2=80=98source=E2=80=99 to give this 81-characte= r line > some breathing room. This one I swear I ran the etc/indent.el script on, was it in my brain only ? > > + (file-name (string-append name "-" version > > "-checkout")))) > > This can be done with the > > (file-name (git-file-name name version)) > > helper. Argh, another forgetting, you probably taught me that a few times already. > > + (arguments > > + `(#:phases > > + (modify-phases %standard-phases > > + (delete 'configure)) > > Not a comment on your patch, but I added a > =E2=80=98support-cross-compilation=E2=80=99 phase here that replaces the > Makefile's hard-coded =E2=80=98gcc=E2=80=99 so you can inspect EFI binari= es on > your cross-compiled ARM box. I saw that, nice ! > > + #:make-flags (list "prefix=3D" (string-append "DESTDIR=3D" > > (assoc-ref %outputs "out"))))) > > The other way 'round: set $prefix (or the BSD variant $PREFIX) to > the destination, and never set DESTDIR unless you're working > around a bug in a broken build system. > > DESTDIR is for distributions/builds using a temporary =E2=80=98staging=E2= =80=99 > destination directory. Guix doesn't. OK, I hesitated between the 2 options, and failed to choose the right one :-)) > > + (description > > + "The EFI Analyzer can be used to check EFI binaries and to > > print out header > > +and section information.") > > Slash empty =E2=80=98x can y=E2=80=99 (or =E2=80=98x allows the user to y= =E2=80=99) filler with > gleeful prejudice. Just a copy-paste from upstream (should have proof read it, though) Thanks a lot for your patience in bearing with my half-baked submissions. I think I'll owe you a beer (or two). Tchuss --=20 Vincent Legoll