all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#23970: colordiff glitch
@ 2016-07-13  9:10 Vincent Legoll
  2016-07-13 21:39 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Vincent Legoll @ 2016-07-13  9:10 UTC (permalink / raw)
  To: 23970

during "guix package -i colordiff" I saw this error being reported:

cp colordiffrc /gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc
chown root.root
/gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc
chown: invalid user: ‘root.root’
Makefile:24: recipe for target 'install' failed
make: [install] Error 1 (ignored)
chmod 644 /gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc
phase `install' succeeded after 0.1 seconds

But it looks like it is harmless (at least from the guix install PoV)

vince@guixsd ~/guix-packages$ l
/gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/
total 4.0K
-r--r--r-- 2 root guixbuild 963 Jan  1  1970 colordiffrc

This leaks the guixbuild group into /gnu/store, but it is not alone in
doing so...

If I try to do it manually afterwards, it obviously tell me the FS is R/O

root@guixsd /tmp# chown root.root /gnu/store/*colordiff*/etc/*
chown: changing ownership of
‘/gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc’:
Read-only file system

-- 
Vincent Legoll

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23970: colordiff glitch
  2016-07-13  9:10 bug#23970: colordiff glitch Vincent Legoll
@ 2016-07-13 21:39 ` Ludovic Courtès
  2016-07-14  9:17   ` Vincent Legoll
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-07-13 21:39 UTC (permalink / raw)
  To: Vincent Legoll; +Cc: 23970

Hello,

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> during "guix package -i colordiff" I saw this error being reported:
>
> cp colordiffrc /gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc
> chown root.root
> /gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc
> chown: invalid user: ‘root.root’
> Makefile:24: recipe for target 'install' failed
> make: [install] Error 1 (ignored)
> chmod 644 /gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc
> phase `install' succeeded after 0.1 seconds
>
> But it looks like it is harmless (at least from the guix install PoV)

It’s indeed harmless and fine.

> vince@guixsd ~/guix-packages$ l
> /gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/
> total 4.0K
> -r--r--r-- 2 root guixbuild 963 Jan  1  1970 colordiffrc
>
> This leaks the guixbuild group into /gnu/store, but it is not alone in
> doing so...
>
> If I try to do it manually afterwards, it obviously tell me the FS is R/O
>
> root@guixsd /tmp# chown root.root /gnu/store/*colordiff*/etc/*
> chown: changing ownership of
> ‘/gnu/store/gc9vqsz0jzylcdsik0hmnghiff1kf3am-colordiff-1.0.16/etc/colordiffrc’:
> Read-only file system

Right, /gnu/store is meant to be read-only and manually modifying it
voids your warranty.  :-)

  https://www.gnu.org/software/guix/manual/html_node/The-Store.html

For this reason, /gnu/store is a read-only bind-mount on GuixSD.

That files in /gnu/store have group ‘guixbuild’ is innocuous.

I hope this clarifies things!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23970: colordiff glitch
  2016-07-13 21:39 ` Ludovic Courtès
@ 2016-07-14  9:17   ` Vincent Legoll
  2016-07-14 12:55     ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Vincent Legoll @ 2016-07-14  9:17 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 23970

>> during "guix package -i colordiff" I saw this error being reported:
>>
>> chown: invalid user: ‘root.root’
>> Makefile:24: recipe for target 'install' failed
>> make: [install] Error 1 (ignored)
>> phase `install' succeeded after 0.1 seconds
>>
>> But it looks like it is harmless (at least from the guix install PoV)
>
> It’s indeed harmless and fine.

The problem I saw here, was that a build *error* is ignored, even if
in this particular case it
is harmless. Or maybe chown is kind of special-cased when it is done
inside /gnu/store ?

-- 
Vincent Legoll

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23970: colordiff glitch
  2016-07-14  9:17   ` Vincent Legoll
@ 2016-07-14 12:55     ` Ludovic Courtès
  2016-07-15  7:38       ` Vincent Legoll
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2016-07-14 12:55 UTC (permalink / raw)
  To: Vincent Legoll; +Cc: 23970

Vincent Legoll <vincent.legoll@gmail.com> skribis:

>>> during "guix package -i colordiff" I saw this error being reported:
>>>
>>> chown: invalid user: ‘root.root’
>>> Makefile:24: recipe for target 'install' failed
>>> make: [install] Error 1 (ignored)
>>> phase `install' succeeded after 0.1 seconds
>>>
>>> But it looks like it is harmless (at least from the guix install PoV)
>>
>> It’s indeed harmless and fine.
>
> The problem I saw here, was that a build *error* is ignored, even if
> in this particular case it
> is harmless. Or maybe chown is kind of special-cased when it is done
> inside /gnu/store ?

The error is purposefully ignored here: upstream’s Makefile explicitly
marks it as can be ignored, using a hyphen (info "(make) Errors").

And indeed, it makes a lot of sense to ignore this error with Guix since
this operation is not permitted.

Hope this clarifies things,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23970: colordiff glitch
  2016-07-14 12:55     ` Ludovic Courtès
@ 2016-07-15  7:38       ` Vincent Legoll
  2016-07-15  8:30         ` Andreas Enge
  0 siblings, 1 reply; 6+ messages in thread
From: Vincent Legoll @ 2016-07-15  7:38 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 23970

OK, thanks, that explains it, case closed...

On Thu, Jul 14, 2016 at 2:55 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Vincent Legoll <vincent.legoll@gmail.com> skribis:
>
>>>> during "guix package -i colordiff" I saw this error being reported:
>>>>
>>>> chown: invalid user: ‘root.root’
>>>> Makefile:24: recipe for target 'install' failed
>>>> make: [install] Error 1 (ignored)
>>>> phase `install' succeeded after 0.1 seconds
>>>>
>>>> But it looks like it is harmless (at least from the guix install PoV)
>>>
>>> It’s indeed harmless and fine.
>>
>> The problem I saw here, was that a build *error* is ignored, even if
>> in this particular case it
>> is harmless. Or maybe chown is kind of special-cased when it is done
>> inside /gnu/store ?
>
> The error is purposefully ignored here: upstream’s Makefile explicitly
> marks it as can be ignored, using a hyphen (info "(make) Errors").
>
> And indeed, it makes a lot of sense to ignore this error with Guix since
> this operation is not permitted.
>
> Hope this clarifies things,
> Ludo’.



-- 
Vincent Legoll

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#23970: colordiff glitch
  2016-07-15  7:38       ` Vincent Legoll
@ 2016-07-15  8:30         ` Andreas Enge
  0 siblings, 0 replies; 6+ messages in thread
From: Andreas Enge @ 2016-07-15  8:30 UTC (permalink / raw)
  To: Vincent Legoll; +Cc: 23970-done

Closing then with a cc to 23970-done@debbugs.gnu.org.

Andreas

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-07-15  8:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13  9:10 bug#23970: colordiff glitch Vincent Legoll
2016-07-13 21:39 ` Ludovic Courtès
2016-07-14  9:17   ` Vincent Legoll
2016-07-14 12:55     ` Ludovic Courtès
2016-07-15  7:38       ` Vincent Legoll
2016-07-15  8:30         ` Andreas Enge

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.