From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id Dm+7DcIXZGIEtAAAbAwnHQ (envelope-from ) for ; Sat, 23 Apr 2022 17:14:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iGGlDMIXZGLUXQAA9RJhRA (envelope-from ) for ; Sat, 23 Apr 2022 17:14:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 990E4BE8A for ; Sat, 23 Apr 2022 17:14:09 +0200 (CEST) Received: from localhost ([::1]:38484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niHSa-0007tW-Lg for larch@yhetil.org; Sat, 23 Apr 2022 11:14:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niHRY-0006Tz-1s for guix-patches@gnu.org; Sat, 23 Apr 2022 11:13:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1niHRX-0000pA-OK for guix-patches@gnu.org; Sat, 23 Apr 2022 11:13:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1niHRW-0008Bs-H9 for guix-patches@gnu.org; Sat, 23 Apr 2022 11:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54852] [PATCH] gnu: Add openjdk18. Resent-From: Rostislav Svoboda Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Apr 2022 15:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Julien Lepiller , 54852@debbugs.gnu.org Received: via spool by 54852-submit@debbugs.gnu.org id=B54852.165072672331416 (code B ref 54852); Sat, 23 Apr 2022 15:13:02 +0000 Received: (at 54852) by debbugs.gnu.org; 23 Apr 2022 15:12:03 +0000 Received: from localhost ([127.0.0.1]:56985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niHQZ-0008Ad-GK for submit@debbugs.gnu.org; Sat, 23 Apr 2022 11:12:03 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:41713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niHQX-0008A7-5x for 54852@debbugs.gnu.org; Sat, 23 Apr 2022 11:12:02 -0400 Received: by mail-ed1-f48.google.com with SMTP id d6so8608906ede.8 for <54852@debbugs.gnu.org>; Sat, 23 Apr 2022 08:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A4faZ5QaSEmfvV2Cntiws+mJ6FHi8z/MwJ5YMKUlh7k=; b=QU3exQav3KeGVXMrcT2tALTYbgVHXKYdgqf3q1+R6CM4IyE1v08m4FrEkIszN2lLqg nRPD3rWqCXW9okp+eU6FaXLTD9g6opb0q6eveP5WuJUt3TUDckNw7rpw40+jK3pktaIK xZqK4bImhB43wZFRR8imIxDpk+hVcfr77FmjKfratZFINRir2QERiyiV1OkpbhbgdHtN N8dMP3LciwNAEjLHmueWeUYSJ5Ex7Op/Wk8Dil+0QIJdXDZYnFoETf8lvu+lgwvQOcB8 RfNNL3sBeIQV+UxR4nYrRUVaRo5qykoRfAKb1kKitrC1n5Q3GuEAqa7VVsUgXp08MCur 2enA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A4faZ5QaSEmfvV2Cntiws+mJ6FHi8z/MwJ5YMKUlh7k=; b=4w7yLyLIFGVoackQO2vqOQIkODHhZs0oh/IRKgJoPinHyVatAgsfCqGf9Lw5Ya16nR SC9lFXmmNBnYRhqTmwC0JnTtwJvro7czIySFrSInnHdVDekf2djy0v4PFY6qIrvgCzrb 6sHhRgnPQLh127X0ifIY16Zbr2zc+kurAiFQSc7ptF/3mTz/+gnU2Eat+QgLL6Ns+pDV 4WVgTZYYiVopspuLnteCLLLQc3qMSuuzYwAjbeLbz0GPSqvtcJ6gvsHi+OmY6dhZD1gV RHf2zI22BWKdrW9mHxDouU6/mXJKemNfaA69aNLQ2IfXW7A3WTkzgaVIlzgt46STu9Bv LMXA== X-Gm-Message-State: AOAM533LwbasP/g7GFPVZwU3ryH7nHVQxXqpRk8UTf0a4BJnMdgHxhb0 HuCbC4nT+O3L4rQ5bgRx2XMpToZIqHJ07mno1To= X-Google-Smtp-Source: ABdhPJyFZO66/0uZ5mfnwiXQhZ6oswqcwo6+CJOgvhzOnt45juAtIHMhsGRvyV3OvLPyU6hJcnumW+YDQrPaUuhLWOU= X-Received: by 2002:a50:bae7:0:b0:425:c0fa:e0a7 with SMTP id x94-20020a50bae7000000b00425c0fae0a7mr8133751ede.104.1650726714847; Sat, 23 Apr 2022 08:11:54 -0700 (PDT) MIME-Version: 1.0 References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> <3878c34d8b9b52c6a618bb47ff3a3142f3d55c9f.camel@telenet.be> <77993552c1ea4641522845b97adc8bd5d8a2691a.camel@telenet.be> In-Reply-To: <77993552c1ea4641522845b97adc8bd5d8a2691a.camel@telenet.be> From: Rostislav Svoboda Date: Sat, 23 Apr 2022 17:11:18 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650726850; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=A4faZ5QaSEmfvV2Cntiws+mJ6FHi8z/MwJ5YMKUlh7k=; b=NXMbP3bVPOHls9uNPwi7Ga8x5mHM5R5Vd5TAfKa/03MYcMfdJEmacyxyaWd/ZpMv/scGpN QSwRT1TpHfNpSarePkEpbyJDJB8zKErryQxbn/iYdE1aUA2bN83hMzUV/JRRuQmtsUNHuW xCYJnCE7eMk/XbDEsydTBEcvvQyDplbJk6gKGl7WpiajOcX9Hz0RP0V0UIdpzINWp3IC05 HD8AnAMUje+HnpAAmwrThOInMD2BSM3isLNlrIuhk8Qw3l7pjXpX6KgOek3SNIo73wRwjY Y+9ygTMgAZVkKgPvMsEKFamIyDWetNTNxjKkPz2k04cCYCWn75RwXg3eCVVs5A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650726850; a=rsa-sha256; cv=none; b=W+26nQboChryaaTyRRnfD9wqukkjzIlLFi0q6LWVP+T7gfyjaUjzmIzOjp2fxXNYbDHilP vL9WidzlvsX7KqlGZVrgqLbX9SytwHg8ZJem8bWcBF0fMrYXh7PnHwTN2GWCWTjsKmgfnx pY49fkenirwLLoDlPF+bIflR7uFLXqnrKtNAG8E2NU6Noc1w2whcYzTmG6B4E2MzDaG8K6 IsJCDP76t2360Q3AkgXBs9eAlqEAMHBU4mKoHkrI52TnDdl/Dv0yVXQgD3A2/dMGDJXon8 M/L/wjA6JaurydfXBW5DWTL499dEto4EPIOKIO9zEAuIx0LNtvm7TggA2mFJFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QU3exQav; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QU3exQav; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 990E4BE8A X-Spam-Score: 5.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: pSO9pU/QCLbW > > Here, (if such a pattern repeats) we could define a new syntax > > `substitue` in the guix/packages.scm analogical to `delete`, > > `prepend`, `append` and `replace`. > > Isn't this just (modify-inputs ... (replace "..." ...))? > > What's the difference between 'replace' and 'substitute'? They > conceptually seem to be about the same to me. And in case of > substitute, I'm more thinking of 'substitute*' than package inputs. The lists `inputs`, `native-inputs` and `propagated-inputs` are lists of association lists that map input labels to file names. E.g.: (native-inputs `(("autoconf" ,autoconf) ("openjdk16:jdk" ,openjdk16 "jdk") ("pkg-config" ,pkg-config) ("unzip" ,unzip) ("which" ,which) ("zip" ,zip))) The `replace` just replaces the file name for a given input label (see guix/packages.scm, line 1099): (define (replace-input name replacement inputs) "Replace input NAME by REPLACEMENT within INPUTS." (map (lambda (input) (match input (((? string? label) _ . outputs) (if (string=? label name) (match replacement ;does REPLACEMENT specify an output? ((_ _) (cons label replacement)) (_ (cons* label replacement outputs))) input)))) inputs)) (define-syntax replace (lambda (s) (syntax-violation 'replace "'replace' may only be used within 'modify-inputs'" s))) See also https://guix.gnu.org/en/blog/2021/the-big-change/ > I'm more thinking of 'substitute*' than package inputs. That thing which I named `substitute` doesn't exist. I was just contemplating that we could write it, if we want to change the whole association list, i.e. the pair input label & file name, not just the file name. (And when I think about it again, such a name will lead to confusion. So nah, forget about it.) Cheers Bost