From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EFA7N53Ye2KU7AAAbAwnHQ (envelope-from ) for ; Wed, 11 May 2022 17:39:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WHYJN53Ye2LeCAAAauVa8A (envelope-from ) for ; Wed, 11 May 2022 17:39:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7DDD415242 for ; Wed, 11 May 2022 17:39:09 +0200 (CEST) Received: from localhost ([::1]:60200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nooQe-00045x-8c for larch@yhetil.org; Wed, 11 May 2022 11:39:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nooQY-00043r-EP for guix-patches@gnu.org; Wed, 11 May 2022 11:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nooQY-00014Q-2H for guix-patches@gnu.org; Wed, 11 May 2022 11:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nooQX-0004qh-Uv for guix-patches@gnu.org; Wed, 11 May 2022 11:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54852] [PATCH] gnu: Add openjdk18. Resent-From: Rostislav Svoboda Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 May 2022 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54852@debbugs.gnu.org Received: via spool by 54852-submit@debbugs.gnu.org id=B54852.165228350418574 (code B ref 54852); Wed, 11 May 2022 15:39:01 +0000 Received: (at 54852) by debbugs.gnu.org; 11 May 2022 15:38:24 +0000 Received: from localhost ([127.0.0.1]:38180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nooPw-0004pW-7d for submit@debbugs.gnu.org; Wed, 11 May 2022 11:38:24 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:35487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nooPu-0004pE-Ic for 54852@debbugs.gnu.org; Wed, 11 May 2022 11:38:23 -0400 Received: by mail-ed1-f47.google.com with SMTP id y21so3066246edo.2 for <54852@debbugs.gnu.org>; Wed, 11 May 2022 08:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aOzMebDKGnN9DsE+99i8THfs5TocB8IHXt2euv6ikvA=; b=KlsP1uLbSVClqIOLnRnTC70zQbQpgY4cNKGMmxsW07jmfbglmYrX6IS05lF0sy2frz U00CxshibUzBdlMERDwQm/0epbCgQkfG8Z7AwB/cDw0+fgO8YFE9Y2L+xlqFo5po6+eO Q6GAmdNUf4b/QKbQ5pZ7u9p37g6bO2A1A8o9IzNlJynBsZellnXi0CpXw23KXD5+lLfW VlkfketaVH0rRk03vFj6Uqc7bNGj/qMQprnzQadX0kFuGMWZ2vQd9VC8W2h8EwWssBVO CBnsvkIgOOSZR0UUAgUW33od+spYNk9q7mEDVf4k8TNf3LT4jSmmO4DRvaewBtSYLJlr fvew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aOzMebDKGnN9DsE+99i8THfs5TocB8IHXt2euv6ikvA=; b=nfSx+cxAJXSpCpQzVXptNeeEd3wMdMyU7o4osOhlRXyC/MkhGZ4rGP8SP7cJ7E2OWR kQVuW6g1jsDQU8oLiR25OOx2tex8LyeUDyqPCBYxNa9C0xybLU2gc2k4rRJLzsuNFdmU kWMXFsxk5Fep2L/PjOG3lyAMwqY5FndhPIlOBnsqdHv4Wg1CFuoV7NtUJptizdojJ1Tq 8cWtnDICt8YrUqyEe8VyB5kIAjNjyjtCObvdkRNWBDMah55VCarYUz8WnDzV9xi6EKet rFUTjVJFKMp4ptGkWEvUkuw8CxSado+KvhlWidI2C+gNPFz+CmsDh/EGsk/5CL/UyXyG rD5w== X-Gm-Message-State: AOAM533yOtvKuA4vPBwzwhCZazbv3TYDaAwnFNuLoc3nZRREd4NypoLF pxtJ4yUbhTUdRzdYDnDu1So0UEoJwyp0jiT26NA= X-Google-Smtp-Source: ABdhPJzmlC0LrmIip0XXZdkufwd2lpVeVghPziOH1sQl026zJmsO98m6D9x6gD7aEzfaqjrPfQ/ge88gqBkt/p28YHE= X-Received: by 2002:a05:6402:5244:b0:427:b24c:a799 with SMTP id t4-20020a056402524400b00427b24ca799mr29821608edd.291.1652283496454; Wed, 11 May 2022 08:38:16 -0700 (PDT) MIME-Version: 1.0 References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> In-Reply-To: From: Rostislav Svoboda Date: Wed, 11 May 2022 17:37:40 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652283549; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=aOzMebDKGnN9DsE+99i8THfs5TocB8IHXt2euv6ikvA=; b=BbNDl7r70hK8HqzTiPr+DyeKj/Mq/c+jrB+M9TTxYmXEKl6plPZm1jkml9LzQo9bCRXwUk GF2f0KzREWDB5cmt+mmpXQ5b5nAtbMEDSXTYM4fGeXzZIDOLWQN64pUsO6VMOx+XcQbItW +URsO4Jayv919NxPnwwhl/L55PWr+FAHS9L5Ea83WRomYcA0cKSJfoVoSao5LARoMrnRP0 qJEBgQ9nw+FBjk/1vRDxgxGLSrDRNhv/VyNBZvh5h7icqZbwM49kU/2ztW98BvMdCW0BAq zP0aYJlGt4prPrXTsASiJdCt4aFRVkfI4cuJFFlTs0dHYqiA1k/sTRCGy7QQTA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652283549; a=rsa-sha256; cv=none; b=TFJl+3qhTTsIeiWJSKCLPMLT/bw8PefUPDvQfqj/lm6ObRlZmwYi0XuPLu2oMyHD/J3Q68 jc3jabpvJkjZufAN5OIKxpZUH2FHWwGmXtAsVP1snOZC6cagSpn8Nlld3/SxsdQppB64/k XV9HkkCN9U229TlH0AMhqqPtQcm4QsJ4lMLnDQHui4jcg85gM5IfyWPRfw7z8Lc+kPVdgJ BT47UTVOtsEeIKZ+qhERiKEVoT7XnXmqnsEDZ++SJKh5P6yaxvB8qLJVH1/FogWQt/2jkW A01LQS6rSm+JBw/C9mplhNt4W6suJv2QV1SfJtYoqHwDjCJhA8JmpBz+QCOf6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KlsP1uLb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.49 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KlsP1uLb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7DDD415242 X-Spam-Score: 5.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: NUH9A6O27MaX Hi Maxime, > Instead, try: > > /home/bost/dev/guix > # do this inside a "guix shell -D guix" or whatever you use > # to set up a Guix development environment > $ make && time ./pre-inst-env guix build openjdk Ok thanks. (As you see, I need to learn a lot.) Regarding the build time (just for the record), I run $ cd /home/bost/dev/guix $ git checkout dev $ git --force -dx # make sure everything is pristine clean and clear $ guix shell --development guix # and then: [env]$ ./bootstrap && ./configure --localstatedir=/var && make -j24 [env]$ time ./pre-inst-env guix build openjdk ... real 4m32.993s user 0m26.175s sys 0m1.357s And my `dev` branch contains this openjdk18 definition: (define-public openjdk18 (package (inherit openjdk17) (name "openjdk") (version "18") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/openjdk/jdk18u") (commit (string-append "jdk-" version "-ga")))) (file-name (git-file-name name version)) (sha256 (base32 "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8")))) (native-inputs (map (lambda (input) (match (car input) ("openjdk16:jdk" `("openjdk17:jdk" ,openjdk17 "jdk")) (_ input))) (package-native-inputs openjdk17))) (home-page "https://openjdk.java.net/projects/jdk/18"))) > > ;; I'd prefer: [... > > (delete "openjdk16:jdk") > > (append `(("openjdk17:jdk" ,openjdk17 "jdk")))) > > If/when What do you mean by that??? > > About the labels issue: maybe "icedtea-8" could be changed to > > "icedtea", "openjdkN" to "openjdk" and "openjdkN:jdk" to > > "openjdk:jdk" at some point in the future, such that the package name > > matches the input label and the input alist can be changed to a > > package list. > > is addressed, WDYT of (replace "openjdk" openjdk)? ??? Could you explain that please? Because to me, out of any context, (e.g. when grep-ing over the source code,) that looks like a "replace a-thing with a-thing". I.e. effectively, a do-nothing command. Thank you. Greetings, Bost