From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Syme Subject: Re: [PATCH] gnu: Include CodingQuarry gene predictor Date: Fri, 11 Mar 2016 03:55:47 +0000 Message-ID: References: <20160308233937.GB24107@jasmine> <20160309175902.GB30271@solar> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113ec71a8dbfd2052dbde8c8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeEBD-00081r-HL for guix-devel@gnu.org; Thu, 10 Mar 2016 22:56:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeEBC-0007SC-8C for guix-devel@gnu.org; Thu, 10 Mar 2016 22:55:59 -0500 Received: from mail-io0-x22f.google.com ([2607:f8b0:4001:c06::22f]:33997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeEBC-0007S1-1d for guix-devel@gnu.org; Thu, 10 Mar 2016 22:55:58 -0500 Received: by mail-io0-x22f.google.com with SMTP id m184so131304975iof.1 for ; Thu, 10 Mar 2016 19:55:57 -0800 (PST) In-Reply-To: <20160309175902.GB30271@solar> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge , Leo Famulari Cc: guix-devel@gnu.org --001a113ec71a8dbfd2052dbde8c8 Content-Type: multipart/alternative; boundary=001a113ec71a8dbfcd052dbde8c6 --001a113ec71a8dbfcd052dbde8c6 Content-Type: text/plain; charset=UTF-8 Dear Guix, I have attached the amended patch to add the CodingQuarry gene predictor (v2.0). Thanks for the kind feedback on my previous patch. I have tried to make the formatting etc look as close as I can to the other GNU patches, but let me know if I've missed anything. Rob Syme Research Associate Pulse Pathology and Genetics Centre for Crop and Disease Management Curtin University On Thu, 10 Mar 2016 at 01:59 Andreas Enge wrote: > On Tue, Mar 08, 2016 at 06:39:37PM -0500, Leo Famulari wrote: > > > + (delete 'check) ;; Don't run the 'make check' step of the > > > gnu-build-system > > When skippping the tests, we prefer to say why in the comment. It can be > > as simple as "no test suite" if that is the case. > > And use in the argument block: > #:tests? #f > instead of deleting the phase. > > Andreas > > --001a113ec71a8dbfcd052dbde8c6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Dear Guix,

I have attached t= he amended patch to add the CodingQuarry gene predictor (v2.0). Thanks for = the kind feedback on my previous patch. I have tried to make the formatting= etc look as close as I can to the other GNU patches, but let me know if I&= #39;ve missed anything.

Rob Syme
Researc= h Associate
Pulse Pathology and Genetics
Centre for Cro= p and Disease Management
Curtin University

On Thu, 10 Mar 2016 at 01:59 = Andreas Enge <andreas@enge.fr>= wrote:
On Tue, Mar 08, 2016 at 06:= 39:37PM -0500, Leo Famulari wrote:
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(delete 'check) ;; Don'= ;t run the 'make check' step of the
> > gnu-build-system
> When skippping the tests, we prefer to say why in the comment. It can = be
> as simple as "no test suite" if that is the case.

And use in the argument block:
#:tests? #f
instead of deleting the phase.

Andreas

--001a113ec71a8dbfcd052dbde8c6-- --001a113ec71a8dbfd2052dbde8c8 Content-Type: text/x-patch; charset=US-ASCII; name="0001-gnu-Add-CodingQuarry.patch" Content-Disposition: attachment; filename="0001-gnu-Add-CodingQuarry.patch" Content-Transfer-Encoding: base64 Content-ID: <15363cdea3b808c31371> X-Attachment-Id: 15363cdea3b808c31371 RnJvbSA4Y2M4MTU5OTllNDQ4MWQ0NWU1MDNmYWE3N2UwNjA1MzIwNDM4NWY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgU3ltZSA8cm9iLnN5bWVAZ21haWwuY29tPgpEYXRlOiBG cmksIDExIE1hciAyMDE2IDExOjQ3OjI0ICswODAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBBZGQg Q29kaW5nUXVhcnJ5LgoKKiBnbnUvcGFja2FnZXMvYmlvaW5mb3JtYXRpY3Muc2NtIChjb2Rpbmdx dWFycnkpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2Jpb2luZm9ybWF0aWNzLnNj bSB8IDQzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUg Y2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9iaW9p bmZvcm1hdGljcy5zY20gYi9nbnUvcGFja2FnZXMvYmlvaW5mb3JtYXRpY3Muc2NtCmluZGV4IGIz ZDg4MjcuLmFlYzE2ZjMgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9iaW9pbmZvcm1hdGljcy5z Y20KKysrIGIvZ251L3BhY2thZ2VzL2Jpb2luZm9ybWF0aWNzLnNjbQpAQCAtOTU3LDYgKzk1Nyw0 OSBAQCBhbHNvIGluY2x1ZGVzIGFuIGludGVyZmFjZSBmb3IgdGFiaXguIikKICAgICAgIkNMSVBw ZXIgaXMgYSB0b29sIHRvIGRlZmluZSBwZWFrcyBpbiBDTElQLXNlcSBkYXRhc2V0cy4iKQogICAg IChsaWNlbnNlIGxpY2Vuc2U6Z3BsMikpKQogCisoZGVmaW5lLXB1YmxpYyBjb2RpbmdxdWFycnkK KyAgKHBhY2thZ2UKKyAgICAobmFtZSAiY29kaW5ncXVhcnJ5IikKKyAgICAodmVyc2lvbiAiMi4w IikKKyAgICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gp CisgICAgICAgICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQKKyAgICAgICAgICAgICAgICAgICAg Im1pcnJvcjovL3NvdXJjZWZvcmdlL2NvZGluZ3F1YXJyeS9Db2RpbmdRdWFycnlfdiIKKyAgICAg ICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAgICAgICAgICAoc2hhMjU2 CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICAgIjAxMTVoa2pmbHNuZnpu MzZ4cHB3ZjloOWF2ZnhsYXZyNDNkanFtc2hra3piZ2p6c3o2MGkiKSkpKQorICAgIChidWlsZC1z eXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgICcoIzp0ZXN0cz8g I2YgOyBubyAiY2hlY2siIHRhcmdldAorICAgICAgICM6cGhhc2VzCisgICAgICAgKG1vZGlmeS1w aGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgKGRlbGV0ZSAnY29uZmlndXJlKQorICAg ICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1 dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgIChsZXQqICgob3V0IChhc3NvYy1y ZWYgb3V0cHV0cyAib3V0IikpCisgICAgICAgICAgICAgICAgICAgIChiaW4gKHN0cmluZy1hcHBl bmQgb3V0ICIvYmluIikpCisgICAgICAgICAgICAgICAgICAgIChkb2MgKHN0cmluZy1hcHBlbmQg b3V0ICIvc2hhcmUvZG9jL2NvZGluZ3F1YXJyeSIpKSkKKyAgICAgICAgICAgICAgIChta2Rpci1w IGJpbikKKyAgICAgICAgICAgICAgIChta2Rpci1wIGRvYykKKyAgICAgICAgICAgICAgIChjb3B5 LWZpbGUgIklOU1RSVUNUSU9OUy5wZGYiCisgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJp bmctYXBwZW5kIGRvYyAiL0lOU1RSVUNUSU9OUy5wZGYiKSkKKyAgICAgICAgICAgICAgIChjb3B5 LXJlY3Vyc2l2ZWx5ICJRdWFycnlGaWxlcyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChzdHJpbmctYXBwZW5kIG91dCAiL1F1YXJyeUZpbGVzIikpCisgICAgICAgICAgICAgICAo aW5zdGFsbC1maWxlICJDb2RpbmdRdWFycnkiIGJpbikKKyAgICAgICAgICAgICAgIChpbnN0YWxs LWZpbGUgIkN1ZmZsaW5rc0dURl90b19Db2RpbmdRdWFycnlHRkYzLnB5IiBiaW4pKSkpKSkpCisg ICAgKGlucHV0cyBgKCgib3Blbm1waSIgLG9wZW5tcGkpKSkKKyAgICAobmF0aXZlLXNlYXJjaC1w YXRocworICAgICAobGlzdCAoc2VhcmNoLXBhdGgtc3BlY2lmaWNhdGlvbgorICAgICAgICAgICAg KHZhcmlhYmxlICJRVUFSUllfUEFUSCIpCisgICAgICAgICAgICAoZmlsZXMgJygiUXVhcnJ5Rmls ZXMiKSkpKSkKKyAgICAobmF0aXZlLWlucHV0cyBgKCgicHl0aG9uIiAscHl0aG9uLTIpKSkgOyBP bmx5IFB5dGhvbiAyIGlzIHN1cHBvcnRlZAorICAgIChzeW5vcHNpcyAiRnVuZ2FsIGdlbmUgcHJl ZGljdG9yIikKKyAgICAoZGVzY3JpcHRpb24gIkNvZGluZ1F1YXJyeSBpcyBhIGhpZ2hseSBhY2N1 cmF0ZSwgc2VsZi10cmFpbmluZyBHSE1NIGZ1bmdhbAorZ2VuZSBwcmVkaWN0b3IgZGVzaWduZWQg dG8gd29yayB3aXRoIGFzc2VtYmxlZCwgYWxpZ25lZCBSTkEtc2VxIHRyYW5zY3JpcHRzLiIpCisg ICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9zb3VyY2Vmb3JnZS5uZXQvcHJvamVjdHMvY29kaW5ncXVh cnJ5LyIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKQorCiAoZGVmaW5lLXB1YmxpYyBj b3VnZXIKICAgKHBhY2thZ2UKICAgICAobmFtZSAiY291Z2VyIikKLS0gCjIuNS4wCgo= --001a113ec71a8dbfd2052dbde8c8--