From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ePyPLdbb3mKOQwAAbAwnHQ (envelope-from ) for ; Mon, 25 Jul 2022 20:07:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AAmsLNbb3mLcSwAAG6o9tA (envelope-from ) for ; Mon, 25 Jul 2022 20:07:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5959917B88 for ; Mon, 25 Jul 2022 20:07:18 +0200 (CEST) Received: from localhost ([::1]:49196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oG2U7-00029b-JB for larch@yhetil.org; Mon, 25 Jul 2022 14:07:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG2Tu-000289-QB for guix-patches@gnu.org; Mon, 25 Jul 2022 14:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oG2Tu-0004cK-I1 for guix-patches@gnu.org; Mon, 25 Jul 2022 14:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oG2Tu-00076R-D6 for guix-patches@gnu.org; Mon, 25 Jul 2022 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56604] closed (Re: bug#56604: [PATCH 0/8] Update Clojure to 1.11.1.) Resent-From: Roman Scherer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Jul 2022 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56604@debbugs.gnu.org Received: via spool by 56604-submit@debbugs.gnu.org id=B56604.165877239427264 (code B ref 56604); Mon, 25 Jul 2022 18:07:02 +0000 Received: (at 56604) by debbugs.gnu.org; 25 Jul 2022 18:06:34 +0000 Received: from localhost ([127.0.0.1]:51464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oG2TR-00075f-Uy for submit@debbugs.gnu.org; Mon, 25 Jul 2022 14:06:34 -0400 Received: from mail-oa1-f48.google.com ([209.85.160.48]:35415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oG2TP-00075K-91 for 56604@debbugs.gnu.org; Mon, 25 Jul 2022 14:06:32 -0400 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-10cf9f5b500so15767628fac.2 for <56604@debbugs.gnu.org>; Mon, 25 Jul 2022 11:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Db1hR3KQDaUknuyNTS2cFPmwDbV5xRX9ooTcXAduzG4=; b=vch1qSeuWUMENZsTbfqLn1hGQ7SQggyavFSZTuo8DbdFx2R/Zimh8zsiERE6xoIfvB PsaLxyMiXrx91SlBBbvWVvDXvkAM68l1QZiPoGYEVVOZZgLb4Qeoi5oZZgcUZJrCrC4s CI6POGh9N0uFJbZQu+oueYbeiGMZy6DUlV3M6zbiDIjNpn9NoO6Oq7oH7SS4CloyjFjn GfJmYJC2/oK1AgO0/yYzkznAiPakyVI3LOZHqVZzEDnX24EOyPHyUX1YtgvRT+NJoAS4 mSf+Fc+ElOy51Ty7GPYSma69ALqtdIdAaKgAAO82OR1SBW3MdCPZdC8RMOxPMDY1u+/y k9cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Db1hR3KQDaUknuyNTS2cFPmwDbV5xRX9ooTcXAduzG4=; b=kMIKCeYUxpE3+AXKPOElhxTEjRL/FWAZ90+yOkUzzOoTgErqHYqI2XQD2+i7prMfp4 sFYFM63o9F7+qYCCV7KMYuT//nM48M+3TIaKuebB6GPrNtTpP6FH0VUyLTduXn6jR0KR aa6CshZ2xsyeEh/NnFVYOHNcO0BT9G0ZnrZUkgX7ryRFyM/V72+nSNr1mBPy7JFIV2ec rIQjNROTpSmQyHQCnqP4fthu+yO7wtCfQYHkllHhSiIp+OuQv3/hlpko67SMkL2bokIY ffFqkyvERiEcz9nBVW0CpVBNKpa9XxKrN3nDdWmGO/JcZ4gDfnCmMfTU7NhMnwGgXoZa 9qNA== X-Gm-Message-State: AJIora8Zp+zRUzTsCMH+RAnA8mqpTW9fqcNUzvUltjBCTM6C7153HMaP IaSDCBcCE0cVonck9g26JDT17HhXRcaVuEg9zAZG2t+h5zu8Vw== X-Google-Smtp-Source: AGRyM1vgYIXRpU6V8qjNeTE07mrMgqnrbB5Sxl4T9iIG3f6cO5jhfNf3QtwFevYsFUnthik1VdQCI1/k5sydjK+LSY8= X-Received: by 2002:a05:6870:5aa:b0:10d:7d87:25b5 with SMTP id m42-20020a05687005aa00b0010d7d8725b5mr6912652oap.268.1658772385381; Mon, 25 Jul 2022 11:06:25 -0700 (PDT) MIME-Version: 1.0 References: <87fsisg5mu.fsf@gnu.org> In-Reply-To: From: Roman Scherer Date: Mon, 25 Jul 2022 20:06:15 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000cb51f805e4a50a5a" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658772438; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Db1hR3KQDaUknuyNTS2cFPmwDbV5xRX9ooTcXAduzG4=; b=nA9ev38gSAQAh8JzLQC5mza9Syf21DWdNG/2BB35xDSProthdwdS9nM4c08DP/6u1mtRBF tUCLBxkNeUYsN3e+NlgxjMRTNZVo5nwBvr4OL3y8B83Uv+PbFFafk3EY8xsnKhjAH+NDJ4 dbsff+jHl+tE6KPq+rOXop2ledzLzHQQ7tu8krMVWIx1q1NEtcRJ+2tpLVcCla3wi9oB8Q 8gOjvBrPgEzGBxIciJF4EsRzaJOh6iGQ9I38U8ZDpMwUPCbGXTBVZ18pMTqRwnqbYTIPfL 5H/NJvDPcbKKBIZVUJhpDKr+/p0QEGmKfJqrpFSE0+2JLk6DZ2a89RN/D6BbmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658772438; a=rsa-sha256; cv=none; b=gH8SDdeei/VX2oGRZrUls/lTU7I415s3QjDnx6lYDl9KBoeE4sWWSv1aqjHbUnxjdP3zoS 9OwgSixFiHfDwJHdv/ZQ+e1aB7gDaeyrwgHLjWJLs6JBNvPcYbc7cvX2Zn8V7ql6K9Xr9T bDTK0mtxCyBuXr7LpazEtr1RgbsX0rr9jSeP7u+z6TmcGU9l9ZN3CnGRJ4/BKa4lbCaK10 OzXUC/8NgLxHT/6e1laCBf738VKoRwC7Zg+dX8i2Dk0VV0HGH5ccoY1CWMiwSIP0Ejotzo 1u1QNlQ7iG9EQM+IdRur4aHV6GxexJo0+RlbPykgsdc+hiEAltQS/alLCoOGHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=vch1qSeu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20210112.gappssmtp.com header.s=20210112 header.b=vch1qSeu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5959917B88 X-Spam-Score: 0.77 X-Migadu-Scanner: scn0.migadu.com X-TUID: dn4PYkIaxAqY --000000000000cb51f805e4a50a5a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Maxim and Ludo, thanks for your replies. Sorry that I was not answering earlier. The heat killed my laptop and I am having trouble to get set up again. I follow up when I have my new laptop. Thanks On Sat, Jul 23, 2022, 00:12 GNU bug Tracking System wrote: > Your bug report > > #56604: [PATCH 0/8] Update Clojure to 1.11.1. > > which was filed against the guix-patches package, has been closed. > > The explanation is attached below, along with your original report. > If you require more details, please reply to 56604@debbugs.gnu.org. > > -- > 56604: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56604 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > > > > ---------- Forwarded message ---------- > From: "Ludovic Court=C3=A8s" > To: r0man > Cc: 56604-done@debbugs.gnu.org > Bcc: > Date: Sat, 23 Jul 2022 00:11:05 +0200 > Subject: Re: bug#56604: [PATCH 0/8] Update Clojure to 1.11.1. > Hi, > > r0man skribis: > > > This phase makes sure the timestamp of compiled class files is set to a > later > > point in time than the timestamp of the corresponding Clojure source > files. If > > the timestamps of the class and source files are the same, the Clojure > > compiler will compile the sources again which can lead to issues. This > problem > > has been discussed here [1]. The suggested solution was to keep/adjust > the > > timestamps of the class files. > > Sounds reasonable. It=E2=80=99s a bummer though that the whole phase is = pasted > from ant-build-system.scm, the only difference being the timestamps > (1980 instead of 1970). > > I added a TODO comment in clojure-build-system.scm when applying the > patch. Could you follow up with a patch to factorize that? > > > Btw, I was a bit surprised that in Guix Clojure packages are AOT > compiled. The > > general wisdom in the Clojure community seems to be to avoid AOT > compilation > > when distributing libraries, and only AOT compiling Uberjars for final > > deployment. Due to issues like I mentioned in clojure-instaparse. > > > > Are we sure that AOT compiling all Clojure source files by default is a > good > > idea, instead of just compiling user declared namespaces which Leininge= n > and > > friends are doing? WDYT? > > Not much, but as you might have seen in ./etc/teams.scm, the project is > finally being structured as teams. There=E2=80=99s an opportunity for yo= u to > start a Clojure team and to take the lead! :-) > > As a first step, I=E2=80=99d recommend getting in touch with people who h= ave > worked on =E2=80=98clojure-build-system=E2=80=99 and packaged things in t= he past. > > > gnu: clojure-tools-cli: Update to 1.0.206. > > gnu: clojure-tools-gitlibs: Update to 2.4.181. > > gnu: clojure-tools-deps-alpha: Update to 0.14.1212. > > gnu: clojure-tools: Update to 1.11.1.1149. > > gnu: clojure: Update to 1.11.1. > > gnu: clojure-algo-generic: Fix test failing under AOT in Clojure > 1.11.1. > > gnu: clojure-core-match: Update to 1.0.0. > > gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT). > > I adjusted all the commit logs to follow our conventions; please > consider doing this next time: > > https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html > > The instaparse patch missed the hash update so I did that too. > > Thanks! > > Ludo=E2=80=99. > > > > > ---------- Forwarded message ---------- > From: r0man > To: guix-patches@gnu.org > Cc: > Bcc: > Date: Sat, 16 Jul 2022 20:17:34 +0200 > Subject: [PATCH 0/8] Update Clojure to 1.11.1. > Hello Guix, > > This patch series updates Clojure and it's packages to 1.11.1. > > It also adds the 'reset-class-timestamps phase to the Clojure build syste= m. > > This phase makes sure the timestamp of compiled class files is set to a > later > point in time than the timestamp of the corresponding Clojure source > files. If > the timestamps of the class and source files are the same, the Clojure > compiler will compile the sources again which can lead to issues. This > problem > has been discussed here [1]. The suggested solution was to keep/adjust th= e > timestamps of the class files. > > [1] https://www.mail-archive.com/clojure@googlegroups.com/msg99928.html > > Could you please review this? > > In the patch for clojure-instaparse, I disabled the AOT compilation > because of > a known issue. Is that ok? > > Btw, I was a bit surprised that in Guix Clojure packages are AOT compiled= . > The > general wisdom in the Clojure community seems to be to avoid AOT > compilation > when distributing libraries, and only AOT compiling Uberjars for final > deployment. Due to issues like I mentioned in clojure-instaparse. > > Are we sure that AOT compiling all Clojure source files by default is a > good > idea, instead of just compiling user declared namespaces which Leiningen > and > friends are doing? WDYT? > > Thanks Roman. > > r0man (8): > gnu: clojure-tools-cli: Update to 1.0.206. > gnu: clojure-tools-gitlibs: Update to 2.4.181. > gnu: clojure-tools-deps-alpha: Update to 0.14.1212. > gnu: clojure-tools: Update to 1.11.1.1149. > gnu: clojure: Update to 1.11.1. > gnu: clojure-algo-generic: Fix test failing under AOT in Clojure 1.11.1= . > gnu: clojure-core-match: Update to 1.0.0. > gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT). > > gnu/packages/clojure.scm | 185 +++++++++++++++++++--------- > guix/build/clojure-build-system.scm | 53 +++++++- > 2 files changed, 178 insertions(+), 60 deletions(-) > > -- > 2.36.1 > > --000000000000cb51f805e4a50a5a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Maxim and Ludo,

thanks for your replies. Sorry that I was not answering earlier. The heat = killed my laptop and I am having trouble to get set up again.

I follow up when I have my new laptop= .

Thanks

On S= at, Jul 23, 2022, 00:12 GNU bug Tracking System <help-debbugs@gnu.org> wrote:
Your bug report

#56604: [PATCH 0/8] Update Clojure to 1.11.1.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56604@debbugs.gnu.org.<= br>
--
56604: https://debbugs.gnu.org/cgi/b= ugreport.cgi?bug=3D56604
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems



---------- Forwarded message ----------
From:=C2=A0"Lud= ovic Court=C3=A8s" <ludo@gnu.org>
To:=C2=A0r0man <roman@= burningswell.com>
Cc:=C2=A056604-done@debbugs.gnu.org=
Bcc:=C2=A0
Date:=C2=A0Sat, 23 Jul 2022 00:11:05 +0200
Subject:=C2= =A0Re: bug#56604: [PATCH 0/8] Update Clojure to 1.11.1.
Hi,

r0man <roman@burningswell.com> skribis:

> This phase makes sure the timestamp of compiled class files is set to = a later
> point in time than the timestamp of the corresponding Clojure source f= iles. If
> the timestamps of the class and source files are the same, the Clojure=
> compiler will compile the sources again which can lead to issues. This= problem
> has been discussed here [1]. The suggested solution was to keep/adjust= the
> timestamps of the class files.

Sounds reasonable.=C2=A0 It=E2=80=99s a bummer though that the whole phase = is pasted
from ant-build-system.scm, the only difference being the timestamps
(1980 instead of 1970).

I added a TODO comment in clojure-build-system.scm when applying the
patch.=C2=A0 Could you follow up with a patch to factorize that?

> Btw, I was a bit surprised that in Guix Clojure packages are AOT compi= led. The
> general wisdom in the Clojure community seems to be to avoid AOT compi= lation
> when distributing libraries, and only AOT compiling Uberjars for final=
> deployment. Due to issues like I mentioned in clojure-instaparse.
>
> Are we sure that AOT compiling all Clojure source files by default is = a good
> idea, instead of just compiling user declared namespaces which Leining= en and
> friends are doing? WDYT?

Not much, but as you might have seen in ./etc/teams.scm, the project is
finally being structured as teams.=C2=A0 There=E2=80=99s an opportunity for= you to
start a Clojure team and to take the lead!=C2=A0 :-)

As a first step, I=E2=80=99d recommend getting in touch with people who hav= e
worked on =E2=80=98clojure-build-system=E2=80=99 and packaged things in the= past.

>=C2=A0 =C2=A0gnu: clojure-tools-cli: Update to 1.0.206.
>=C2=A0 =C2=A0gnu: clojure-tools-gitlibs: Update to 2.4.181.
>=C2=A0 =C2=A0gnu: clojure-tools-deps-alpha: Update to 0.14.1212.
>=C2=A0 =C2=A0gnu: clojure-tools: Update to 1.11.1.1149.
>=C2=A0 =C2=A0gnu: clojure: Update to 1.11.1.
>=C2=A0 =C2=A0gnu: clojure-algo-generic: Fix test failing under AOT in C= lojure 1.11.1.
>=C2=A0 =C2=A0gnu: clojure-core-match: Update to 1.0.0.
>=C2=A0 =C2=A0gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT).<= br>
I adjusted all the commit logs to follow our conventions; please
consider doing this next time:

=C2=A0 https://guix= .gnu.org/manual/devel/en/html_node/Submitting-Patches.html

The instaparse patch missed the hash update so I did that too.

Thanks!

Ludo=E2=80=99.




---------- Forwarded message ----------
From:=C2=A0r0man <= ;roman@burningswell.com>
To:=C2=A0guix-patches@gnu.org<= br>Cc:=C2=A0
Bcc:=C2=A0
Date:=C2=A0Sat, 16 Jul 2022 20:17:34 +0200Subject:=C2=A0[PATCH 0/8] Update Clojure to 1.11.1.
Hello Guix,

This patch series updates Clojure and it's packages to 1.11.1.

It also adds the 'reset-class-timestamps phase to the Clojure build sys= tem.

This phase makes sure the timestamp of compiled class files is set to a lat= er
point in time than the timestamp of the corresponding Clojure source files.= If
the timestamps of the class and source files are the same, the Clojure
compiler will compile the sources again which can lead to issues. This prob= lem
has been discussed here [1]. The suggested solution was to keep/adjust the<= br> timestamps of the class files.

[1] https://www.mail-a= rchive.com/clojure@googlegroups.com/msg99928.html

Could you please review this?

In the patch for clojure-instaparse, I disabled the AOT compilation because= of
a known issue. Is that ok?

Btw, I was a bit surprised that in Guix Clojure packages are AOT compiled. = The
general wisdom in the Clojure community seems to be to avoid AOT compilatio= n
when distributing libraries, and only AOT compiling Uberjars for final
deployment. Due to issues like I mentioned in clojure-instaparse.

Are we sure that AOT compiling all Clojure source files by default is a goo= d
idea, instead of just compiling user declared namespaces which Leiningen an= d
friends are doing? WDYT?

Thanks Roman.

r0man (8):
=C2=A0 gnu: clojure-tools-cli: Update to 1.0.206.
=C2=A0 gnu: clojure-tools-gitlibs: Update to 2.4.181.
=C2=A0 gnu: clojure-tools-deps-alpha: Update to 0.14.1212.
=C2=A0 gnu: clojure-tools: Update to 1.11.1.1149.
=C2=A0 gnu: clojure: Update to 1.11.1.
=C2=A0 gnu: clojure-algo-generic: Fix test failing under AOT in Clojure 1.1= 1.1.
=C2=A0 gnu: clojure-core-match: Update to 1.0.0.
=C2=A0 gnu: clojure-instaparse: Update to 1.4.12 (disabled AOT).

=C2=A0gnu/packages/clojure.scm=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 1= 85 +++++++++++++++++++---------
=C2=A0guix/build/clojure-build-system.scm |=C2=A0 53 +++++++-
=C2=A02 files changed, 178 insertions(+), 60 deletions(-)

--
2.36.1

--000000000000cb51f805e4a50a5a--