From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: [PATCH] gnu: Add python-contextlib2 Date: Mon, 7 Dec 2015 21:14:29 -0800 Message-ID: References: <564C7549.3070707@uq.edu.au> <87mvu0x4c9.fsf@gnu.org> <87d1ujw8mc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7bd7701e6039d505265c0cc4 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6Abi-0000HH-F3 for guix-devel@gnu.org; Tue, 08 Dec 2015 00:14:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6Abh-0004BE-E4 for guix-devel@gnu.org; Tue, 08 Dec 2015 00:14:34 -0500 In-Reply-To: <87d1ujw8mc.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: "guix-devel@gnu.org" --047d7bd7701e6039d505265c0cc4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, On 12/6/15, Ludovic Court=C3=A8s wrote: > Yes, could you adjust it and send an updated patch? > I've attached the new patch here. I've shortened a few lines, including the one requested. In particular, I've shortened every line of the description to 70 columns. Because of that, it looks like the first line of the description will wind up being significantly shorter than 70 chars. Are the newlines in the description significant? Or is there some reformatting that happens when the description is printed to the terminal, e.g. via "guix package --search=3Dfoo"? I'm just curious because one might find it aesthetically displeasing if the first line is cut short simply because we had to format to 70 columns the code where the package description happened to be defined. It's totally minor, though. I'm also not sure why my emacs did not automatically wrap the lines to 70 chars in the first place, since I do see that the fill-column variable was set to 70. I guess I'll have to look into that, but for now I was able to wrap it to 70 chars myself. > I must I was a bit confused, partly due to the reply-on-top, which made > it more difficult for me to see what you were referring to. Okay, I was > also late for other reasons ;-), but still, I think it=E2=80=99d be great= if you > could avoid top-posting. Thanks for pointing this out; I'll reply on the bottom from now on! Chris --047d7bd7701e6039d505265c0cc4 Content-Type: application/octet-stream; name="0001-gnu-Add-python-contextlib2.patch" Content-Disposition: attachment; filename="0001-gnu-Add-python-contextlib2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 RnJvbSA0MDg5YjEwZjM4NGIzODk5OTk1NzZkZmM4NzY2YzY2MWE1Nzg3YTRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpcyBNYXJ1c2ljaCA8Y21tYXJ1c2ljaEBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgNyBEZWMgMjAxNSAyMTowNzo0MCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogQWRkIHB5dGhvbi1jb250ZXh0bGliMi4KCiogZ251L3BhY2thZ2VzL3B5dGhvbi5zY20gKHB5 dGhvbi1jb250ZXh0bGliMiwgcHl0aG9uMi1jb250ZXh0bGliMik6CiAgTmV3IHZhcmlhYmxlcy4K LS0tCiBnbnUvcGFja2FnZXMvcHl0aG9uLnNjbSB8IDMxICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv Z251L3BhY2thZ2VzL3B5dGhvbi5zY20gYi9nbnUvcGFja2FnZXMvcHl0aG9uLnNjbQppbmRleCBk MDFjMWQzLi5jNzBmZGQwIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvcHl0aG9uLnNjbQorKysg Yi9nbnUvcGFja2FnZXMvcHl0aG9uLnNjbQpAQCAtNjU2NSwzICs2NTY1LDM0IEBAIG9mIHRoZSBT U0wgcGVlci4iKQogICAgIChhcmd1bWVudHMgYCgjOnB5dGhvbiAscHl0aG9uLTIpKQogICAgIChw cm9wYWdhdGVkLWlucHV0cwogICAgICBgKCgicHl0aG9uMi1weW9wZW5zc2wiICxweXRob24yLXB5 b3BlbnNzbCkpKSkpCisKKyhkZWZpbmUtcHVibGljIHB5dGhvbi1jb250ZXh0bGliMgorICAocGFj a2FnZQorICAgIChuYW1lICJweXRob24tY29udGV4dGxpYjIiKQorICAgICh2ZXJzaW9uICIwLjQu MCIpCisgICAgKHNvdXJjZQorICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gp CisgICAgICAgKHVyaSAocHlwaS11cmkgImNvbnRleHRsaWIyIiB2ZXJzaW9uKSkKKyAgICAgICAo c2hhMjU2CisgICAgICAgIChiYXNlMzIKKyAgICAgICAgICIwY21wMTMxZGxoMGQwenZ3MGF6YTF6 ZDEzZ2x2bmd6azhsYjRhdmtzMGhtN3l4d2RyOWFtIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIHB5 dGhvbi1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6cGhhc2VzCisgICAg ICAgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgKHJlcGxhY2UgJ2No ZWNrCisgICAgICAgICAgIChsYW1iZGEgXyAoemVybz8KKyAgICAgICAgICAgICAgICAgICAgICAo c3lzdGVtKgorICAgICAgICAgICAgICAgICAgICAgICAicHl0aG9uIiAidGVzdF9jb250ZXh0bGli Mi5weSIsICItdiIpKSkpKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cDovL2NvbnRleHRsaWIyLnJl YWR0aGVkb2NzLm9yZy8iKQorICAgIChzeW5vcHNpcyAiVG9vbHMgZm9yIGRlY29yYXRvcnMgYW5k IGNvbnRleHQgbWFuYWdlcnMiKQorICAgIChkZXNjcmlwdGlvbiAiVGhpcyBtb2R1bGUgaXMgcHJp bWFyaWx5IGEgYmFja3BvcnQgb2YgdGhlIFB5dGhvbgorMy4yIGNvbnRleHRsaWIgdG8gZWFybGll ciBQeXRob24gdmVyc2lvbnMuICBMaWtlIGNvbnRleHRsaWIsIGl0Citwcm92aWRlcyB1dGlsaXRp ZXMgZm9yIGNvbW1vbiB0YXNrcyBpbnZvbHZpbmcgZGVjb3JhdG9ycyBhbmQgY29udGV4dAorbWFu YWdlcnMuICBJdCBhbHNvIGNvbnRhaW5zIGFkZGl0aW9uYWwgZmVhdHVyZXMgdGhhdCBhcmUgbm90 IHBhcnQgb2YKK3RoZSBzdGFuZGFyZCBsaWJyYXJ5LiIpCisgICAgKGxpY2Vuc2UgcHNmbCkpKQor CisoZGVmaW5lLXB1YmxpYyBweXRob24yLWNvbnRleHRsaWIyCisgIChwYWNrYWdlLXdpdGgtcHl0 aG9uMiBweXRob24tY29udGV4dGxpYjIpKQotLSAKMi41LjAKCg== --047d7bd7701e6039d505265c0cc4--