From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Sun, 7 Jan 2018 19:19:50 +0100 Message-ID: References: <877etlo2fq.fsf@elephly.net> <87y3lzgmy1.fsf@gmail.com> <877etiz7uu.fsf@elephly.net> <87incg48ed.fsf@elephly.net> <87tvvyrdkn.fsf@gmail.com> <87bmi5shrm.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c042a9647beee056233baf9" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYFY1-0000V6-Gx for guix-devel@gnu.org; Sun, 07 Jan 2018 13:19:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYFY0-0003QU-GL for guix-devel@gnu.org; Sun, 07 Jan 2018 13:19:53 -0500 Received: from mail-it0-x22b.google.com ([2607:f8b0:4001:c0b::22b]:38423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYFY0-0003QI-A7 for guix-devel@gnu.org; Sun, 07 Jan 2018 13:19:52 -0500 Received: by mail-it0-x22b.google.com with SMTP id r6so6924122itr.3 for ; Sun, 07 Jan 2018 10:19:52 -0800 (PST) In-Reply-To: <87bmi5shrm.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --94eb2c042a9647beee056233baf9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-01-07 18:25 GMT+01:00 Ricardo Wurmus : > > G=C3=A1bor Boskovits writes: > > > https://github.com/Boskovits/guix/issues/58 > =E2=80=A6 > > What I don't understand, is why setting source and target to 1.7, > > like I did on java-aqute-libg did not work. > > How did you set it? Since this is using the package=E2=80=99s own build.= xml > you=E2=80=99d need to patch it. > > I tried two things: 1. set in the make-flags like this: -Dant.build.javac.source=3D1.7 -Dant.build.javac.target=3D1.7 this did not work, but complained that the source is 1.7 and no bootstrap classpath is set, so I guess that these properties are considered. 2. patched the build.xml: substituted -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > --94eb2c042a9647beee056233baf9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -01-07 18:25 GMT+01:00 Ricardo Wurmus <rekado@elephly.net>:=

G=C3=A1bor Boskovits <boskovits@g= mail.com> writes:

> https://github.com/Boskovits/guix/issues/58=
=E2=80=A6
> What I don't understand, is why setting sou= rce and target to 1.7,
> like I did on java-aqute-libg did not work.

How did you set it?=C2=A0 Since this is using the package=E2=80=99s = own build.xml
you=E2=80=99d need to patch it.

I tried two things:
1. set in the make-flags like this= :
-Dant.build.javac.source=3D1.7
-Dant.build.javac.targ= et=3D1.7
this did not work, but complained that the source is 1.7= and no bootstrap classpath is set, so I guess that these properties are co= nsidered.

2. patched the build.xml:
subs= tituted
<javac=C2=A0 srcdir=3D"${source.java}"
=
with
<javac=C2=A0 srcdir=3D"${source.java}"= ; soruce=3D"1.7" target=3D"1.7"
same re= sult as above.

This is the only package that right= now does not work on java8.
All others build.

I still have the issue with the java-simple-xml test failing, I'= ve temporarily disabled tests.

These are the only = two remaining.
=C2=A0
--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6=C2=A0 2150 197A 5888 235F ACAC
https:= //elephly.net



--94eb2c042a9647beee056233baf9--