From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= <boskovits@gmail.com>
Subject: Re: WIP gnu: poetry: Update to 1.0.3.
Date: Mon, 3 Feb 2020 19:20:36 +0100
Message-ID: <CAE4v=pjxnY5SK0D7jKL9v4vPKx=EUzLkWkhqE2dL4ywa-b8qeg@mail.gmail.com>
References: <20200203153122.llccmfho2fwtr7o7@rafflesia>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:37327)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <boskovits@gmail.com>) id 1iygL4-0001LB-Ml
 for guix-devel@gnu.org; Mon, 03 Feb 2020 13:20:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <boskovits@gmail.com>) id 1iygL2-0004Ey-ME
 for guix-devel@gnu.org; Mon, 03 Feb 2020 13:20:50 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:46681)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <boskovits@gmail.com>) id 1iygL2-0004BP-El
 for guix-devel@gnu.org; Mon, 03 Feb 2020 13:20:48 -0500
Received: by mail-ed1-x52b.google.com with SMTP id m8so17021326edi.13
 for <guix-devel@gnu.org>; Mon, 03 Feb 2020 10:20:48 -0800 (PST)
In-Reply-To: <20200203153122.llccmfho2fwtr7o7@rafflesia>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Tanguy Le Carrour <tanguy@bioneland.org>
Cc: Guix <guix-devel@gnu.org>

Hello,

Tanguy Le Carrour <tanguy@bioneland.org> ezt =C3=ADrta (id=C5=91pont: 2020.
febr. 3., H, 16:31):
>
> Dear Guix,
>
> I'm working on updating Poetry to version 1.0.3 and I have a problem
> with the version of a dependency.
>
> Poetry now depends on python-keyring >=3D20.0.0,<21.0.0. In Guix we
> have python-keyring     21.0.0, so it does not work once installed!
>
> What am I supposed to do?
>
> I see 3 different ways out of this:
> - patch the package to make it use our version (I tried but failed [1]);
> - ask upstream to update dependencies;
> - declare a new package python-keyring-20.0.0 and use it as an input.

Asking upstream to update would be great.

>
> [1]: attempt to patch setup.py
> -    (arguments `(#:tests? #f))                    ; tests depend on dbus=
 service
> +    (arguments
> +     `(#:tests? #f ;; Pypi does not have tests.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'change-dependencies
> +           (lambda _
> +             ;; Guix has version 21.0.0 of python-keyring
> +             (invoke "sed" "-i" "-e"
> +                     "s/keyring>=3D20.0.1,<21.0.0/keyring>=3D20.0.1,<22.=
0.0/"
> +                     "setup.py")
> +             #t)))))
>

What did not work in this case?
Also, do you think that you could replace invoke sed with substitute*?

> Any help welcome!
>
> --
> Tanguy
>

Best regards,
g_bor
--=20
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21