From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Packaging Jami progress Date: Tue, 5 Nov 2019 18:31:04 +0100 Message-ID: References: <20191104214754.793ec2ff@interia.pl> <20191105175001.389c6117@interia.pl> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ab925905969ccc5c" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:42710) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS2fn-0005vp-6g for guix-devel@gnu.org; Tue, 05 Nov 2019 12:31:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iS2fl-00078P-QF for guix-devel@gnu.org; Tue, 05 Nov 2019 12:31:19 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:40130) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iS2fl-00078I-JO for guix-devel@gnu.org; Tue, 05 Nov 2019 12:31:17 -0500 Received: by mail-ed1-x52c.google.com with SMTP id p59so16836863edp.7 for ; Tue, 05 Nov 2019 09:31:17 -0800 (PST) In-Reply-To: <20191105175001.389c6117@interia.pl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Wielkiewicz Cc: Guix-devel --000000000000ab925905969ccc5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Jan Wielkiewicz ezt =C3=ADrta (id=C5= =91pont: 2019. nov. 5., Ke 17:50): > Dnia 2019-11-04, o godz. 23:48:00 > G=C3=A1bor Boskovits napisa=C5=82(a): > > > Hello, > > > > This is most probably because fmt is missing from inputs. > > > This is because SObjectizer is missing from inputs. > > You can get further info about this in the cmake file: > > https://github.com/Stiffstream/restinio/blob/master/dev/CMakeLists.txt > > I packaged SObjectizer and placed it in the gnu/packages/cpp.scm file. > I also added SObjectizer and fmt as inputs, but the result is the same, > even though I tried removing commands, which add the subdirectories > from CMakeLists.txt. What's the proper way of dealing with situations > like this? Am I missing something important? Should I copy outputs of > fmt and sobjectizer into the directories? If so, how can I do this? > The inputs should be detected by cmake, and subdirs should only be used if not found. You could add a phase with copy-recursive if needed. I am not sure that we can't just simply copy the header into the output, but it's true that we would lose the tests then. > > (add-after 'unpack 'do-not-make-directories > (lambda _ > (substitute* "dev/CMakeLists.txt" > (("add_subdirectory(fmt)"= ) > "") (("add_subdirectory(so_5)") "")) > #t)) > > > > > This does not seem the upstream repo. Could you change it to the > > upstream one? (Albeit, it seems to be an official mirror.) > > (https://bitbucket.org/sobjectizerteam/restinio/src/default/) > > Or if there is a tarball available for the needed version, that would > > be even better ( > > > > https://bitbucket.org/sobjectizerteam/restinio/downloads/), but I > > don't know if these archives are stable. > > On the website, they say the software is hosted on github: > https://stiffstream.com/en/products/restinio.html Nice... and in the documentation section on the same site they say the mercurial repository is the upstream, and the github one is the mirror... > > > Also AFAIK git is always reproducible, whereas tarballs can get > rebuilt, so fetching using git is safer. > > > Jan Wielkiewicz > Best regards, g_bor > --000000000000ab925905969ccc5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> ezt = =C3=ADrta (id=C5=91pont: 2019. nov. 5., Ke 17:50):
Dnia 2019-11-04, o godz. 23:48:00
G=C3=A1bor Boskovits <boskovits@gmail.com> napisa=C5=82(a):

> Hello,
>
> This is most probably because fmt is missing from inputs.
> > This is because SObjectizer is missing from inputs.
> You can get further info about this in the cmake file:
> https://github= .com/Stiffstream/restinio/blob/master/dev/CMakeLists.txt

I packaged SObjectizer and placed it in the gnu/packages/cpp.scm file.
I also added SObjectizer and fmt as inputs, but the result is the same,
even though I tried removing commands, which add the subdirectories
from CMakeLists.txt. What's the proper way of dealing with situations like this? Am I missing something important? Should I copy outputs of
fmt and sobjectizer into the directories? If so, how can I do this?
The inputs should be detected by cma= ke, and subdirs should only be used if not found. You could add a phase wit= h copy-recursive if needed. I am not sure that we can't just simply cop= y the header into the output, but it's true that we would lose the test= s then.

(add-after 'unpack 'do-not-make-directories
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda _
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substitute* "dev/= CMakeLists.txt"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (("add_subdirectory(fmt)")
"") (("add_subdirectory(so_5)") ""))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#t))

>
> This does not seem the upstream repo. Could you change it to the
> upstream one? (Albeit, it seems to be an official mirror.)
> (https://bitbucket.org/so= bjectizerteam/restinio/src/default/)
> Or if there is a tarball available for the needed version, that would<= br> > be even better (
>
> https://bitbucket.org/sobje= ctizerteam/restinio/downloads/), but I
> don't know if these archives are stable.

On the website, they say the software is hosted on github:
https://stiffstream.com/en/products/rest= inio.html
Nice... and in the = documentation section on the same site they say the mercurial repository is= the upstream, and the github one is the mirror...
<= div class=3D"gmail_quote">


Also AFAIK git is always reproducible, whereas tarballs can get
rebuilt, so fetching using git is safer.


Jan Wielkiewicz
Best regards,= g_bor
--000000000000ab925905969ccc5c--