From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= <boskovits@gmail.com>
Subject: Re: Video Documentation for GNU GUIX (an Outreachy project)
Date: Mon, 29 Oct 2018 21:58:36 +0100
Message-ID: <CAE4v=pjXFW+BKmE8=Rvto+zFX0LvKb=SFWzhuHRqcm0LLP71CA@mail.gmail.com>
References: <CA+H0LRPUfE=LmSETuasan3bEjEkGPXRFoE5Qrd-9G8DYO8buTQ@mail.gmail.com>
	<20181017084521.29579a72@alma-ubu>
	<CAE4v=phvW_tNqOjbA82mA5kpdxBqmAtjHudQuoK-c_jnidK8Rg@mail.gmail.com>
	<CA+H0LROyOtdB-ZgtB_wkhkr1mTpQ3R4ANtDDY9veZ-Gi0xiT4g@mail.gmail.com>
	<20181018134637.25c82e09@alma-ubu>
	<CAE4v=ph3AcOU-Sj-Rm_oPF4ijrqDg4Cf+F3KLO33J4NkxzY0kQ@mail.gmail.com>
	<CA+H0LRMNv52ezAU8iEmJeZWOsES5GWvd2VYG31wcS-LR7zZgiQ@mail.gmail.com>
	<CAE4v=pi0Fn4p0qU-mz8X7KL+BNnsFXtVf=NBy1iGqnyB_6WdZQ@mail.gmail.com>
	<CA+H0LROx-kesRxp=D-Ch=vfWJ7+mYRCxkPYOH_0cMAmQ0SQJgg@mail.gmail.com>
	<CAE4v=phkJfbXvbce_WzBF6VzfPqg1i-43Aud=nNMRc5P-naj-Q@mail.gmail.com>
	<CAE4v=phy3G-GmNOJs+fKKiyCNguHTC=c6XT4Nej=QaiPDEs25g@mail.gmail.com>
	<CA+H0LRMpbBMS5v1Zwkv4kqe1vF-Qqqnpd6uYw84Ovpy=SKfdig@mail.gmail.com>
	<20181029205741.24759fd6@alma-ubu>
	<CA+H0LRMMkXTSYFHyjBOeH5qgb+MLibmCDog+ngAVWO_H1E1k7g@mail.gmail.com>
	<20181029212738.75de1734@alma-ubu>
	<CA+H0LRMuXJ9Ehsf0XmpUkvYpSccb4FHaieOaJaVD55T=wExR+Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <boskovits@gmail.com>) id 1gHEcd-000600-Cd
	for guix-devel@gnu.org; Mon, 29 Oct 2018 16:58:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <boskovits@gmail.com>) id 1gHEcc-0003F7-DZ
	for guix-devel@gnu.org; Mon, 29 Oct 2018 16:58:51 -0400
Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:41910)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <boskovits@gmail.com>) id 1gHEcc-0003Ev-7W
	for guix-devel@gnu.org; Mon, 29 Oct 2018 16:58:50 -0400
Received: by mail-ot1-x335.google.com with SMTP id c32so9001406otb.8
	for <guix-devel@gnu.org>; Mon, 29 Oct 2018 13:58:50 -0700 (PDT)
In-Reply-To: <CA+H0LRMuXJ9Ehsf0XmpUkvYpSccb4FHaieOaJaVD55T=wExR+Q@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Hello Lakshmi,

I did a preliminary review, that can make this contribution faster.
Here are my comments:

(package
  (name "r-weights")
  (version "1.0")
  (source
    (origin
      (method url-fetch)
      (uri (cran-uri "weights" version))
      (sha256
        (base32
          "0186bfpkhxngrshac6bpg37alp6slwhwd43inrm8hqg0vhpfgc4c"))))
  (build-system r-build-system)
  (propagated-inputs
    `(("r-gdata" ,r-gdata)
      ("r-hmisc" ,r-hmisc)
      ("r-mice" ,r-mice)))
  (home-page
    "http://cran.r-project.org/web/packages/weights")
  (synopsis "Weighting and Weighted Statistics")

Please use lower case for all words except the first.
The importer cannot find out which letters should be lower case,
this has to be done manually.

  (description
    "Provides a variety of functions for producing simple weighted
statistics, such as weighted Pearson's correlations, partial
correlations, Chi-Squared statistics, histograms, and t-tests.  Also
now includes some software for quickly recoding survey data and
plotting point estimates from interaction terms in regressions (and
multiply imputed regressions).  NOTE: Weighted partial correlation
calculations pulled to address a bug.")

Please, try to repharse this so that it has whole sentences, for
example like "This package provides...".

  (license gpl2+))

With these small modifications this looks good to me.