From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:35985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h3p0G-0003LC-Km
	for guix-patches@gnu.org; Tue, 12 Mar 2019 17:32:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h3ouS-00058K-Hh
	for guix-patches@gnu.org; Tue, 12 Mar 2019 17:26:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55452)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h3ouQ-000574-PF
	for guix-patches@gnu.org; Tue, 12 Mar 2019 17:26:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h3ouQ-0005Jq-Ci
	for guix-patches@gnu.org; Tue, 12 Mar 2019 17:26:02 -0400
Subject: [bug#34613] Acknowledgement ([PATCH] gnu: Add prometheus.)
Resent-Message-ID: <handler.34613.B34613.155242590320374@debbugs.gnu.org>
MIME-Version: 1.0
References: <20190222114537.1431-1-boskovits@gmail.com>
	<handler.34613.B.155083599830524.ack@debbugs.gnu.org>
	<CAE4v=phFeyXQOY59QbPkZKCRLsNFc5EhDJ_UCOzjsoSD3yT36A@mail.gmail.com>
	<87k1h5rr3k.fsf@gnu.org> <878sxkh8v8.fsf@ambrevar.xyz>
In-Reply-To: <878sxkh8v8.fsf@ambrevar.xyz>
From: =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@gmail.com>
Date: Tue, 12 Mar 2019 22:24:43 +0100
Message-ID: <CAE4v=pjGc4RWQb234PoGm5K4vu9LRRS9289Qy_oUK-eVfY5krw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 34613@debbugs.gnu.org

Hello,

Pierre Neidhardt <mail@ambrevar.xyz> ezt =C3=ADrta (id=C5=91pont: 2019. m=
=C3=A1rc.
12., K, 8:04):

>
> - If there are many dependencies (check the vendor/ folder), use it, it w=
ill be
>   easier and produce a package with an ideal closure size.

There are quite a lot.

> The Go build system does most things right.  A few pointers:
>
> - Prometheus might use its own build system, e.g. with a Makefile.  Then =
you'll
>   have to read the makefile to know what it's doing.

Yes, it does, but it turns out it is not actually needed.

>
> - In Go, it's possible to include multiple packages in the same repositor=
y.  Our
>   Go build system does not handle this very well and it's not possible to=
 use
>   multiple such packages as dependencies: you need to create a union.  Se=
e
>   go-golang-org-x-crypto-union.
>
> Let me know if you need more help, I can look into it.
>
> Good luck!

Thanks!

> Pierre Neidhardt
> https://ambrevar.xyz/


Best regards,
g_bor