From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Fri, 15 Dec 2017 14:52:02 +0100 Message-ID: References: <20171204191506.GC28066@jasmine.lan> <87609h3dzk.fsf@gmail.com> <87o9n3gz43.fsf@gmail.com> <20171213103248.GA12880@macbook41> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c0551a42eaee50560614ec8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePqPH-00019V-BI for guix-devel@gnu.org; Fri, 15 Dec 2017 08:52:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePqPE-0001st-QB for guix-devel@gnu.org; Fri, 15 Dec 2017 08:52:07 -0500 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]:46758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePqPE-0001rz-I9 for guix-devel@gnu.org; Fri, 15 Dec 2017 08:52:04 -0500 Received: by mail-it0-x230.google.com with SMTP id t1so19601796ite.5 for ; Fri, 15 Dec 2017 05:52:04 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --94eb2c0551a42eaee50560614ec8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I've found the problem with java-hamcrest-core. The root cause of this is that java-jarjar uses a bundled copy of asm, version 4.0. This asm version does not support icedtea8. I propose to use java-asm instead of the bundled one. In my opinion the best course of action should be: 1. create a package: java-asm-notest with tests diabled to break the dependency cycle on java-hamcrest-core 2. modify java-jarjar to use java-asm-notest instead of the bundled asm. 3. test if java-hamcrest-core now builds. It is a question if we want to iterate this cycle once more, with a tests-enabled java-asm. WDYT? 2017-12-13 23:50 GMT+01:00 G=C3=A1bor Boskovits : > I've built the whole covering on my wip-change-default-java8 branch. > The covering is 42 packages. > 19 builds fine. > 19 does not build because java-hamcrest-core does not build. > I'll have a look at this first, this is the most critical. > This is the issue link for reference: > https://github.com/Boskovits/guix/issues/16 > > 2017-12-13 19:04 GMT+01:00 G=C3=A1bor Boskovits : > >> The patches I made: >> >> This is the trivial: >> >> From f53ad84059786e0769a21a3a90a15189bcf2d61f Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?G=3DC3=3DA1bor=3D20Boskovits?=3D >> Date: Mon, 11 Dec 2017 21:18:37 +0100 >> Subject: [PATCH] Change java toolchain defaults to use java8. >> >> * gnu/packages/java.scm(icedtea): Point to icedtea-8. >> * gnu/packages/java.scm(ant): Point to ant/java8. >> --- >> gnu/packages/java.scm | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm >> index 6dfe554f3..547cc2dc1 100644 >> --- a/gnu/packages/java.scm >> +++ b/gnu/packages/java.scm >> @@ -1691,7 +1691,7 @@ IcedTea build harness.") >> '("jdk" "openjdk-src" "corba-drop" "jaxp-drop" "jaxws-= drop" >> "jdk-drop" "langtools-drop" "hotspot-drop"))))))) >> >> -(define-public icedtea icedtea-7) >> +(define-public icedtea icedtea-8) >> >> =0C >> (define-public ant/java8 >> @@ -1754,7 +1754,7 @@ IcedTea build harness.") >> (native-inputs >> `(("jdk" ,icedtea-7 "jdk"))))) >> >> -(define-public ant ant/java7) >> +(define-public ant ant/java8) >> >> (define-public ant-apache-bcel >> (package >> >> >> This is what I'd like to have your opinions on, is it ok to do it this w= ay, or should I rethink it >> >> (I like this, because this way we can leave ant-build-system alone, and = handling of >> >> default version in java.scm became consistent): >> >> From 1629a53ac5122d229b157a33806264772f18f6bc Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?G=3DC3=3DA1bor=3D20Boskovits?=3D >> Date: Mon, 11 Dec 2017 21:13:58 +0100 >> Subject: [PATCH] gnu:add ant/java7. >> >> * gnu/packages/java.scm(ant/java7): New variable. >> * gnu/packages/java.scm(ant): Changed variable semantics to point to def= ault ant. >> --- >> gnu/packages/java.scm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm >> index 0be488dec..6dfe554f3 100644 >> --- a/gnu/packages/java.scm >> +++ b/gnu/packages/java.scm >> @@ -1741,7 +1741,7 @@ IcedTea build harness.") >> >> ;; The 1.9.x series is the last that can be built with GCJ. The 1.10.x= series >> ;; requires Java 8. >> -(define-public ant >> +(define-public ant/java7 >> (package (inherit ant/java8) >> (version "1.9.9") >> (source (origin >> @@ -1754,6 +1754,8 @@ IcedTea build harness.") >> (native-inputs >> `(("jdk" ,icedtea-7 "jdk"))))) >> >> +(define-public ant ant/java7) >> + >> (define-public ant-apache-bcel >> (package >> (inherit ant/java8) >> >> >> 2017-12-13 12:07 GMT+01:00 G=C3=A1bor Boskovits : >> >>> Hello! >>> >>> It was getting quite intractable to see what I was doing, so I started >>> to fill my github issue tracker. Issues are labeled with >>> change-default-java8. >>> >>> >>> 2017-12-13 11:32 GMT+01:00 Efraim Flashner : >>> >>>> On Tue, Dec 12, 2017 at 06:06:52PM -0800, Chris Marusich wrote: >>>> > G=C3=A1bor Boskovits writes: >>>> > >>>> > > I will wait for your results for now... >>>> > >>>> .... >>>> > >>>> > * kodi@18.0_alpha-7-67fd70f: failed because of "potential infinite >>>> > recursion"; also it seems that it's looking for a DTD on the >>>> Internet >>>> > when instead it should be looking to find it in the inputs. >>>> > >>>> > --8<---------------cut here---------------start------------->8--- >>>> > [3684/3799] Linking default/source3/modules/libvfs_module_worm.so >>>> > [3685/3799] Linking default/source3/modules/libvfs >>>> _module_crossrename.so >>>> > [3686/3799] Linking default/source3/modules/libvfs_module_cap.so >>>> > [3687/3799] Linking default/source3/modules/libvfs_module_catia.so >>>> > [3688/3799] pidl.1: pidl/pidl -> bin/default/pidl/pidl.1 >>>> > [3689/3799] Parse::Pidl::Dump.3: pidl/lib/Parse/Pidl/Dump.pm -> >>>> bin/default/pidl/Parse::Pidl::Dump.3 >>>> > [3690/3799] Parse::Pidl::Wireshark::Conformance.3: >>>> pidl/lib/Parse/Pidl/Wireshark/Conformance.pm -> >>>> bin/default/pidl/Parse::Pidl::Wireshark::Conformance.3 >>>> > [3691/3799] Parse::Pidl::Util.3: pidl/lib/Parse/Pidl/Util.pm -> >>>> bin/default/pidl/Parse::Pidl::Util.3 >>>> > [3692/3799] Parse::Pidl::NDR.3: pidl/lib/Parse/Pidl/NDR.pm -> >>>> bin/default/pidl/Parse::Pidl::NDR.3 >>>> > [3693/3799] Parse::Pidl::Wireshark::NDR.3: >>>> pidl/lib/Parse/Pidl/Wireshark/NDR.pm -> bin/default/pidl/Parse::Pidl:: >>>> Wireshark::NDR.3 >>>> > [3694/3799] Generating manpages/smb.conf.5 >>>> > I/O error : Attempt to load network entity >>>> http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd >>>> > default/docs-xml/manpages/smb.conf.5.xml:2: warning: failed to load >>>> external entity "http://www.oasis-open.org/docbook/xml/4.2/docbookx.dt= d >>>> " >>>> > D DocBook XML V4.2//EN" "http://www.oasis-open.org/doc >>>> book/xml/4.2/docbookx.dtd" >>>> > >>>> ^ >>>> > runtime error: file /gnu/store/q0irgfv31s8m9s54zrc >>>> 908qb4cim08cg-docbook-xsl-1.79.1/xml/xsl/docbook-xsl-1.79.1/lib/lib.xs= l >>>> line 58 element choose >>>> > xsltApplySequenceConstructor: A potential infinite template recursio= n >>>> was detected. >>>> > You can adjust xsltMaxDepth (--maxdepth) in order to raise the >>>> maximum number of nested template calls and variables/params (currentl= y set >>>> to 3000). >>>> > Templates: >>>> > #0 name string.subst >>>> > #1 name string.subst >>>> > #2 name string.subst >>>> > #3 name string.subst >>>> > #4 name string.subst >>>> > #5 name string.subst >>>> > #6 name string.subst >>>> > #7 name string.subst >>>> > #8 name string.subst >>>> > #9 name string.subst >>>> > #10 name string.subst >>>> > #11 name string.subst >>>> > #12 name string.subst >>>> > #13 name string.subst >>>> > #14 name string.subst >>>> > Variables: >>>> > #0 >>>> > replacement >>>> > target >>>> > string >>>> > #1 >>>> > target >>>> > string >>>> > #2 >>>> > string >>>> > #3 >>>> > replacement >>>> > target >>>> > string >>>> > #4 >>>> > target >>>> > string >>>> > #5 >>>> > string >>>> > #6 >>>> > replacement >>>> > target >>>> > string >>>> > #7 >>>> > target >>>> > string >>>> > #8 >>>> > string >>>> > #9 >>>> > replacement >>>> > target >>>> > string >>>> > #10 >>>> > target >>>> > string >>>> > #11 >>>> > string >>>> > #12 >>>> > replacement >>>> > target >>>> > string >>>> > #13 >>>> > target >>>> > string >>>> > #14 >>>> > string >>>> > error: file default/docs-xml/manpages/smb.conf.5.xml >>>> > xsltRunStylesheet : run failed >>>> > Waf: Leaving directory `/tmp/guix-build-samba-4.7.3.d >>>> rv-0/samba-4.7.3/bin' >>>> > Build failed: -> task failed (err #11): >>>> > {task: manpages/smb.conf.5 smb.conf.5.xml,parameters.all.xml >>>> -> smb.conf.5} >>>> > make: *** [Makefile:8: all] Error 1 >>>> > phase `build' failed after 1063.6 seconds >>>> > note: keeping build directory `/tmp/guix-build-samba-4.7.3.drv-0' >>>> > builder for `/gnu/store/k3ykppkqdw6gyj115q >>>> jhbi50fa6hx317-samba-4.7.3.drv' failed with exit code 1 >>>> > @ build-failed /gnu/store/k3ykppkqdw6gyj115qjhbi50fa6hx317-samba-4.7= .3.drv >>>> - 1 builder for `/gnu/store/k3ykppkqdw6gyj115q >>>> jhbi50fa6hx317-samba-4.7.3.drv' failed with exit code 1 >>>> > --8<---------------cut here---------------end--------------->8--- >>>> > >>>> > I have not begun troubleshooting any of these existing issues yet. >>>> > >>>> > -- >>>> > Chris >>>> >>>> I tested building samba on aarch64 on core-updates and it failed in th= e >>>> same manner. For the purposes of updating the default JRE I would igno= re >>>> it and the resulting not being able to build kodi. >>>> >>>> >>>> -- >>>> Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99= =D7=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 >>>> GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 >>>> Confidentiality cannot be guaranteed on emails sent or received >>>> unencrypted >>>> >>> >>> >> > --94eb2c0551a42eaee50560614ec8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I've found the problem with java-hamcrest-core.
Th= e root cause of this is that java-jarjar uses a bundled copy of asm, versio= n 4.0.
This asm version does not support icedtea8.

=
I propose to use java-asm instead of the bundled one.
=
In my opinion the best course of action should be:
1. create a package: java-asm-notest with tests diabled to break the depen= dency cycle on java-hamcrest-core
2. modify java-jarjar to use ja= va-asm-notest instead of the bundled asm.
3. test if java-hamcres= t-core now builds.

It is a question if we want to = iterate this cycle once more, with a tests-enabled java-asm.
WDYT= ?


2017-12-13 23:50 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gm= ail.com>:
= I've built the whole covering on my wip-change-default-java8 branch.The covering is 42 packages.
19 builds fine.
19 does = not build because java-hamcrest-core does not build.
I'll hav= e a look at this first, this is the most critical.
This is the is= sue link for reference:

2017-12-13 19:04 GMT+01:00= G=C3=A1bor Boskovits <boskovits@gmail.com>:
The patches I made:

This is the trivial:
From f53ad84059786e0769a21a3a90a15189bcf=
2d61f Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?G=3DC3=3DA1bor=3D20Boskovits?=3D <boskovits@gmail.com>
Date: Mon, 11 Dec 2017 21:18:37 +0100
Subject: [PATCH] Change java toolchain defaults to use java8.

* gnu/packages/java.scm(icedtea): Point to icedtea-8.
* gnu/packages/java.scm(ant): Point to ant/java8.
---
 gnu/packages/java.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 6dfe554f3..547cc2dc1 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1691,7 +1691,7 @@ IcedTea build harness.")
                  '("jdk" "openjdk-src" "corba=
-drop" "jaxp-drop" "jaxws-drop"
                    "jdk-drop" "langtools-drop" "h=
otspot-drop")))))))
=20
-(define-public icedtea icedtea-7)
+(define-public icedtea icedtea-8)
=20
 =0C
 (define-public ant/java8
@@ -1754,7 +1754,7 @@ IcedTea build harness.")
     (native-inputs
      `(("jdk" ,icedtea-7 "jdk")))))
=20
-(define-public ant ant/java7)
+(define-public ant ant/java8)
=20
 (define-public ant-apache-bcel
   (package

This is what I'd like to have your opinions on=
, is it ok to do it this way, or should I rethink it
(I like this, beca=
use this way we can leave ant-build-system alone, and handling of
defau= lt version in java.scm became consistent):
From 1629a53ac5122d229b157a33806264772f18=
f6bc Mon Sep 17 00:00:00 2001
From: =3D?UTF-8?q?G=3DC3=3DA1bor=3D20Boskovits?=3D <boskovits@gmail.com>
Date: Mon, 11 Dec 2017 21:13:58 +0100
Subject: [PATCH] gnu:add ant/java7.

* gnu/packages/java.scm(ant/java7): New variable.
* gnu/packages/java.scm(ant): Changed variable semantics to point to defaul=
t ant.
---
 gnu/packages/java.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 0be488dec..6dfe554f3 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1741,7 +1741,7 @@ IcedTea build harness.")
=20
 ;; The 1.9.x series is the last that can be built with GCJ.  The 1.10.x se=
ries
 ;; requires Java 8.
-(define-public ant
+(define-public ant/java7
   (package (inherit ant/java8)
     (version "1.9.9")
     (source (origin
@@ -1754,6 +1754,8 @@ IcedTea build harness.")
     (native-inputs
      `(("jdk" ,icedtea-7 "jdk")))))
=20
+(define-public ant ant/java7)
+
 (define-public ant-apache-bcel
   (package
     (inherit ant/java8)

= 2017-12-13 12:07 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com= >:
Hello!

It was getting quite intractable to see = what I was doing, so I started to fill my github issue tracker. Issues are = labeled with change-default-java8.

<= br>
2017-12-13 11:32 GMT+01:00 Efraim Flashner <efraim@flashner.co.il>:
On Tue, Dec 12, 2017 at 06:06:52PM -0800, Chris M= arusich wrote:
> G=C3=A1bor Boskovits <boskovits@gmail.com> writes:
>
> > I will wait for your results for now...
>
....
>
> * kodi@18.0_alpha-7-67fd70f: failed because of "potential infinit= e
>=C2=A0 =C2=A0recursion"; also it seems that it's looking for a= DTD on the Internet
>=C2=A0 =C2=A0when instead it should be looking to find it in the inputs= .
>
> --8<---------------cut here---------------start-------------&g= t;8---
> [3684/3799] Linking default/source3/modules/libvfs_module_worm.so=
> [3685/3799] Linking default/source3/modules/libvfs_module_crossre= name.so
> [3686/3799] Linking default/source3/modules/libvfs_module_cap.so<= br> > [3687/3799] Linking default/source3/modules/libvfs_module_catia.s= o
> [3688/3799] pidl.1: pidl/pidl -> bin/default/pidl/pidl.1
> [3689/3799] Parse::Pidl::Dump.3: pidl/lib/Parse/Pidl/Dump.pm -> bin= /default/pidl/Parse::Pidl::Dump.3
> [3690/3799] Parse::Pidl::Wireshark::Conformance.3: pidl/lib/Parse= /Pidl/Wireshark/Conformance.pm -> bin/default/pidl/Parse::Pidl::Wireshark::Conformance.3
> [3691/3799] Parse::Pidl::Util.3: pidl/lib/Parse/Pidl/Util.pm -> bin= /default/pidl/Parse::Pidl::Util.3
> [3692/3799] Parse::Pidl::NDR.3: pidl/lib/Parse/Pidl/NDR.pm -> bin/d= efault/pidl/Parse::Pidl::NDR.3
> [3693/3799] Parse::Pidl::Wireshark::NDR.3: pidl/lib/Parse/Pidl/Wiresha= rk/NDR.pm -> bin/default/pidl/Parse::Pidl::Wireshark::NDR.3 > [3694/3799] Generating manpages/smb.conf.5
> I/O error : Attempt to load network entity http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd
> default/docs-xml/manpages/smb.conf.5.xml:2: warning: failed to lo= ad external entity "http://www.oasis-open= .org/docbook/xml/4.2/docbookx.dtd"
> D DocBook XML V4.2//EN" "http:/= /www.oasis-open.org/docbook/xml/4.2/docbookx.dtd"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
> runtime error: file /gnu/store/q0irgfv31s8m9s54zrc908qb4cim08cg-d= ocbook-xsl-1.79.1/xml/xsl/docbook-xsl-1.79.1/lib/lib.xsl line 58 = element choose
> xsltApplySequenceConstructor: A potential infinite template recursion = was detected.
> You can adjust xsltMaxDepth (--maxdepth) in order to raise the maximum= number of nested template calls and variables/params (currently set to 300= 0).
> Templates:
> #0 name string.subst
> #1 name string.subst
> #2 name string.subst
> #3 name string.subst
> #4 name string.subst
> #5 name string.subst
> #6 name string.subst
> #7 name string.subst
> #8 name string.subst
> #9 name string.subst
> #10 name string.subst
> #11 name string.subst
> #12 name string.subst
> #13 name string.subst
> #14 name string.subst
> Variables:
> #0
> replacement
> target
> string
> #1
> target
> string
> #2
> string
> #3
> replacement
> target
> string
> #4
> target
> string
> #5
> string
> #6
> replacement
> target
> string
> #7
> target
> string
> #8
> string
> #9
> replacement
> target
> string
> #10
> target
> string
> #11
> string
> #12
> replacement
> target
> string
> #13
> target
> string
> #14
> string
> error: file default/docs-xml/manpages/smb.conf.5.xml
> xsltRunStylesheet : run failed
> Waf: Leaving directory `/tmp/guix-build-samba-4.7.3.drv-0/samba-4= .7.3/bin'
> Build failed:=C2=A0 -> task failed (err #11):
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{task: manpages/smb.conf.5 smb.conf.5.xml,pa= rameters.all.xml -> smb.conf.5}
> make: *** [Makefile:8: all] Error 1
> phase `build' failed after 1063.6 seconds
> note: keeping build directory `/tmp/guix-build-samba-4.7.3.drv-0&= #39;
> builder for `/gnu/store/k3ykppkqdw6gyj115qjhbi50fa6hx317-samba-4.= 7.3.drv' failed with exit code 1
> @ build-failed /gnu/store/k3ykppkqdw6gyj115qjhbi50fa6hx317-samba-= 4.7.3.drv - 1 builder for `/gnu/store/k3ykppkqdw6gyj115qjhbi50fa6hx317= -samba-4.7.3.drv' failed with exit code 1
> --8<---------------cut here---------------end---------------&g= t;8---
>
> I have not begun troubleshooting any of these existing issues yet.
>
> --
> Chris

I tested building samba on aarch64 on core-updates and it faile= d in the
same manner. For the purposes of updating the default JRE I would ignore it and the resulting not being able to build kodi.


--
Efraim Flashner=C2=A0 =C2=A0<efraim@flashner.co.il>=C2=A0 =C2=A0=D7=90=D7=A4=D7= =A8=D7=99=D7=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D=C2=A0 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted=




--94eb2c0551a42eaee50560614ec8--