From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: GSoC: Adding a web interface similar to the Hydra web interface Date: Tue, 29 May 2018 18:17:37 +0200 Message-ID: References: <87vac3twbe.fsf@gnu.org> <87o9hog2ye.fsf@elephly.net> <87d0xyn9zs.fsf@elephly.net> <87d0xswvls.fsf@elephly.net> <87r2m4ntk4.fsf@mdc-berlin.de> <87tvqxy4i9.fsf@elephly.net> <87h8mqxx7b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a398ed056d5a9258" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNhJd-0005OP-V8 for guix-devel@gnu.org; Tue, 29 May 2018 12:17:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNhJc-0002SS-Q2 for guix-devel@gnu.org; Tue, 29 May 2018 12:17:41 -0400 In-Reply-To: <87h8mqxx7b.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel , Tatiana Sholokhova --000000000000a398ed056d5a9258 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-05-29 18:07 GMT+02:00 Ludovic Court=C3=A8s : > Hello Tatiana & all, > > Ricardo Wurmus skribis: > > >> I am a bit confused about the database structure. As far as I > understand, > >> there are project_name (project) and branch_name (jobset) properties, > but > >> project_name is a primary key, so a project can't have several branche= s? > > > > I share your confusion. Maybe Ludovic or Mathieu can shed some more > > light on this. > > It=E2=80=99s confusing indeed, I think it=E2=80=99s a mistake that has ye= t to be fixed. > Basically what we do now is that we use a different =E2=80=98repo_name=E2= =80=99 when we > just want to add a branch=E2=80=A6 > > We should fix it at some point. Suggestions welcome! > > I believe the confusion arises from the fact, that there is a naming inconsistency. If we could come up with good names to the things involved, then that might suggest a clean solution. It seems that the problem is caused by a project and a repository is somehow intermixed. That might suggest a solution to keep project-name as is, as primary key, and add a separate repository field... or not. Does that make sense? > I would encourage you to write commits in a way to minimize friction > when we are to merge them=E2=80=94that is, following the conventions that > Ricardo outlined. That way Mathieu, Ricardo, or myself can take a look > and quickly cherry-pick to master. > > Anyway, kudos on what you=E2=80=99ve already achieved! Getting started o= n an > existing code base is never easy, so I think you=E2=80=99ve done a good j= ob. > > Thank you, > Ludo=E2=80=99. > > --000000000000a398ed056d5a9258 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -05-29 18:07 GMT+02:00 Ludovic Court=C3=A8s <ludo@gnu.org>:
=
Hello Tatiana & all,

Ricardo Wurmus <rekado@elephly.net= > skribis:

>> I am a bit confused about the database structure. As far as I unde= rstand,
>> there are project_name (project) and branch_name (jobset) properti= es, but
>> project_name is a primary key, so a project can't have several= branches?
>
> I share your confusion.=C2=A0 Maybe Ludovic or Mathieu can shed some m= ore
> light on this.

It=E2=80=99s confusing indeed, I think it=E2=80=99s a mistake that h= as yet to be fixed.
Basically what we do now is that we use a different =E2=80=98repo_name=E2= =80=99 when we
just want to add a branch=E2=80=A6

We should fix it at some point.=C2=A0 Suggestions welcome!


I believe the confusion arises from th= e fact, that there is a naming inconsistency.
If we could come up= with good names to the things involved, then that might
suggest = a clean solution. It seems that the problem is caused by a project and
a repository is somehow intermixed. That might suggest a solution to = keep
project-name as is, as primary key, and add a separate repos= itory field... or not.
Does that make sense?
=C2=A0
I would encourage you to write commits in a way to minimize friction
when we are to merge them=E2=80=94that is, following the conventions that Ricardo outlined.=C2=A0 That way Mathieu, Ricardo, or myself can take a loo= k
and quickly cherry-pick to master.

Anyway, kudos on what you=E2=80=99ve already achieved!=C2=A0 Getting starte= d on an
existing code base is never easy, so I think you=E2=80=99ve done a good job= .

Thank you,
Ludo=E2=80=99.


--000000000000a398ed056d5a9258--