From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@gmail.com>
Subject: bug#39648: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 20:19:11 +0100
Message-ID: <CAE4v=pjBVmuAawDHMJizh7nuBcXB72RcEdsS9mdnsMSsB4WgQA@mail.gmail.com>
References: <6bad163b0ed969c5c1117f9fa7446631060a8d4d.camel@disroot.org>
 <875zg56nq4.fsf@nckx>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:53803)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j3lw3-00031z-Hh
 for bug-guix@gnu.org; Mon, 17 Feb 2020 14:20:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j3lw2-0005nW-HO
 for bug-guix@gnu.org; Mon, 17 Feb 2020 14:20:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:33280)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j3lw2-0005nM-Dn
 for bug-guix@gnu.org; Mon, 17 Feb 2020 14:20:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j3lw2-0002Nk-96
 for bug-guix@gnu.org; Mon, 17 Feb 2020 14:20:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.39648.B39648.15819671709106@debbugs.gnu.org>
In-Reply-To: <875zg56nq4.fsf@nckx>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 39648@debbugs.gnu.org, Raghav Gururajan <raghavgururajan@disroot.org>

Hello Tobias,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
ezt =C3=ADrta (id=C5=91pont: 2020. febr. 17., H, 20:03):
>
> Raghav Gururajan =E5=86=99=E9=81=93=EF=BC=9A
> > Could you please reverse my following commits:
> >
> > 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
> >
> > 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
> >
> > 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
> >
> > 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.

I agree.

>
> The first two only add packages (did they break anything? what?),
> the third has no effect on packages if your commit message is
> accurate.

These findings are accurate. I checked the diff of the third, it's ok.

>
> The fourth is the only one that removes packages, and even that
> might be better tweaked (this time: with comments noting what each
> non-core package brings to the GNOME table) than flat-out
> reverted.
>

I believe the fourth can be reverted if needed.

> What do you think?
>
> Kind regards,
>
> T G-R


Best regards,
g_bor
--=20
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21