From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: proposal: with-file-writeable Date: Fri, 16 Feb 2018 07:35:46 +0100 Message-ID: References: <87wozfp2wk.fsf@gnu.org> <878tbuwd6y.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c088ff8f3e52805654e8d8a" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emZcd-0002bH-4T for guix-devel@gnu.org; Fri, 16 Feb 2018 01:35:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emZcc-0001OJ-7Z for guix-devel@gnu.org; Fri, 16 Feb 2018 01:35:51 -0500 In-Reply-To: <878tbuwd6y.fsf@fastmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: Guix-devel --94eb2c088ff8f3e52805654e8d8a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-02-15 15:16 GMT+01:00 Marius Bakke : > G=C3=A1bor Boskovits writes: > > > Ok, the keep it this way. Another question, this came up, as > > I was trying to find a nice solution to reset-gzip-timestamps failing. > > I got different pieces of advice if I should reset the permissions afte= r > > resetting the timestamp, but I'm still not sure. It seems that the > easiest > > way to this would be to just add a call to make-file-writable to the > phase > > at the beginning, as we finally end up with a read-only one in the stor= e > > anyway. I feel that reseting the permissions is unneccesary additional > > complexity. WDYT? > > In the "strip" phase we already call "make-file-writeable" > unconditionally, so doing it in reset-gzip-permissions as well should be > okay I think. > Ok, thanks, I will prepare a patch. --94eb2c088ff8f3e52805654e8d8a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -02-15 15:16 GMT+01:00 Marius Bakke <mbakke@fastmail.com>:=
G=C3=A1bor Boskovits &l= t;boskovits@gmail.com> writes= :

> Ok, the keep it this way. Another question, this came up, as
> I was trying to find a nice solution to reset-gzip-timestamps failing.=
> I got different pieces of advice if I should reset the permissions aft= er
> resetting the timestamp, but I'm still not sure. It seems that the= easiest
> way to this would be to just add a call to make-file-writable to the p= hase
> at the beginning, as we finally end up with a read-only one in the sto= re
> anyway. I feel that reseting the permissions is unneccesary additional=
> complexity. WDYT?

In the "strip" phase we already call "make-file-write= able"
unconditionally, so doing it in reset-gzip-permissions as well should be okay I think.

Ok, thanks, I will = prepare a patch.

--94eb2c088ff8f3e52805654e8d8a--