bug#19599: strace test suite failures

bug#19599: strace test suite failures

[Mark H Weaver]

The strace builds on both x86_64 and i686 intermittently fail,
apparently based on 'uname' output which in turn depends on which build
slave was used.  See:

  http://hydra.gnu.org/build/196334/log/tail-reload

--8<---------------cut here---------------start------------->8---
starting phase `check'
make  check-recursive
make[1]: Entering directory '/tmp/nix-build-strace-4.7.drv-0/strace-4.7'
Making check in tests
make[2]: Entering directory '/tmp/nix-build-strace-4.7.drv-0/strace-4.7/tests'
make  check-TESTS
make[3]: Entering directory '/tmp/nix-build-strace-4.7.drv-0/strace-4.7/tests'
../strace: Bad OS release string: '3.14-2-amd64'
ptrace_setoptions: framework failure: ../strace is not available
FAIL: ptrace_setoptions
../strace: Bad OS release string: '3.14-2-amd64'
strace-f: framework failure: ../strace is not available
FAIL: strace-f
===================
2 of 2 tests failed
===================
--8<---------------cut here---------------end--------------->8---

       Mark

bug#19599: strace test suite failures

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> ../strace: Bad OS release string: '3.14-2-amd64'

The relevant code in strace.c in 4.7 is this:

--8<---------------cut here---------------start------------->8---
	/* u.release has this form: "3.2.9[-some-garbage]" */
	rel = 0;
	p = u.release;
	for (;;) {
		if (!(*p >= '0' && *p <= '9'))
			error_msg_and_die("Bad OS release string: '%s'", u.release);
		/* Note: this open-codes KERNEL_VERSION(): */
		rel = (rel << 8) | atoi(p);
		if (rel >= KERNEL_VERSION(1,0,0))
			break;
		while (*p >= '0' && *p <= '9')
			p++;
		if (*p != '.')
			error_msg_and_die("Bad OS release string: '%s'", u.release);
		p++;
	}
	return rel;
--8<---------------cut here---------------end--------------->8---

Basically it expects A.B.C where A, B, and C are numbers, which is not
the case on this particular build machine.

This is really an strace bug since there are occasionally two-number
version strings for Linux:
<https://www.kernel.org/pub/linux/kernel/v3.x/>.
We should report it there.

Ludo’.

bug#19599: Closing, upstream fixed the issue

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 59 bytes --]

Upstream fixed the issue in version 4.8. We now have 4.21.

[-- Attachment #2: Type: text/html, Size: 80 bytes --]