From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eakDb-00014C-3E for guix-patches@gnu.org; Sun, 14 Jan 2018 10:29:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eakDW-0005Kx-A3 for guix-patches@gnu.org; Sun, 14 Jan 2018 10:29:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eakDW-0005Kn-5i for guix-patches@gnu.org; Sun, 14 Jan 2018 10:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eakDV-000438-Vk for guix-patches@gnu.org; Sun, 14 Jan 2018 10:29:01 -0500 Subject: [bug#29891] [PATCH] gnu: java-classpathx-servletapi: Update to 3.0-r1244. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <052c85c4-0370-35d3-17dd-66d5f2667592@tobias.gr> References: <20180109105517.29578-1-boskovits@gmail.com> <052c85c4-0370-35d3-17dd-66d5f2667592@tobias.gr> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Sun, 14 Jan 2018 16:28:51 +0100 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c05921aa9317a0562be27b4" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 29891@debbugs.gnu.org --94eb2c05921aa9317a0562be27b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I will send an updated patch soon. Upstream released this fix as 3.0.1, so it will be just update to 3.0.1. I would add something like remove obsolate comment, and that will be all. I'm a bit slow here, I had to run guix gc, so I have a lot to rebuild. I will send an updated patch asap. 2018-01-14 16:04 GMT+01:00 Tobias Geerinckx-Rice : > G=C3=A1bor, > > G=C3=A1bor Boskovits wrote on 09/01/18 at 11:56: > > Reworded commit message. > > Sorry to be a drive-by nit-picker, but this commit message is still much > longer than needed: > > > 2018-01-09 11:55 GMT+01:00 G=C3=A1bor Boskovits > >: > > > > * gnu/packages/java.scm (java-classpathx-servletapi): Update to > > 3.0-r1244. > > [source]: Change to svn-fetch from upstream. (This version is only > > available from there) > > That parenthesis should be far more useful to future generations as a > comment in the code. > > > [arguments]: Switch to a java8 compiler, remove comment about not > > working with java8, > > The first half implies the second: I'd not mention the comment. > > > add phase chdir to compensate for the different layout of the > > upstream repository. > > Also very verbose (just =E2=80=9CAdd =E2=80=98chdir=E2=80=99 phase.=E2=80= =9D?) but OK :-) > > Kind regards, > > T G-R > --94eb2c05921aa9317a0562be27b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I will send an updated patch soon. Upstream released this = fix as 3.0.1, so it will be just update to 3.0.1.
I would add something= like remove obsolate comment, and that will be all.
I'm a bi= t slow here, I had to run guix gc, so I have a lot to rebuild.
I = will send an updated patch asap.

=
2018-01-14 16:04 GMT+01:00 Tobias Geerinckx-Rice= <me= @tobias.gr>:
G=C3=A1bor,
G=C3=A1bor Boskovits wrote on 09/01/18 at 11:56:
> Reworded commit message.

Sorry to be a drive-by nit-picker, but this commit message is still much longer than needed:

> 2018-01-09 11:55 GMT+01:00 G=C3=A1bor Boskovits <boskovits@gmail.com
> <mailto:boskovits@gma= il.com>>:
>
>=C2=A0 =C2=A0 =C2=A0* gnu/packages/java.scm (java-classpathx-servletapi= ): Update to
>=C2=A0 =C2=A0 =C2=A03.0-r1244.
>=C2=A0 =C2=A0 =C2=A0[source]: Change to svn-fetch from upstream. (This = version is only
>=C2=A0 =C2=A0 =C2=A0available from there)

That parenthesis should be far more useful to future generations as = a
comment in the code.

>=C2=A0 =C2=A0 =C2=A0[arguments]: Switch to a java8 compiler, remove com= ment about not
>=C2=A0 =C2=A0 =C2=A0working with java8,

The first half implies the second: I'd not mention the comment.<= br>
>=C2=A0 =C2=A0 =C2=A0add phase chdir to compensate for the different lay= out of the
>=C2=A0 =C2=A0 =C2=A0upstream repository.

Also very verbose (just =E2=80=9CAdd =E2=80=98chdir=E2=80=99 phase.= =E2=80=9D?) but OK :-)

Kind regards,

T G-R

--94eb2c05921aa9317a0562be27b4--